Revision 0933840acf7b65d6d30a5b6089d882afea57aca3 authored by Jiri Olsa on 20 October 2016, 11:10:11 UTC, committed by Ingo Molnar on 28 October 2016, 09:06:25 UTC
CAI Qian reported a crash in the PMU uncore device removal code, enabled by the CONFIG_DEBUG_TEST_DRIVER_REMOVE=y option: https://marc.info/?l=linux-kernel&m=147688837328451 The reason for the crash is that perf_pmu_unregister() tries to remove a PMU device which is not added at this point. We add PMU devices only after pmu_bus is registered, which happens in the perf_event_sysfs_init() call and sets the 'pmu_bus_running' flag. The fix is to get the 'pmu_bus_running' flag state at the point the PMU is taken out of the PMU list and remove the device later only if it's set. Reported-by: CAI Qian <caiqian@redhat.com> Tested-by: CAI Qian <caiqian@redhat.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Kan Liang <kan.liang@intel.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Rob Herring <robh@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20161020111011.GA13361@krava Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 889882b
| File | Mode | Size |
|---|---|---|
| hvc | ||
| ipwireless | ||
| serial | ||
| vt | ||
| Kconfig | -rw-r--r-- | 16.5 KB |
| Makefile | -rw-r--r-- | 1.2 KB |
| amiserial.c | -rw-r--r-- | 45.4 KB |
| bfin_jtag_comm.c | -rw-r--r-- | 9.0 KB |
| cyclades.c | -rw-r--r-- | 109.5 KB |
| ehv_bytechan.c | -rw-r--r-- | 21.5 KB |
| goldfish.c | -rw-r--r-- | 9.0 KB |
| isicom.c | -rw-r--r-- | 41.3 KB |
| metag_da.c | -rw-r--r-- | 16.5 KB |
| mips_ejtag_fdc.c | -rw-r--r-- | 35.3 KB |
| moxa.c | -rw-r--r-- | 52.4 KB |
| moxa.h | -rw-r--r-- | 8.4 KB |
| mxser.c | -rw-r--r-- | 70.4 KB |
| mxser.h | -rw-r--r-- | 4.5 KB |
| n_gsm.c | -rw-r--r-- | 78.5 KB |
| n_hdlc.c | -rw-r--r-- | 26.8 KB |
| n_r3964.c | -rw-r--r-- | 30.8 KB |
| n_tracerouter.c | -rw-r--r-- | 7.1 KB |
| n_tracesink.c | -rw-r--r-- | 7.1 KB |
| n_tracesink.h | -rw-r--r-- | 1.3 KB |
| n_tty.c | -rw-r--r-- | 60.6 KB |
| nozomi.c | -rw-r--r-- | 47.9 KB |
| pty.c | -rw-r--r-- | 22.3 KB |
| rocket.c | -rw-r--r-- | 92.9 KB |
| rocket.h | -rw-r--r-- | 3.8 KB |
| rocket_int.h | -rw-r--r-- | 41.5 KB |
| synclink.c | -rw-r--r-- | 229.1 KB |
| synclink_gt.c | -rw-r--r-- | 131.5 KB |
| synclinkmp.c | -rw-r--r-- | 146.6 KB |
| sysrq.c | -rw-r--r-- | 26.2 KB |
| tty_audit.c | -rw-r--r-- | 5.7 KB |
| tty_buffer.c | -rw-r--r-- | 15.5 KB |
| tty_io.c | -rw-r--r-- | 90.0 KB |
| tty_ioctl.c | -rw-r--r-- | 30.2 KB |
| tty_ldisc.c | -rw-r--r-- | 19.2 KB |
| tty_ldsem.c | -rw-r--r-- | 11.2 KB |
| tty_mutex.c | -rw-r--r-- | 1.1 KB |
| tty_port.c | -rw-r--r-- | 15.2 KB |
Computing file changes ...
