Revision - 097da1a - um: Replace to_phys() and to_virt() with less generic function names - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

13 August 2024, 17:29:01 UTC

Revision 097da1a44d1aef15739214fecf8f4c63792bb665 authored by Guenter Roeck on 14 July 2022, 18:46:00 UTC, committed by Linus Torvalds on 14 July 2022, 18:57:27 UTC

um: Replace to_phys() and to_virt() with less generic function names

The UML function names to_virt() and to_phys() are exposed by UML
headers, and are very generic and may be defined by drivers.  As it
turns out, commit 9409c9b6709e ("pmem: refactor pmem_clear_poison()")
did exactly that.

This results in build errors such as the following when trying to build
um:allmodconfig:

  drivers/nvdimm/pmem.c: In function ‘pmem_dax_zero_page_range’:
  ./arch/um/include/asm/page.h:105:20: error: too few arguments to function ‘to_phys’
    105 | #define __pa(virt) to_phys((void *) (unsigned long) (virt))
        |                    ^~~~~~~

Use less generic function names for the um specific to_phys() and
to_virt() functions to fix the problem and to avoid similar problems in
the future.

Fixes: 9409c9b6709e ("pmem: refactor pmem_clear_poison()")
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 parent c4634a3

Files
Changes

Permalinks

Tip revision: 097da1a44d1aef15739214fecf8f4c63792bb665 authored by Guenter Roeck on 14 July 2022, 18:46:00 UTC
um: Replace to_phys() and to_virt() with less generic function names

Tip revision: 097da1a

File	Mode	Size
Documentation
LICENSES
arch
block
certs
crypto
drivers
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.clang-format	-rw-r--r--	19.8 KB
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	71 bytes
.gitattributes	-rw-r--r--	62 bytes
.gitignore	-rw-r--r--	1.9 KB
.mailmap	-rw-r--r--	23.0 KB
COPYING	-rw-r--r--	496 bytes
CREDITS	-rw-r--r--	98.9 KB
Kbuild	-rw-r--r--	1.3 KB
Kconfig	-rw-r--r--	555 bytes
MAINTAINERS	-rw-r--r--	653.2 KB
Makefile	-rw-r--r--	64.1 KB
README	-rw-r--r--	727 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

um: Replace to_phys() and to_virt() with less generic function names

README