https://github.com/torvalds/linux
Revision 0a93ea2e897bd793cc0aaaddc397eff32ac8d6fe authored by Anton Blanchard on 25 February 2011, 15:33:17 UTC, committed by Linus Torvalds on 25 February 2011, 19:12:37 UTC
With slab poisoning enabled, I see the following oops: Unable to handle kernel paging request for data at address 0x6b6b6b6b6b6b6b73 ... NIP [c0000000006bc61c] .rxrpc_destroy+0x44/0x104 LR [c0000000006bc618] .rxrpc_destroy+0x40/0x104 Call Trace: [c0000000feb2bc00] [c0000000006bc618] .rxrpc_destroy+0x40/0x104 (unreliable) [c0000000feb2bc90] [c000000000349b2c] .key_cleanup+0x1a8/0x20c [c0000000feb2bd40] [c0000000000a2920] .process_one_work+0x2f4/0x4d0 [c0000000feb2be00] [c0000000000a2d50] .worker_thread+0x254/0x468 [c0000000feb2bec0] [c0000000000a868c] .kthread+0xbc/0xc8 [c0000000feb2bf90] [c000000000020e00] .kernel_thread+0x54/0x70 We aren't initialising token->next, but the code in destroy_context relies on the list being NULL terminated. Use kzalloc to zero out all the fields. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent f129ccc
Tip revision: 0a93ea2e897bd793cc0aaaddc397eff32ac8d6fe authored by Anton Blanchard on 25 February 2011, 15:33:17 UTC
RxRPC: Allocate tokens with kzalloc to avoid oops in rxrpc_destroy
RxRPC: Allocate tokens with kzalloc to avoid oops in rxrpc_destroy
Tip revision: 0a93ea2
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.3 KB |
Makefile | -rw-r--r-- | 285 bytes |
awacs.c | -rw-r--r-- | 32.1 KB |
awacs.h | -rw-r--r-- | 8.0 KB |
beep.c | -rw-r--r-- | 7.8 KB |
burgundy.c | -rw-r--r-- | 24.4 KB |
burgundy.h | -rw-r--r-- | 4.0 KB |
daca.c | -rw-r--r-- | 6.9 KB |
keywest.c | -rw-r--r-- | 3.6 KB |
pmac.c | -rw-r--r-- | 37.2 KB |
pmac.h | -rw-r--r-- | 5.1 KB |
powermac.c | -rw-r--r-- | 5.2 KB |
snd_ps3.c | -rw-r--r-- | 28.7 KB |
snd_ps3.h | -rw-r--r-- | 3.5 KB |
snd_ps3_reg.h | -rw-r--r-- | 33.2 KB |
tumbler.c | -rw-r--r-- | 38.6 KB |
tumbler_volume.h | -rw-r--r-- | 6.5 KB |
Computing file changes ...