0b94ea9 | James Graham | 11 April 2018, 14:49:07 UTC | s/host/browser_host/ in wdspec fixture | 11 April 2018, 14:49:07 UTC |
72160f1 | James Graham | 11 April 2018, 13:58:30 UTC | Add support for serializing the config as a dictionary. This is required to pass the config into the wdspec tests. | 11 April 2018, 14:48:24 UTC |
9b7e9ba | Maja Frydrychowicz | 11 April 2018, 09:34:03 UTC | Disable test_pause_dblclick bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1432105 gecko-commit: f424114c6a2ccb65c256f42a835377eeb0f92d5c gecko-integration-branch: central gecko-reviewers: whimboo | 11 April 2018, 13:24:57 UTC |
cf39c87 | Maja Frydrychowicz | 11 April 2018, 09:34:00 UTC | Stop pointer action tests from restarting Firefox bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1432105 gecko-commit: f6b8d9c6cbfa3b4a1b0437cee337ff636b3cfcbe gecko-integration-branch: central gecko-reviewers: whimboo | 11 April 2018, 13:24:57 UTC |
7967c43 | Chris Lilley | 11 April 2018, 11:39:34 UTC | Merge pull request #10415 from w3c/font-variant-descriptor Font variant descriptor | 11 April 2018, 11:39:34 UTC |
9a2ba23 | Darren Shen | 11 April 2018, 10:17:19 UTC | [css-typed-om] Support remaining inline properties. Failures because we don't support some keywords (difference between CSS vs SVG?) Bug: 820299 Change-Id: I1da06c5dfbd847a08b43d0bae42f969b4c40f1d7 Reviewed-on: https://chromium-review.googlesource.com/1002492 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549844} | 11 April 2018, 10:37:10 UTC |
5d9948b | Ms2ger | 13 March 2018, 16:12:19 UTC | Add tests for transferring ImageBitmap objects. | 11 April 2018, 09:31:37 UTC |
98cc5c8 | Chris Lilley | 11 April 2018, 09:30:00 UTC | quick test to see if descriptor supported anywhere | 11 April 2018, 09:30:00 UTC |
17b7215 | Kris Maglione | 11 April 2018, 08:57:58 UTC | Don't reparse stylesheets when assigning empty string to empty element. Per spec, assinging an empty string to textContent or innerHTML should not trigger any mutation observers, and therefore should not trigger a stylesheet reparse, when the element is already empty. Since we need to apply some special handling to innerHTML and textContent assignments to <style> nodes, and therefore re-parse directly in the setter rather than in response to mutation observers, we need to special-case this scenario. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1451940 gecko-commit: 95438fe6d5a87270b1ad713da14f123b17faaea2 gecko-integration-branch: central gecko-reviewers: bz | 11 April 2018, 09:24:42 UTC |
991a413 | Chris Lilley | 11 April 2018, 08:53:36 UTC | update rel help (#10188) | 11 April 2018, 08:53:36 UTC |
b3b6ea0 | jgraham | 11 April 2018, 07:48:44 UTC | Add python handler directory to Python path in wptserve (#10397) Currently making import of files relative to the handler is tricky because, unlike in normal Python, the script directory isn't on the path. This patch adds it to the path when executing the handler. It also ensures that any modifications made to the path or to sys.modules are rolled back after the handler has run. | 11 April 2018, 07:48:44 UTC |
d44cd21 | Darren Shen | 11 April 2018, 06:22:29 UTC | [css-typed-om] Support remaining svg properties. Known failures: - flood & stop opacity: we should be clamping between 0 and 1 like 'opacity'. - paint-order: we seem to always compute to a list, but we should be computing to as specified (Firefox has correct behaviour). Bug: 820299 Change-Id: I0bcf29e07cb63516072bc3d0c307d0eadf2de6a3 Reviewed-on: https://chromium-review.googlesource.com/1002433 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549791} | 11 April 2018, 06:39:21 UTC |
e6f6bbf | Darren Shen | 11 April 2018, 06:13:15 UTC | [css-typed-om] Support remaining mask properties. Known failures: - clip-path: doesn't support <geometry-box> Bug: 820299 Change-Id: I28e00e59cfa7f7c3d2bd7db307fb6d0f528d395d Reviewed-on: https://chromium-review.googlesource.com/1002342 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549788} | 11 April 2018, 06:31:29 UTC |
3b7b8db | Darren Shen | 11 April 2018, 06:04:13 UTC | [css-typed-om] Support remaining text properties. Known failures: - letter-spacing: a <length> of 0 resolves to "normal", but should compute to "0". - line-break: "anywhere" not supported. - overflow-wrap & word-wrap: "break-spaces" not supported - word-spacing: "normal" should compute to "normal" and should be able to set word-spacing to a <percentage>. Bug: 820299 Change-Id: If5bac479521de6f1658a38a295df01de98f433f2 Reviewed-on: https://chromium-review.googlesource.com/1002340 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549783} | 11 April 2018, 06:22:24 UTC |
387fba3 | Darren Shen | 11 April 2018, 05:55:17 UTC | [css-typed-om] Add support for scroll properties. Test failures: - scroll-snap-align should always compute to a pair (but we currently compute to single keyword if specified). - scroll-snap-type should compute to as specified (but we currently compute to pair). Bug: 820299 Change-Id: Id38cee967daef8ac5c0658b958d6e74445035a83 Reviewed-on: https://chromium-review.googlesource.com/999078 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549778} | 11 April 2018, 06:04:09 UTC |
2e8fa7b | Ian Clelland | 11 April 2018, 02:30:42 UTC | Make DOMTokenList.supports() case-insensitive According to the DOM spec (https://dom.spec.whatwg.org/#dom-domtokenlist-supports) the supports() method should compare the ASCII-lowercase transform of its input to the list of tokens supported by the DOMTokenList. Bug: 831166 Change-Id: I40903a307ffb949bbbbc99e02b56565cb81d00ed Reviewed-on: https://chromium-review.googlesource.com/1005412 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#549733} | 11 April 2018, 02:40:01 UTC |
1bb2bd0 | Joe Downing | 11 April 2018, 01:49:46 UTC | [KeyboardLock] Updating API to reject the first promise if lock is called twice Per the W3C spec, when navigator.keyboard.lock() is called a second time (or more), any previous, pending promises should be rejected. The old behavior of the API was to reject the newest promise which is not correct. As part of this cleanup, I am also using DomExceptions instead of raw strings for the rejection. This allows us to clean up the test code (which fails if a raw string is returned in the reject call). BUG=680809 Change-Id: Ic4f2563a6ccc22a434f8e6079f1995d9e584f9aa Reviewed-on: https://chromium-review.googlesource.com/1003472 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#549719} | 11 April 2018, 02:01:27 UTC |
6934f15 | Wanming Lin | 11 April 2018, 01:41:15 UTC | Automate more focus tests with testdriver (#10396) | 11 April 2018, 01:41:15 UTC |
827efec | Nicolas Pena | 10 April 2018, 22:25:46 UTC | WPT-fy Intel/user-timing/ tests This change cleans up the remaining tests in http/tests/w3c/ directory in preparation to delete it. It moves some tests to external/wpt and removes other tests, which are duplicates: * test_user_timing_entry_type.html is duplicated by entry_type.any.js * test_user_timing_mark_exception.html duplicated by mark_exceptions.html * test_user_timing_method_exist.html is duplicated by user_timing_exists.any.js Bug: 498037 Change-Id: I1ba43eba81ed0a5d9e1e1a79aef11b9904556f69 Reviewed-on: https://chromium-review.googlesource.com/1002736 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#549659} | 10 April 2018, 22:38:25 UTC |
51615f8 | Emilio Cobos Álvarez | 10 April 2018, 20:19:22 UTC | Test descendant invalidation for :host(..). bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1452640 gecko-commit: 00ac14e011212f55d75afd6043ac8e41636dec5f gecko-integration-branch: central gecko-reviewers: xidorn | 10 April 2018, 21:22:53 UTC |
e504871 | Jonathon Kereliuk | 10 April 2018, 18:20:46 UTC | added special keys note (#10403) | 10 April 2018, 18:20:46 UTC |
1e801bf | Makoto Shimazu | 10 April 2018, 01:23:59 UTC | Revert "Enable ConsumeGestureOnNavigation by default" This reverts commit 2ca250d409adfa73a666daabd3ba19b94d6443a7. Reason for revert: A leak bot complains navigation-consumes-user-activation.tentative.sub.html is leaking. Sample build: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/17509 Original change's description: > Enable ConsumeGestureOnNavigation by default > > See blink-dev thread: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kPli8ZCUeok > > A browser test is moved to be a tentative WPT due to this change. > > Bug: 772515 > Change-Id: Icf99c8c303c5055dcbcdace6ae94e3fcd1a01921 > Reviewed-on: https://chromium-review.googlesource.com/980599 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549293} TBR=nasko@chromium.org,mustaq@chromium.org,csharrison@chromium.org,kereliuk@chromium.org Change-Id: I0c998798d1367be61c633db76429c18ac554e4ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772515 Reviewed-on: https://chromium-review.googlesource.com/1003437 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549363} | 10 April 2018, 14:00:49 UTC |
1a57aef | Charlie Harrison | 09 April 2018, 22:16:22 UTC | Enable ConsumeGestureOnNavigation by default See blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kPli8ZCUeok A browser test is moved to be a tentative WPT due to this change. Bug: 772515 Change-Id: Icf99c8c303c5055dcbcdace6ae94e3fcd1a01921 Reviewed-on: https://chromium-review.googlesource.com/980599 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#549293} | 10 April 2018, 14:00:49 UTC |
d577e28 | Darren Shen | 10 April 2018, 13:25:59 UTC | [css-typed-om] Add support for fill & stroke properties. Some failures: - fill & stroke shorthands do not seem to follow spec (it should be list valued) - fill-opacity & stroke-opacity do not clamp their values (ComputedStyle should clamp values, like opacity). - fill-color is not implemented. Bug: 820299 Change-Id: I0879e353cd22291aa8a34f2a10895809b43d8aa5 Reviewed-on: https://chromium-review.googlesource.com/998454 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549499} | 10 April 2018, 13:52:24 UTC |
e62fc73 | Darren Shen | 10 April 2018, 10:23:25 UTC | [css-typed-om] Add support for font properties. Had to modify the test harness to allow numbers in keywords. This coincidentally fixed an error in one of the tests (transform-style). Bug: 820299 Change-Id: Ia7e2854f38a5b960e6537d2c4ba309cb71c1e963 Reviewed-on: https://chromium-review.googlesource.com/999225 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549473} | 10 April 2018, 13:36:34 UTC |
cb4e207 | Darren Shen | 10 April 2018, 08:46:40 UTC | [css-typed-om] Fix unsupported values in non-list-valued properties. Currently, when we reify a value, we try to first reify it as a single value. If that fails, we try reifying it as a list value. This code was written with the incorrect assumption that only list-valued properties are stored as CSSValueLists. This is not true, as many single valued properties (such as grid-auto-flow) are stored as CSSValueLists. This patch adds an additional check so that only properties that are explicitly marked as list-valued are reified as list values. Bug: 829881 Change-Id: I965e38355b9859a43fcb1b940f19237f9f07fdf6 Reviewed-on: https://chromium-review.googlesource.com/1002214 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549455} | 10 April 2018, 13:35:49 UTC |
d9a9bcf | Daniel Vogelheim | 10 April 2018, 13:07:39 UTC | Implement deprecation of content type sniffing for workers. Allow control of the deprecation via runtime enabled features, with a first step for logging a warning to the console, and the second step to block it outright. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/35t5cJQ3J_Q/FH45dl0vAwAJ Change-Id: I1be1001cbbef152458119b1516750bb4f1d1e4de Reviewed-on: https://chromium-review.googlesource.com/975611 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#549495} | 10 April 2018, 13:16:58 UTC |
069680c | Morten Stenshorne | 10 April 2018, 10:57:45 UTC | Make sure table flex/grid items recalculate min/max widths. We used to rely on this taking place lazily via MinPreferredLogicalWidth(), but that method won't necessarily be called if the table is a flex/grid item. Bug: 810327 Change-Id: Ic817bd109544d4b9e961552d0a3a38f127e6e548 Reviewed-on: https://chromium-review.googlesource.com/1000781 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549479} | 10 April 2018, 11:06:35 UTC |
429e62e | Geoffrey Sneddon | 10 April 2018, 08:02:47 UTC | Fix #10388: Make resources/test use the upstream config (#10393) | 10 April 2018, 08:02:47 UTC |
5a93530 | Chris Nardi | 10 April 2018, 07:52:00 UTC | Test box-shadow serialization (#9519) Following https://github.com/w3c/csswg-drafts/issues/2305, the canonical serialization for box-shadow was changed from inset? && <length>{2,4} && <color>? to <color>? && <length>{2,4} && inset?. Convert an existing box-shadow text into a testharness.js test in order to test serialization as well. | 10 April 2018, 07:52:00 UTC |
149eff7 | Emilio Cobos Álvarez | 09 April 2018, 21:02:15 UTC | Tests for non-functional :host selector. Both Blink and WebKit pass the added tests. But of course all this stuff was untested initially, and my initial naive implementation would fail them. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=992245 gecko-commit: 5a24374d10f7b33f2582519664a21612c18f8cfb gecko-integration-branch: central gecko-reviewers: xidorn | 09 April 2018, 22:40:06 UTC |
46abbd5 | Tarun Bansal | 09 April 2018, 19:19:04 UTC | Add external WPT test for cross-origin requests The browser should not attach client hints to the requests fetched from cross origins. Bug: 817049 Change-Id: Ia7cedfbb6edaaf3616d6e2783965cc52f93c0cd9 Reviewed-on: https://chromium-review.googlesource.com/1000841 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#549238} | 09 April 2018, 19:28:09 UTC |
d258fe9 | Geoffrey Sneddon | 09 April 2018, 17:31:56 UTC | In HTML documents, always make sure we a body (#10376) | 09 April 2018, 17:31:56 UTC |
3543c82 | Anne van Kesteren | 09 April 2018, 14:18:58 UTC | Test self.event in workers To compliment #10329. Needed for https://github.com/whatwg/dom/pull/407. | 09 April 2018, 14:51:36 UTC |
bfef1f2 | Geoffrey Sneddon | 09 April 2018, 14:38:52 UTC | Move the config into its own class (#10231) | 09 April 2018, 14:38:52 UTC |
ad4ef4f | Luke Bjerring | 09 April 2018, 14:14:06 UTC | Check for circular deps (#10334) | 09 April 2018, 14:14:06 UTC |
509d7ab | Anne van Kesteren | 09 April 2018, 13:10:03 UTC | Remove generate_tests from NodeIterator.html (#10380) | 09 April 2018, 13:10:03 UTC |
cc9648d | Dominic Farolino | 09 April 2018, 12:05:58 UTC | Add tests for mathematical functions in <img sizes=""> Tests for https://github.com/whatwg/html/pull/3084. | 09 April 2018, 12:05:58 UTC |
24f49ff | Chris Rebert | 28 November 2016, 01:36:43 UTC | Add tests for Event.returnValue See https://github.com/whatwg/dom/issues/625 for details. | 09 April 2018, 10:46:34 UTC |
13597c4 | Mike Taylor | 30 March 2018, 21:08:48 UTC | Add tests for Event.srcElement See https://github.com/whatwg/dom/issues/625 for details. | 09 April 2018, 10:46:34 UTC |
95992cd | Anthony Ramine | 07 April 2018, 11:47:48 UTC | Avoid async/await in /webstorage/idlharness.html Am sorry, Servo is dumb, we are actively trying to fix that on our side. | 09 April 2018, 09:30:00 UTC |
2b8e0e7 | Anthony Ramine | 07 April 2018, 11:42:03 UTC | Properly define EventInit in /webvr/idlharness.https.html | 09 April 2018, 09:29:35 UTC |
6fe36d7 | Matt Falkenhagen | 09 April 2018, 08:40:54 UTC | service worker: Add tests for inteception of workers after redirects. This tests behavior discussed here: https://github.com/w3c/ServiceWorker/issues/1289 Namely it tests when a request for a worker goes through a redirect chain: 1) On redirect from A -> B, whether the service worker at B sees the request. 2) After the final redirect, which service worker controls the resulting client. The tests are written as specified today. Therefore, Firefox passes this test (verified in Nightly) and Chrome does not. (Actually a small change is required to the test to make Firefox pass it, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1452528) Currently it only tests shared worker but dedicated worker can be added in a follow-up patch. Bug: 829720 Change-Id: Id3b1ea8b952760be0ef9917f2c6a3afe60ca1fb5 Reviewed-on: https://chromium-review.googlesource.com/999241 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#549125} | 09 April 2018, 09:19:45 UTC |
fc7c0b7 | Emilio Cobos Álvarez | 09 April 2018, 07:01:25 UTC | Make LazyFC assertions actually hold. The code was trying to assert that we had frames constructed for all the nodes in the parent chain, but we don't bail out in the !GetContentInsertionFrameFor(aContainer) in the case that it's a children element, because they actually have no insertion frame, though their children do. Move the LazyFC check after the insertion point check. That makes the previous check work on the insertion point of the child, which makes it sound. This also fixes bug 1410020, and with it a Shadow DOM test-case that was failing because we had two sibling assigned to two different <slot>s, and the second one wasn't getting properly flagged, and thus the second sibling never got a frame. The other two test failures in this test are an event dispatch failure, where the position of the target is not what the test expects (we don't account for margin and padding). Filed that as bug 1450027. Also, added a test for which we have wrong layout without these patches, and that crashes with "Called Servo_Element_IsDisplayNone" with the first patch of this bug applied but not this one, due to the bogus check mentioned above. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1303605 gecko-commit: 12a824f8d55a8fb0396fb2132974f8223c6a9606 gecko-integration-branch: central gecko-reviewers: bz | 09 April 2018, 07:52:06 UTC |
a835486 | Chris Nardi | 04 March 2018, 17:39:56 UTC | Correct serialization of box-shadow and text-shadow Following https://github.com/w3c/csswg-drafts/issues/2305, the canonical serialization for box-shadow was changed to the color then lengths. https://drafts.csswg.org/css-text-decor-3/#text-shadow-property also defines the canonical serialization for text-shadow as the color and then lengths. This caused the test to fail in Firefox, Chrome, and Safari. Update the test to match the spec in both instances. | 09 April 2018, 07:47:52 UTC |
8f9d8e9 | L. David Baron | 09 April 2018, 07:36:55 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/b4bc6b2401738b78fd47127a4c716bb9178e1a09 . (#10358) | 09 April 2018, 07:36:55 UTC |
85191e1 | Brad Werth | 09 April 2018, 05:37:36 UTC | Part 1: Add a web-platform test that shows shape-outside: border-box float areas are correctly clipped to margin rects. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1328236 gecko-commit: b5bc270f37953f60d40f821b0593ff2e6200e343 gecko-integration-branch: central gecko-reviewers: dholbert | 09 April 2018, 06:46:05 UTC |
8c503e7 | Bobby Holley | 09 April 2018, 05:22:47 UTC | Add test for case insensitivity for content: attr() identifiers in html documents. dbaron asked for this in bug 507762, but it never happened. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1451421 gecko-commit: 2189673fb8ea87ac07cd3cffe5a86cbdf497865d gecko-integration-branch: central gecko-reviewers: xidorn | 09 April 2018, 05:38:06 UTC |
99e1ae2 | Emilio Cobos Álvarez | 04 April 2018, 18:31:57 UTC | Respect ::selection background styles for image overlays. I don't have a strong preference about blending with white vs. just doing alpha 0.5, so I kept doing what we were doing, since Blink and WebKit also apply the blending to the text background, and I'm not sure that's particularly desirable. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1449010 gecko-commit: 6d2897cca552917317e11a34e2bb410431ef5619 gecko-integration-branch: central gecko-reviewers: mattwoodrow | 09 April 2018, 05:13:01 UTC |
13d36e4 | Andrea Marchesini | 04 April 2018, 17:49:15 UTC | Update the StructuredCloneAlgorithm to follow the latest version of the spec, bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1441141 gecko-commit: 9890a67387378b2417e135a57bd0a6727a578cb6 gecko-integration-branch: central gecko-reviewers: smaug, sfink | 09 April 2018, 03:59:56 UTC |
8a4cdaf | Darren Shen | 09 April 2018, 02:10:49 UTC | [css-typed-om] Implement support for text-* properties. There's a failing test due to Blink computing keyword values for text-size-adjust to percentages, even though the spec says the computed value is as specified. Bug: 820299 Change-Id: I53c4177f1ce2205a4f2b6af00b1c61da4f5e774f Reviewed-on: https://chromium-review.googlesource.com/994594 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#549095} | 09 April 2018, 02:18:42 UTC |
318f287 | Simon Sapin | 08 April 2018, 10:00:41 UTC | Remove SimonSapin from OWNERS (#10361) | 08 April 2018, 10:00:41 UTC |
f161804 | kaixinjxq | 08 April 2018, 05:04:47 UTC | Adapt web-nfc IDL tests to latest spec (#10360) | 08 April 2018, 05:04:47 UTC |
d0d6224 | Chris Nardi | 07 April 2018, 01:36:26 UTC | Update expected cssText for custom property serialization See https://github.com/w3c/csswg-drafts/issues/2509#issuecomment-379152590 for the change to target9. Also remove the extra whitespace in target8 and target1 which causes these tests to fail in Chrome and Firefox. Also remove testcase.propertyName from each test's name as this doesn't exist and just outputs undefined. | 07 April 2018, 02:05:46 UTC |
6e68c44 | Luke Bjerring | 06 April 2018, 20:02:13 UTC | Improve idlharness error message for exposure test (#10336) When `obj` is not created successfully, there's an error like > Cannot use 'in' operator to search for [member.name] in undefined NB: I'm not a fan of having each sub-test re-test the same thing, but this is at least _consistent_ with the other code.. | 06 April 2018, 20:02:13 UTC |
a4c17db | Joshua Bell | 06 April 2018, 19:47:51 UTC | Cookie Store: Tentatively deflake special names test The "expires" cases are flaky on all platforms on the bots, although I can't reproduce locally. The test case sets a cookie that expires "now" then expects it can't read it. It may be flaky due to "now" being slightly different between processes, threads, and libraries, allowing the read to succeed. Set the expiry date to be an hour before "now", which should be sufficient. Bug: 829761 Change-Id: Icda1891310dd0a56769877f32405226390e729de Reviewed-on: https://chromium-review.googlesource.com/999743 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548903} | 06 April 2018, 19:57:29 UTC |
68b0798 | Raymond Toy | 06 April 2018, 17:48:00 UTC | Move AudioNode tests to WPT Move the AudioNode tests to WPT. Can't move tail-processing.html because it's specific to Chrome's tail processing. Firefox passes all tests except: * audionode.html (because new AudioContext(1,44100,44100) succeeds but shouldn't * tests that use oac.suspend * audionode-connect-method-chaining.html with an IndexSizeError connecting Bug: 745778 Change-Id: I0e21e2117a75246367ea2642759ed917ee3e028f Reviewed-on: https://chromium-review.googlesource.com/994136 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548843} | 06 April 2018, 17:58:00 UTC |
ea93487 | pyup.io bot | 06 April 2018, 17:26:06 UTC | Update mozrunner from 6.14 to 6.15 (#10346) | 06 April 2018, 17:26:06 UTC |
8b9501b | Joshua Bell | 06 April 2018, 17:08:18 UTC | Cookie Store: rework tests for 'expires' option Simplify/rework the tests for the 'expires' options. Don't run the tests with the special secure-only prefixes, as that's orthogonal to the behvior. In Chromium, this also reveals that support for HTTP date strings as 'expires' values, as described in the explainer[1] is not yet supported. [1] https://github.com/WICG/cookie-store/blob/gh-pages/explainer.md Bug: 729800 Change-Id: I015fd643f18b59c8294f9dc62d576682132795fd Reviewed-on: https://chromium-review.googlesource.com/994284 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548818} | 06 April 2018, 17:18:05 UTC |
8314b7b | Adam Rice | 06 April 2018, 15:58:33 UTC | Update ReadableStream to latest standard version Update Blink's implementation of ReadableStream to https://streams.spec.whatwg.org/commit-snapshots/37ace3d5f16cbea7aec4a0c80532c95059994d51/ This also updates TransformStream to use CreateReadableStream() instead of calling the ReadableStream constructor. Several common operations have become unused and have been removed. The EXTERNALLY_CONTROLLED flag has been renamed to the slightly more specific name "BLINK_LOCK_NOTIFICATIONS". All external/wpt/streams/readable-streams tests now pass, and failing expectations have been removed. Most changes were already covered by the web-platform-tests. A new readable-streams/patched-global.js test verifies that ReadableStreamTee() does not use the global ReadableStream constructor or otherwise touch the global object. BUG=710728 Change-Id: I2b799045f47376adef305f5f88ad106161425b46 Reviewed-on: https://chromium-review.googlesource.com/992077 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#548784} | 06 April 2018, 16:29:29 UTC |
a0091fb | Nicolas Pena | 06 April 2018, 14:54:34 UTC | Fix the |name| of PerformanceNavigationTiming Previously, the |name| of a PerformanceNavigationTiming entry was the initial URL (the request URL). After this CL, it is the response URL, so for example a url of the form 'redirect?location=newLoc' will have 'newLoc' as the |name|. Bug: 797465 Change-Id: Icab53ad8027d066422562c82bcf0354c264fea40 Reviewed-on: https://chromium-review.googlesource.com/996579 Reviewed-by: Yoav Weiss <yoav@yoav.ws> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#548773} | 06 April 2018, 15:15:47 UTC |
6ba01ea | Mustaq Ahmed | 06 April 2018, 14:14:32 UTC | Make BlueTooth/USB requestDevice non-consuming. The specs for both WebBlueTooth & WebUSB only require a user activation during a requestDevice call. So consuming the activation (vs just checking) is not a strong requirement. There was a concern that "not consuming" could possibly mean multiple choosers for a single user activation but our browser code already handles the situation gracefully. Multiple requests to browser is possible from different tabs anyway, even with (isolated) consumptions in individual tabs. Therefore it makes sense to remove the consumption behavior here, which is not spec-ed anyway. This would fit our goal of a simple user activation model ("UserActivationV2" project) which should be simple enough for cross-browser implementation and for a complete spec. Bug: 786407 Change-Id: I3c9dbf43df34d4cb4a2a33214a6c44847fa7435b Reviewed-on: https://chromium-review.googlesource.com/775866 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#548768} | 06 April 2018, 14:33:48 UTC |
0cddb68 | Luke Bjerring | 06 April 2018, 13:14:40 UTC | Add FileAPI idl file (#9753) | 06 April 2018, 13:14:40 UTC |
6dd3135 | Luke Bjerring | 05 April 2018, 20:06:09 UTC | Improve error message for exposure_set test `memberName` is undefined; error message is (was) `ReferenceError: memberName is not defined`. Clearly supposed to be a check for duplication - `array.length < 0` was a really weird thing to see, though. Spec says it's always non-negative, so deleted that. Error I see now is "Multiple 'Exposed' extended attributes on Navigator" | 06 April 2018, 13:04:02 UTC |
11740d8 | Jinho Bang | 06 April 2018, 12:23:32 UTC | WebNFC: Use [SecureContext] instead of manual check Until now, we had to use IsSecureContext() to check whether an execution context is a secure context manually. But we can use [SecureContext] instead of the manual check now. Related spec change: https://github.com/w3c/web-nfc/pull/143 https://github.com/w3c/web-nfc/pull/144 Bug: none Change-Id: I1396470cc57aeba137ddba65d1f29eb58cf9cf9b Reviewed-on: https://chromium-review.googlesource.com/989537 Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#548744} | 06 April 2018, 12:32:35 UTC |
0fb0745 | Philip Jägenstedt | 06 April 2018, 11:10:29 UTC | Fix all lint errors in svg/import/* First dos2unix was used and for text-fonts-202-t-manual.svg this also removes a UTF-8 BOM. Then all files were passed through git stripspace, which also removed some double blank lines which don't look to have been meaningful. Finally all tabs were replaced by two spaces, as that's the tab width that seems to have been used when editing these files. Some odd indentation remains and would have to be fixed manually. | 06 April 2018, 12:08:26 UTC |
b80da5d | Anthony Ramine | 06 April 2018, 10:50:43 UTC | Merge pull request #10344 from nox/var-gt-const Change a const in var in idlharness.js | 06 April 2018, 10:50:43 UTC |
89daad3 | Anthony Ramine | 06 April 2018, 10:22:01 UTC | Change a const in var in idlharness.js See https://github.com/w3c/web-platform-tests/issues/10343#issuecomment-379211826 I know we can't stop progress in WPT just because Servo is stuck in the past, but let's not make all IDL-related tests fail in it for something that can be avoided so easily. | 06 April 2018, 10:22:01 UTC |
603e277 | Henrik Boström | 06 April 2018, 09:24:00 UTC | Fix RTCPeerConnection-track-stats.https.html flake. The assert_object_equals would fail due to timestamps being different in rare runs where the getStats() cache was invalidated between the two calls. external/wpt/webrtc should make no assumptions about any cache. Tests are updated only to compare stats IDs, not individual metrics. Bug: 829401 Change-Id: I6fcc781a1827af69f47a5c4416dd5e6bae0c98b3 Reviewed-on: https://chromium-review.googlesource.com/999477 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#548721} | 06 April 2018, 09:42:49 UTC |
487c4a8 | Darren Shen | 06 April 2018, 06:51:15 UTC | [css-typed-om] Add support for border properties. border-radius-* tests are failing because the computed value should always be a pair of values, but Blink currently returns a CSSValuePair with kDropIdenticalValue, so we sometimes compute to a single value. Fixing this requires either changing computed border-radius-* to use kKeepIdenticalValue, or overriding the computed value just for Typed OM [1] [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp?q=ComputedStylePropertyMap.cpp&dr&l=229 Bug: 820299 Change-Id: I4c67a7986a8e77d37e7936eabfa0b68b32de9df8 Reviewed-on: https://chromium-review.googlesource.com/994433 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#548697} | 06 April 2018, 09:32:19 UTC |
f9817db | Philip Jägenstedt | 06 April 2018, 09:26:27 UTC | Add intersection-observer/OWNERS (#9199) | 06 April 2018, 09:26:27 UTC |
ca70fdd | Darren Shen | 06 April 2018, 07:51:02 UTC | [css-typed-om] Add support for background properties. We cannot support background-repeat and background-position yet because they are both implemented as shorthands in Blink, but are not shorthands in the spec. We'd need to refactor the existing code to allow shorthands to reify as proper Typed OM objects. There are also some tricky bits to support styleMap.set with shorthands given a proper Typed OM object. Bug: 820299 Change-Id: I064ce37a48bee3d73965b66b323e20abf5a9099f Reviewed-on: https://chromium-review.googlesource.com/994593 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#548705} | 06 April 2018, 08:01:06 UTC |
d6a82fd | Luke Bjerring | 06 April 2018, 06:34:16 UTC | Update the cssom IDL file (#9776) * Update cssom IDL * Manually remove template IDL | 06 April 2018, 06:34:16 UTC |
13effc3 | Luke Bjerring | 06 April 2018, 00:57:35 UTC | Update the compat IDL file (#9765) * Add compat idl file | 06 April 2018, 00:57:35 UTC |
67c2a87 | Luke Bjerring | 06 April 2018, 00:54:18 UTC | Update the budget-api IDL file (#9763) * Add budget-api idl file | 06 April 2018, 00:54:18 UTC |
99b9072 | Luke Bjerring | 06 April 2018, 00:52:44 UTC | Update the BackgroundSync IDL file (#9751) * Add BackgroundSync idl file | 06 April 2018, 00:52:44 UTC |
22be1ef | Luke Bjerring | 06 April 2018, 00:51:28 UTC | Add MISSING-LINK docs (#10332) | 06 April 2018, 00:51:28 UTC |
0b6eb5e | Ovidio Henriquez | 05 April 2018, 20:41:56 UTC | bluetooth: web: test: Update char disconnect tests This change updates the generated characteristics tests for calling disconnect/device disconnecting before an operation on a characteristic. BUG=509038 Change-Id: I16b7ffbfd6df473ee0c4c0bfb34982473c41482f Reviewed-on: https://chromium-review.googlesource.com/986890 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#548542} | 05 April 2018, 23:14:35 UTC |
dac87dc | Joshua Bell | 05 April 2018, 21:55:25 UTC | Cookie Store: disallow '=' in cookies with empty names Per the explainer[1] and tests: "Cookies with an empty name cannot be set using values containing = as this would result in ambiguous serializations in the majority of current browsers." Also, fix a test glitch now that this restriction is implemented. [1] https://github.com/WICG/cookie-store/blob/gh-pages/explainer.md Bug: 729800 Change-Id: I9ed02885c217cbdb4c86d8fd236d49c6c56b6e96 Reviewed-on: https://chromium-review.googlesource.com/994145 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548563} | 05 April 2018, 22:21:53 UTC |
e54fa9b | Joshua Bell | 05 April 2018, 21:55:18 UTC | Cookie Store: Consolidate WPT coverage for special prefixed cookies Merge two sets of tests that cover __Secure- and __Host- prefixed cookies in the API. Tests cover secure and non-secure contexts, getting, setting, deleting, and setting already-expired cookies. Bug: 729800 Change-Id: Ie7e84eeda03ba8192f5062cbf5240ff8ab13816a Reviewed-on: https://chromium-review.googlesource.com/994174 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548562} | 05 April 2018, 22:09:49 UTC |
15428c1 | Ovidio Henriquez | 05 April 2018, 20:42:03 UTC | bluetooth: SetNextUnsubscribeFromNotifications This change implements the SetNextUnsubscribeFromNotifications function for fake characteristics. BUG=569709 Change-Id: I99c59a4caffd524e727921fcb54f48cc868d545f Reviewed-on: https://chromium-review.googlesource.com/988223 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Oliver Chang <ochang@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#548544} | 05 April 2018, 21:05:54 UTC |
d00f7ba | Robert Ma | 05 April 2018, 18:09:27 UTC | Bind StashServer to server_host instead of browser_host | 05 April 2018, 20:06:02 UTC |
5ee2ebc | Robert Ma | 05 April 2018, 19:32:29 UTC | Fix the unit test for affected tests (#10335) The root cause is that we use the up-to-date manifest and rely on the files on the head of master, so the test will fail whenever the file we are asserting is renamed (which unfortunately happened at bf17459a71ff4d1ea280bae54dd046ecf86e0628). This PR doesn't fix the root cause, but instead switches to a relatively stable test file (`infrastructure/reftest-wait.html`). Hopefully this will hold in the forseeable future. | 05 April 2018, 19:32:29 UTC |
1fd16de | Jinho Bang | 05 April 2018, 17:36:25 UTC | WebBluetooth: Use [SecureContext] instead of manual check Until now, we had to use IsSecureContext() to check whether an execution context is a secure context manually. But we can use [SecureContext] instead of the manual check now. Bug: none Change-Id: Ibfcd4a9a2eed3e7ac67819b9bf4204f4c73412d8 Reviewed-on: https://chromium-review.googlesource.com/990014 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#548464} | 05 April 2018, 17:46:23 UTC |
4d1c192 | Luke Bjerring | 05 April 2018, 17:05:00 UTC | Check inherited interfaces exist (#10285) Also fix affected tests. | 05 April 2018, 17:05:00 UTC |
841f3f5 | Jonathon Kereliuk | 05 April 2018, 16:31:39 UTC | Merge pull request #10315 from kereliuk/automate-focus-02 Added testdriver automation for html/editing/focus/focus-02.html | 05 April 2018, 16:31:39 UTC |
08906cb | Joanmarie Diggs | 04 April 2018, 20:47:54 UTC | AccName: Fix several expected results | 05 April 2018, 14:12:24 UTC |
f6c1d7b | Stephen McGruer | 05 April 2018, 13:37:39 UTC | Web Animations: remove timing objects The upstream spec has removed the 'timing' objects and replaced them with updateTiming/getTiming methods on AnimationEffect. It also removed and renamed a few timing idl interfaces; see the bug for full details. This CL also refactors the timing input parsing, aiming to make the public TimingInput API match what the spec requires and not expose other unnecessary methods. See https://github.com/w3c/csswg-drafts/pull/2432 for the spec change. Bug: 823384, 823386 Change-Id: I40c82e46be29c16e2e4b53d69bbadc95c8bff324 Reviewed-on: https://chromium-review.googlesource.com/975923 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#548403} | 05 April 2018, 13:47:07 UTC |
bf17459 | Mike West | 05 April 2018, 12:29:12 UTC | Add a runtime flag to restrict AppCache to secure contexts. This patch adjusts the `SecureContext` IDL attribute to take an argument, as we need to restrict the relevant bits and pieces to secure contexts iff a specific flag is set. We'll unfortunately need to keep that in place until and unless we decide that we can reasonably remove an enterprise opt-out. Intent to Deprecate/Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ANnafFBhReY/1Xdr53KxBAAJ Spec bug: https://github.com/whatwg/html/issues/3440 Bug: 588931 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5bedd2ca6f420a88ddbcff65e4223fad224ac0a7 Reviewed-on: https://chromium-review.googlesource.com/982625 Reviewed-by: Yoav Weiss <yoav@yoav.ws> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#548391} | 05 April 2018, 12:48:53 UTC |
d725f2a | Mike Bremford | 05 April 2018, 11:14:56 UTC | Tests were referencing the wrong reference tests (#10328) | 05 April 2018, 11:14:56 UTC |
384edc9 | fergald | 05 April 2018, 10:33:42 UTC | Handle the case when MANIFEST.json is empty (#10323) I don't know how I got into this situation (probably hit ctrl-C at the wrong time) but I did and it was unclear how to get out. It presents as a ValueError with no useful info. Update the code to handle ValueError to log a warning and cause a full regen of the manifest. Also reported in https://crbug.com/822041 | 05 April 2018, 10:33:42 UTC |
f42caef | Geoffrey Sneddon | 05 April 2018, 10:32:20 UTC | Add tests for wptserve.pipes.ReplacementTokenizer (#10322) This is as much in lieu of documentation of the format as anything | 05 April 2018, 10:32:20 UTC |
37e2fc3 | Manuel Rego Casasnovas | 05 April 2018, 09:14:37 UTC | Merge pull request #10327 from mrego/column-gap-normal [css-multicol] column-gap normal is 1em per spec now | 05 April 2018, 09:14:37 UTC |
8fa12a5 | Adam Rice | 05 April 2018, 07:58:47 UTC | Make URLSearchParamsIterationSource not snapshot Previously URLSearchParamsIterationSource iterated over a copy of URLSearchParams, but it is specified in the standard as iterating over the live list. Modify it to reference the original URLSearchParams object instead of making a copy. Also add web-platform tests for delete during foreach, and a chromium- specific test for GC of URLSearchParams during iteration. Remove failing expectations. BUG=677322 Change-Id: I8c53fd8dd9863fe1146c5b7849d4f08245b37bc1 Reviewed-on: https://chromium-review.googlesource.com/987839 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#548363} | 05 April 2018, 08:10:05 UTC |
5c9b2cf | Rakina Zata Amni | 05 April 2018, 07:26:13 UTC | Remove stylesheet of link element when rel != stylesheet Stylesheets from link elements that previously have rel = "stylesheet" but then changed to something else should be removed/not considered anymore until the rel attribute is changed back to "stylesheet" again. Currently this works correctly for link elements in the document tree, but fails in link elements within a shadow tree because link elements in shadow tree with rel attribute != "stylesheet" are skipped from processing. Because of that, the stylesheet in the link element was never cleared and no style recalc happened. JSBin from bug: http://jsbin.com/bojunajaju/edit?html,console,output Bug: 817355 Change-Id: I57c71c79c0cc471d36eb988b8a81eef82c33548a Reviewed-on: https://chromium-review.googlesource.com/995116 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#548357} | 05 April 2018, 07:38:36 UTC |
c6247d2 | Behind The Math | 05 April 2018, 03:02:14 UTC | Add tests to check that the User-Agent header is set for XHR requests | 05 April 2018, 07:26:30 UTC |
fee9876 | Manuel Rego Casasnovas | 05 April 2018, 07:04:59 UTC | [css-multicol] column-gap normal is 1em per spec now The CSSWG resolved to make it explicit in the spec in issue w3c/csswg-drafts#2145. The reason is that there's interop between all UAs regarding this. These 2 tests were marked as optional "may" but they're not optional anymore. | 05 April 2018, 07:04:59 UTC |
297db81 | Morten Stenshorne | 05 April 2018, 06:52:57 UTC | Out-of-flow descendants may still be part of the flow thread. When changing a layout object from in-flow to out-of-flow positioned, we used to just remove it from the flow thread, risking that there'd no longer be a column set to associate it with. However, an out-of-flow positioned descendant may be contained by something that's inside the flow thread, e.g. if the containing block of an absolutely positioned object is a relatively positioned object, and that relatively positioned object is contained by the flow thread. Since it's hard to detect what the new containing block of an object is going to be before it has actually gone out of flow, we'll still remove it from the flow thread, but we'll now detect that we need to re-insert it when computed style has updated. Bug: 827424 Change-Id: I413348b0d3ecd0c4b5051e6e9d2a4526863bef60 Reviewed-on: https://chromium-review.googlesource.com/995439 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#548354} | 05 April 2018, 07:03:08 UTC |
54f844c | Fergal Daly | 05 April 2018, 06:33:47 UTC | CSS: Add WPT tests for basic ::part() functionality. https://drafts.csswg.org/css-shadow-parts/ Tests cover the following: - Simple - Part in selected host is styled - Host Stylesheet - Part in selected host is not styled by ::part in a stylesheet inside the host - Different Host - Part is not styled when host is not selected - Inner Host - Part in outer host is styled by document style sheet - Part in inner host is not styled by document style sheet - Compound Positive - Compound selector for host works - Compound Negative - Non-matching compound selector for host does not style - All Hosts - ::part with host selector styles in first host - ::part with host selector styles in second host - Chaining Negative - ::part cannot be chained to reach elements in the inner host Bug: 805271 Change-Id: I8c16ae09547bd833dbcc1eb0afb8be91a40c0a8e Reviewed-on: https://chromium-review.googlesource.com/983833 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548349} | 05 April 2018, 06:43:31 UTC |
1d21646 | Darren Shen | 05 April 2018, 02:55:33 UTC | [css-typed-om] Add support for grid properties. This patch adds support for some grid properties. We add a new <flex> CSS value object, which meant rebaselining all the tests. We're failing some tests because the 'grid', 'grid-template' and 'grid-gap' shorthands don't serialize to anything [1], so Typed OM can't create an unsupported style value from it. Not sure if this is a bug... [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp?type=cs&l=406 Bug: 820299 Change-Id: I8ff871fffed2977ca20a623bd283d7cbdc247870 Reviewed-on: https://chromium-review.googlesource.com/984756 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#548296} | 05 April 2018, 06:20:38 UTC |