https://github.com/facebook/rocksdb
Revision 0ccaba2a05db5c5930018d0d78775f29ba622e16 authored by Yi Wu on 23 May 2017, 17:32:02 UTC, committed by Yi Wu on 23 May 2017, 19:27:53 UTC
Summary: rocksdb.estimate-num-keys is compute from `estimate_num_keys - 2 * estimate_num_deletes`. If `2 * estimate_num_deletes > estimate_num_keys` it will underflow. Fixing it. Closes https://github.com/facebook/rocksdb/pull/2348 Differential Revision: D5109272 Pulled By: yiwu-arbug fbshipit-source-id: e1bfb91346a59b7282a282b615002507e9d7c246
1 parent 4646cd4
Tip revision: 0ccaba2a05db5c5930018d0d78775f29ba622e16 authored by Yi Wu on 23 May 2017, 17:32:02 UTC
Fix rocksdb.estimate-num-keys DB property underflow
Fix rocksdb.estimate-num-keys DB property underflow
Tip revision: 0ccaba2
ROCKSDB_LITE.md
# RocksDBLite
RocksDBLite is a project focused on mobile use cases, which don't need a lot of fancy things we've built for server workloads and they are very sensitive to binary size. For that reason, we added a compile flag ROCKSDB_LITE that comments out a lot of the nonessential code and keeps the binary lean.
Some examples of the features disabled by ROCKSDB_LITE:
* compiled-in support for LDB tool
* No backupable DB
* No support for replication (which we provide in form of TrasactionalIterator)
* No advanced monitoring tools
* No special-purpose memtables that are highly optimized for specific use cases
* No Transactions
When adding a new big feature to RocksDB, please add ROCKSDB_LITE compile guard if:
* Nobody from mobile really needs your feature,
* Your feature is adding a lot of weight to the binary.
Don't add ROCKSDB_LITE compile guard if:
* It would introduce a lot of code complexity. Compile guards make code harder to read. It's a trade-off.
* Your feature is not adding a lot of weight.
If unsure, ask. :)
Computing file changes ...
