0d817ea | Luna Lu | 13 March 2018, 17:34:49 UTC | Add WPT tests for feature policy frame policy 1. Without specifying allow attribute, frame policy inherits correctly. 2. With allow attribute, frame policy inherits from and overrides header policy correctly. Updating allowfullscreen and allowpaymentrequest correctly updates frame policy. 3. Frame policy is not affected by the frame's document policy. Bug: 732003 Change-Id: Ib41f883a779f11c564c91cfc03ff1224330108f5 Reviewed-on: https://chromium-review.googlesource.com/850896 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#542837} | 14 March 2018, 13:28:38 UTC |
9cd6f7a | Koji Ishii | 14 March 2018, 11:29:40 UTC | Review and cleanup wpt/css/css-text/ failures This patch reviewed failures of wpt/css/css-text, grouped and sorted, with following modifications: 1. Skip importing features with no active contributors. When we have plans or contributors, we can unskip them. 2. Following tests were removed because they are based on old versions of Unicode. According to the most recent spec at: https://www.unicode.org/Public/UNIDATA/extracted/DerivedLineBreak.txt css3-text-line-break-opclns-013 U+23B4 is AL, not CL css3-text-line-break-opclns-048 U+FD3E is CL, not OP css3-text-line-break-opclns-118 U+23B5 is AL, not CL css3-text-line-break-opclns-154 U+FD3F is OP, not CL css3-text-line-break-opclns-216 U+30FC is CJ, not NS css3-text-line-break-opclns-224 U+FF70 is CJ, not NS 3. Following tests were removed because they hard code pixel widths, and their cases are covered by other tests. word-break-normal-002 4. Following tests were removed because they are based on JLREQ, a W3C notes that explains traditional Japanese typography, but not defined in the CSS spec nor in Unicode spec. line-break-normal-025 line-break-strict-018a line-break-strict-018b Bug: 817781, 817778, 817776 Change-Id: I92b1abc99fa8019e5d514e485f6c4733075216ba Reviewed-on: https://chromium-review.googlesource.com/960683 Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#543049} | 14 March 2018, 11:37:56 UTC |
19fb3d6 | Manuel Rego Casasnovas | 14 March 2018, 10:57:25 UTC | [css-grid] Minimum width items should include margins for indefinite grid containers We had a TODO in IndefiniteSizeStrategy::MinLogicalWidthForChild() that was always using 0 as margin of the item. The patch just changes that for a call to GridLayoutUtils::MarginLogicalWidthForChild() (like we do in the DefiniteSizeStrategy version). BUG=816762 TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-001.html TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-002.html Change-Id: I743584aff234625f2d00327c711c0577ffeab457 Reviewed-on: https://chromium-review.googlesource.com/955062 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#543046} | 14 March 2018, 11:04:27 UTC |
a6c31d6 | Victor Costan | 14 March 2018, 09:55:13 UTC | Async Cookies API: Change events for documents. Bug: 729800 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic81f291fd9ea34647f0260d4d4dd88f3c90504d0 Reviewed-on: https://chromium-review.googlesource.com/881586 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#543042} | 14 March 2018, 10:02:31 UTC |
7b460c2 | Anne van Kesteren | 12 March 2018, 16:39:38 UTC | document.open()'s type argument is useless Ensure it stays that way for https://github.com/whatwg/html/pull/3559. | 14 March 2018, 09:26:38 UTC |
872f840 | Geoffrey Sneddon | 13 March 2018, 18:19:53 UTC | Add an "Edit on GitHub" link to the docs | 14 March 2018, 08:40:13 UTC |
b52a190 | Chris Nardi | 13 March 2018, 18:32:41 UTC | Move GetBoundingRect.html getBoundingClientRec is defined in CSSOM View, not CSSOM. | 14 March 2018, 08:35:20 UTC |
825f054 | Chris Nardi | 13 March 2018, 18:31:08 UTC | Add and correct CSSOM spec references Many CSSOM tests were missing spec references or had incorrect ones; add/update these references. | 14 March 2018, 08:35:20 UTC |
6573773 | Morten Stenshorne | 14 March 2018, 06:40:47 UTC | [LayoutNG] Don't resolve unresolvable percentage min-height and max-height. We cannot use the content size (intrinsic block size) as min-height or max-height (min-width or max-width, if writing mode is vertical). Doing so would cause min-height to incorrectly override any specified height or max-height that is less than the intrinsic block size, and max-height to override any specified height that's greater than the intrinsic block size. Do what the spec says [1] instead: max-height to become 'none', and min-height to become 0. This fixes the final rendering problem with Acid2 (this was about the min-height issue). It now renders correctly with LayoutNG! Since no other tests than Acid2 started to pass with this change, I wrote a couple. [1] https://www.w3.org/TR/CSS22/visudet.html#min-max-heights XXXXXX XX XX X X X O O X X X X /\ X X \/ X X X X X X X X XXXXXXXX X X X XX XX XXXXXX Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic4f2c3c1dbc2bd66956ed4b270b08058999bc351 Reviewed-on: https://chromium-review.googlesource.com/960085 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#543018} | 14 March 2018, 06:48:02 UTC |
07b4a27 | kaixinjxq | 14 March 2018, 05:45:20 UTC | Add sensor tests to throw NotSupportedError for an unsupported option (#10023) reflect to w3c/sensors#356 | 14 March 2018, 05:45:20 UTC |
dc2b101 | Adam Rice | 09 March 2018, 14:01:55 UTC | WritableStream: Add smoke tests for abort() with non-Error arguments Verify that abort(), abort(undefined) and abort('string') all work as expected, when called on a writer. The reason must be reflected in rejections received from the object. | 14 March 2018, 05:15:54 UTC |
d69705f | Darren Shen | 14 March 2018, 04:38:38 UTC | [css-typed-om] Support scroll-margin-*. This patch adds support for scroll-margin-* and adds relevant tests. Spec: https://drafts.csswg.org/css-scroll-snap-1/#margin-longhands-physical Bug: 820299 Change-Id: I46f8482c88c237de2a9d263b3a334ac9c03f4fca Reviewed-on: https://chromium-review.googlesource.com/958755 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#543004} | 14 March 2018, 04:47:19 UTC |
a0a4cfa | Darren Shen | 14 March 2018, 02:23:41 UTC | [css-typed-om] Add tests for font-size. Pretty standard test apart from font-size can't be negative. Bug: 774887 Change-Id: Ieae05dc71c68b5f777d6078e4c9daec0b6eebee4 Reviewed-on: https://chromium-review.googlesource.com/936961 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#542985} | 14 March 2018, 02:33:30 UTC |
bdec0b6 | Hwanseung Lee | 14 March 2018, 01:43:17 UTC | [css-typed-om] support break-after, break-before, break-inside break-after, break-before, break-inside are added to support in whitelist. and test file are also added. Bug: 820299 Change-Id: I9eb35a7371dd385edf3c039aea367b42e194e1e1 Reviewed-on: https://chromium-review.googlesource.com/960701 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Cr-Commit-Position: refs/heads/master@{#542980} | 14 March 2018, 01:55:00 UTC |
772ed22 | Wanming Lin | 14 March 2018, 01:29:05 UTC | Add tests for GeolocationSensor.read() (#9662) * Add tests for GeolocationSensor.read() covers: - verify sensor reading when call read() method - verify sensor reading when signal is set to null - throw AbortError when singal's abort flag is set - throw SecurityError when disabled by Feature Policy - AbortError takes priority when disabled by Feature Policy | 14 March 2018, 01:29:05 UTC |
b202bbb | Luke Bjerring | 14 March 2018, 01:18:08 UTC | Update the encoding IDL file (#9780) Also update the existing idlharness.js test to use it. | 14 March 2018, 01:18:08 UTC |
8896c5c | Chris Nardi | 14 March 2018, 00:17:00 UTC | Replace assert_own_property with assert_idl_attribute (#9960) CSSOM objects do not implement attributes as their own properties; they are IDL attributes. Switch to use assert_idl_attribute instead of assert_own_property. Also make inline-style-001.html pass by removing assert_readonly (it resets the attribute, making future tests fail) and use assert_equals instead of assert_regexp_match. | 14 March 2018, 00:17:00 UTC |
72a6148 | Chris Nardi | 14 March 2018, 00:10:51 UTC | Allow for exception to occur if medium not found (#9958) According to https://drafts.csswg.org/cssom/#dom-medialist-deletemedium, "If nothing was removed, then throw a NotFoundError exception." Throwing an exception in this step stops the test with an error. Assert that the correct exception is thrown, and allow the test to continue. | 14 March 2018, 00:10:51 UTC |
4f4793b | Geoffrey Sneddon | 13 March 2018, 22:43:57 UTC | Revert "Add a lint to catch adding files that would otherwise be ignored by git." (#10020) This reverts commit b3b4332e7aaf7b027c11be8a0750b9136bb90a70. See #10012. | 13 March 2018, 22:43:57 UTC |
47d3a27 | Servo WPT Sync | 13 March 2018, 19:31:58 UTC | Merge pull request #10011 from w3c/sync_ef805cb3832c2deaf1ab8fc4f3353b65671e6f32 Merge pull request #10011 from sync_ef805cb3832c2deaf1ab8fc4f3353b65671e6f32 | 13 March 2018, 19:31:58 UTC |
ef805cb | Anthony Ramine | 13 March 2018, 19:31:50 UTC | Remove HTMLIFrameElement.allowvr test This attribute was unshipped. Upstreamed from https://github.com/servo/servo/pull/20287 [ci skip] | 13 March 2018, 19:31:51 UTC |
3c78e4a | Marcos Cáceres | 13 March 2018, 17:58:01 UTC | Change PaymentRequest.abort() to manual test (#9988) | 13 March 2018, 17:58:01 UTC |
970fca8 | Geoffrey Sneddon | 12 March 2018, 18:00:28 UTC | Make .coveragerc not ignored | 13 March 2018, 13:55:16 UTC |
897dbad | Geoffrey Sneddon | 12 March 2018, 18:00:17 UTC | Make /testharness_runner.html not ignored | 13 March 2018, 13:55:16 UTC |
6ea93b9 | Geoffrey Sneddon | 12 March 2018, 17:24:22 UTC | Only ignore top-level MANIFEST.json | 13 March 2018, 13:55:16 UTC |
3b7a03a | Geoffrey Sneddon | 12 March 2018, 17:23:54 UTC | Ignore .pytest_cache | 13 March 2018, 13:55:16 UTC |
44395a6 | Geoffrey Sneddon | 12 March 2018, 17:21:09 UTC | Rearrange .gitignore | 13 March 2018, 13:55:16 UTC |
b5b3c1f | Morten Stenshorne | 13 March 2018, 11:29:55 UTC | [LayoutNG] Need parent's clearance offset when positioning child. If clear is specified on an element whose first piece of content is inside a child (so that the element's BFC offset cannot be determined at the beginning of layout), we need this child to know about the clearance offset on the parent, or it will not be pushed below adjacent floats as it should. Just pushing the parent, but leaving the children unaffected by clearance won't do. We need this in order to be able to lay out in a single pass (and apply clearance when we detect it, rather than doing it on the element with 'clear' and relayout the children if something moved). Since a constraint space's clearance offset is now "inherited" down the tree, as long as we're within the same block formatting context, we now also need to propagate the "is pushed by floats" flag upwards, or we won't detect class C break points correctly. Without this the unit test ClassCBreakPointBeforeBlockMarginCollapsing in NGColumnLayoutAlgorithmTest would regress, because it would incorrectly detect a class C break point before the break-inside:avoid block. We must make sure that class C break points are only detected on the outermost block that got pushed by floats, because it's there that we'll get the gap between the inner edge of the container and the outer edge of the child. Added some tests. One of them fails in legacy (but not in NG). One of the tests, clear-on-child-with-margins.html, passes both with and without this code change, but I started to wonder if we'd suddenly could end up pulling the parent of the box with 'clear' downwards, so thought I better add it, to make sure we don't regress in this regard. The test NoClassCBreakPointBeforeBfc in NGColumnLayoutAlgorithmTest no longer needs its workaround, because the display:flow-root child of #container now sets its position correctly (past the float) right away. Acid2 also looks slightly better now! Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I732b19398bd43b9874f6bb8c57ce435d1c510754 Reviewed-on: https://chromium-review.googlesource.com/957045 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#542769} | 13 March 2018, 11:37:14 UTC |
c7a4bd8 | Raphael Kubo da Costa | 13 March 2018, 09:07:53 UTC | magnetometer: Rename LocalCoordinateSystem enum. (#9974) Call it `MagnetometerLocalCoordinateSystem` after w3c/magnetometer#45. | 13 March 2018, 09:07:53 UTC |
71b44f9 | Raphael Kubo da Costa | 13 March 2018, 09:07:09 UTC | orientation-sensor: Rename LocalCoordinateSystem enum. (#9975) Call it `OrientationSensorLocalCoordinateSystem` per w3c/orientation-sensor#56. | 13 March 2018, 09:07:09 UTC |
8f7d065 | Adam Rice | 13 March 2018, 08:47:53 UTC | Prevent redirect loop in fetch/api/redirect/redirect-location.html (#9970) The value of invalidLocationUrl, "#invalidurl:" is actually treated as a valid URL by redirect.py, leading to a redirect loop. This makes the test take over 6 seconds in Chrome, causing it to time out. Change invalidLocationUrl to "invalidurl:" to avoid the redirect loop and make the test faster. See Chrome issue http://crbug.com/815286 about the test timing out. | 13 March 2018, 08:47:53 UTC |
05333aa | Marcos Cáceres | 13 March 2018, 06:29:56 UTC | convert PR.canMakePayment() to manual test | 13 March 2018, 06:29:56 UTC |
7879f0f | Tarun Bansal | 13 March 2018, 04:27:01 UTC | External WPT tests for Client hints This CL includes the test for "Accept-CH" header. If the origin includes "Accept-CH" in the response header, then the browser should include the specified client hints in the HTTP request headers for the resources contained in that page. Bug: 817049 Change-Id: Id74193ab7a1cc3c4b03d66e080c43c64a6fcfbb2 Reviewed-on: https://chromium-review.googlesource.com/951867 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542724} | 13 March 2018, 04:35:03 UTC |
6163df2 | Darren Shen | 13 March 2018, 02:37:01 UTC | [css-typed-om] Generate whitelist from CSSProperties.json5. Currently, any CSS property in CSSProperties.json5 with keywords will implicitly accept keywords. This can cause crashes if the property doesn't actually store keywords as CSSIdenifierValues. We solved this by having a manual whitelist of properties we explicitly support. However, this is annoying to maintain. So we generate this whitelist from CSSProperties.json5 by explicitly specifying "Keyword" as a typedom_type. e.g. a property that doesn't have typedom_types will not be supported by Typed OM. A property that has "Keyword" in typedom_types will take CSSKeywordValues and reify as CSSKeywordValues. We also add support for scroll-padding-* because the JSON for that was already there and we just to write a test for it. Diff of generated files: https://gist.github.com/darrnshn/03cb617909abab7bf94aaaaad9874a15/revisions Bug: 820299 Change-Id: I6fa01c3623161e0778c5f8764009c6e0cdd6bbf3 Reviewed-on: https://chromium-review.googlesource.com/956903 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#542697} | 13 March 2018, 02:45:28 UTC |
592bb79 | Darren Shen | 13 March 2018, 02:18:54 UTC | [css-typed-om] Fix DCHECK when creating a CSSUnitValue an empty unit. When we create a CSSUnitValue with '' as the unit, we hit a DCHECK in the unit trie code because the length is 0. This is because we don't correctly reject the empty string as an invalid unit. In this patch we fix this. Interestingly, we already have a test to assert that using an empty unit throws type error. However the test used an incorrect variable name, causing it to throw a TypeError anyway, so our tests would've passed no matter what. Bug: 820905 Change-Id: I72ab5e4010d892042b2cfddf1014ab79d04a846d Reviewed-on: https://chromium-review.googlesource.com/958624 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#542693} | 13 March 2018, 02:28:24 UTC |
682f0a2 | Chris Nardi | 13 March 2018, 02:14:06 UTC | Correct order of serialized media list values (#9985) According to the spec (https://drafts.csswg.org/cssom/#serialize-a-media-query-list), each media query should be serialized in the same order as they appear in the media query list. Media *features* are sorted in lexicographical order in a single media query, but media queries are not sorted in the same manner. Fix two tests to reflect the spec. | 13 March 2018, 02:14:06 UTC |
ae13e06 | Stephen McGruer | 13 March 2018, 01:33:01 UTC | Web Animations: Early-exit from setCurrentTime if new time is null The spec says that setting the current time to null should throw if the existing currentTime is non-null, or do nothing otherwise. Bug: 818196 Change-Id: Iac89e46d6b884c924c88b603fbec77b61a337ce2 Reviewed-on: https://chromium-review.googlesource.com/946050 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#542682} | 13 March 2018, 01:41:53 UTC |
28300a0 | Chris Nardi | 12 March 2018, 23:29:09 UTC | Upstream registerProperty tests to WPT Many tests of CSS.registerProperty were written, but none have been upstreamed to WPT. Upstream these tests to ensure interoperability. Bug: 641877 Change-Id: I8272b14c78cb75bb6f5f3cedb770091cbcba522a Reviewed-on: https://chromium-review.googlesource.com/959422 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542649} | 12 March 2018, 23:37:41 UTC |
284dfe4 | kritisingh1 | 12 March 2018, 20:45:34 UTC | minor changes | 12 March 2018, 22:39:10 UTC |
a41d008 | kritisingh1 | 08 March 2018, 16:22:10 UTC | minor fixes | 12 March 2018, 22:39:10 UTC |
36ce607 | kritisingh1 | 08 March 2018, 14:23:02 UTC | minor changes | 12 March 2018, 22:39:10 UTC |
d597a46 | kritisingh1 | 08 March 2018, 06:36:26 UTC | remove lines with GLib-GObject-CRITICAL | 12 March 2018, 22:39:10 UTC |
2f110a4 | rohilla21 | 27 February 2018, 11:46:33 UTC | This adds the ability to download latest Servo for `wpt run` Closes https://github.com/w3c/web-platform-tests/issues/9544 | 12 March 2018, 21:30:16 UTC |
18ce941 | Philip Jägenstedt | 12 March 2018, 18:51:56 UTC | Remove the rest of Sauce support for stability runs (including JWT) (#9977) Fixes https://github.com/w3c/web-platform-tests/issues/9903. | 12 March 2018, 18:51:56 UTC |
27b759e | L. David Baron | 10 March 2018, 00:05:20 UTC | Remove entries from the lint whitelist that are fixed by the fix for #9912. | 12 March 2018, 16:49:06 UTC |
a94171a | L. David Baron | 10 March 2018, 00:02:39 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/415e9b18ca2a1532086d5e2d5d21343cd004b5fd . This commit contains a single change: * [bug 1444136](https://bugzilla.mozilla.org/show_bug.cgi?id=1444136) by me, already reviewed by @gsnedders. Fixes #9912. | 12 March 2018, 16:49:06 UTC |
13bf4e5 | pyup.io bot | 12 March 2018, 16:43:57 UTC | Update selenium to 3.11.0 (#9969) | 12 March 2018, 16:43:57 UTC |
fcf82eb | Chris Nardi | 12 March 2018, 11:19:58 UTC | Remove duplicate color parsing tests css3/calc/color-{hsl/rgb}.html are already covered by external/wpt/css/css-values/calc-in-color-001.html, and fast/css/named-colors.html is already covered by external/wpt/css/css-color/color-resolving-keywords.html. Remove these duplicate tests. Change-Id: I2540ae5a6280bbfad0eb2192862826fc483d8314 Reviewed-on: https://chromium-review.googlesource.com/958285 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542457} | 12 March 2018, 16:28:27 UTC |
b11a9be | Geoffrey Sneddon | 12 March 2018, 16:02:38 UTC | Revert "Fix #9481: fix invalid output during environment initialization" This reverts commit 9692b53853bddd1afc53815ecce32de221612faf. | 12 March 2018, 16:14:31 UTC |
5a1c088 | Zirro | 12 March 2018, 15:43:43 UTC | Add tests for return value of DOMTokenList's replace() method See https://github.com/whatwg/dom/pull/582 and https://github.com/whatwg/dom/issues/577. | 12 March 2018, 15:43:43 UTC |
3c5d863 | Frédéric Wang | 12 March 2018, 14:35:24 UTC | Verify that modals are blocked in sandboxed frames without 'allow-mod… (#6618) Verify that modals are blocked in sandboxed frames without 'allow-modals'. | 12 March 2018, 14:35:24 UTC |
9692b53 | Yash Agarwal | 20 February 2018, 09:31:03 UTC | Fix #9481: fix invalid output during environment initialization Earlier the logger was emitting an empty JSON file for errors during environment initialization. Now the mozlog shutdown() method is called if the environment initialization fails to ensure that the generated report file contains valid JSON object. The suite_end() method functionality has been moved to the shutdown function to avoid redundancy. | 12 March 2018, 12:04:33 UTC |
8806dfd | Philip Jägenstedt | 10 March 2018, 00:01:54 UTC | Remove the Sauce Travis jobs Sauce cannot be kept working beyond April 17, see https://github.com/w3c/web-platform-tests/issues/9903. Given that they are not very reliable and take up Travis capacity, and that we don't have a replacement for this that can be put in place before April 17, it seems best to turn it off right away. The code is left in place until this is determined to work. | 12 March 2018, 11:08:19 UTC |
6e88051 | kaixinjxq | 12 March 2018, 08:03:18 UTC | Add sensor screen tests (#9942) * Add sensor screen tests * Add the detailed TODO thing in the annotation | 12 March 2018, 08:03:18 UTC |
e4f8dad | Chris | 12 March 2018, 07:14:27 UTC | Add Response test for propagating underlying ReadableStream error When a Response is constructed with ReadableStream, errors originating in that ReadableStream need to propagate to the Response during a Promise rejection. Tests throw errors in start() and pull() methods. Closes https://github.com/whatwg/fetch/issues/676. | 12 March 2018, 07:14:27 UTC |
cdf5b39 | Trent Apted | 12 March 2018, 04:02:04 UTC | Revert "bluetooth: Use DeviceUUID in FakeBluetooth" This reverts commit af1c15b16f99d290799c83d34c111bce52447026. Reason for revert: suspected for persistent failures on Win7 Tests (dbg)(1) Unexpected Failures: * external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html * external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html * external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html * external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html * external/wpt/upgrade-insecure-requests/link-upgrade.sub.https.html since https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66761 errors like 15:59:42.310 5904 worker/4 external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html crashed, (stderr lines): 15:59:42.311 5904 CONSOLE MESSAGE: line 255: Web Bluetooth is experimental on this platform. See https://github.com/WebBluetoothCG/web-bluetooth/blob/gh-pages/implementation-status.md 15:59:42.327 1300 [1691/5755] external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html failed unexpectedly (content_shell crashed [pid=5644]) Original change's description: > bluetooth: Use DeviceUUID in FakeBluetooth > > This change refactors the Web Bluetooth test API to use the > DeviceUUIDs helper class defined in BluetoothDevice. Additionally, > this change finishes the implementation of SimulateGATTServicesChanged, > and as a result, tests are updated to set the next discovery response > before calling this interface. > > BUG=719826 > > Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d > Reviewed-on: https://chromium-review.googlesource.com/939984 > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541577} TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 719826 Change-Id: I02bb7066c6f1282191f7a24e91b3d2c5614b8104 Reviewed-on: https://chromium-review.googlesource.com/958741 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#542421} | 12 March 2018, 04:10:37 UTC |
9c9d8f2 | Harald Alvestrand | 11 March 2018, 20:34:37 UTC | Merge pull request #9941 from fippo/better-dtmf-test-helper webrtc: improve Firefox compability of RTCDTMFHelper | 11 March 2018, 20:34:37 UTC |
5e377e2 | Chris McGowan | 10 March 2018, 15:51:37 UTC | resolved Lint error | 10 March 2018, 22:25:25 UTC |
8feb066 | Chris | 10 March 2018, 14:39:32 UTC | add HTTPS, root CA, and certs location info to README and Docs | 10 March 2018, 22:25:25 UTC |
2f6cfc4 | Ovidio Henriquez | 10 March 2018, 06:29:32 UTC | bluetooth: Handle UUIDs in service data Adds a Mojo typemap to properly handle the UUID strings in the service_data field of ScanRecord. The typemap allows the service_data field to map to a device::BluetoothDevice::ServiceDataMap object in C++. BUG=817603 Change-Id: Ie4d5785e8b04098fda76ca8bc99c58141c9b5b82 Reviewed-on: https://chromium-review.googlesource.com/942307 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#542344} | 10 March 2018, 22:01:23 UTC |
b0a57a6 | Hitoshi Yoshida | 10 March 2018, 16:18:29 UTC | idl: Fix [EnforceRange] annotations This CL fixes usages of [EnforceRange] annotations in IDL files. No changes on behaviors. CSSUnitValue: [EnforceRange] can't annotate non-integer numbers, and the spec doesn't have the annotation. OffscreenCanvas: The spec doesn't have [EnforceRange], but it seems the spec is wrong. (requesting to update the spec; https://github.com/whatwg/html/issues/3540) IDBFactory and IDBIndex: Follows spec. Test IDLs: This CL works for tests in Chromium repository, and following tests need to be upstream for WPT. - wpt/interfaces/IndexedDB.idl - wpt/interfaces/WebCryptoAPI.idl Bug: 819112 Change-Id: If7082cba0251a83e269fea428340b3b61d4c17cf Reviewed-on: https://chromium-review.googlesource.com/952589 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#542375} | 10 March 2018, 16:25:27 UTC |
412da2c | Rune Lillesveen | 10 March 2018, 10:30:24 UTC | Computed style inside iframe depends on parent layout. Make sure we layout the parent document when it's dirty. Bug: 819189 Change-Id: I3835aa913e20abdd4adaab072567191b3ca25c20 Reviewed-on: https://chromium-review.googlesource.com/951248 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#542372} | 10 March 2018, 10:37:27 UTC |
1f638e8 | Lukasz Anforowicz | 10 March 2018, 06:38:02 UTC | Make 2 tests immune to legitimate races between cross-origin subframes Bug: 820589 Change-Id: I16c02746c61f42fafead5f96ae436b331fba4f85 Reviewed-on: https://chromium-review.googlesource.com/957587 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542360} | 10 March 2018, 06:45:19 UTC |
ed82311 | Chandan Padhi | 10 March 2018, 02:05:40 UTC | Implement InputDeviceInfo.getCapabilities() for audio devices Bug: 817769 Change-Id: Iae2abc17aee26c5586c38412140f18fbacc66568 Reviewed-on: https://chromium-review.googlesource.com/945590 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#542312} | 10 March 2018, 02:14:19 UTC |
83b0a62 | Friedrich Horschig | 09 March 2018, 11:59:09 UTC | Add http-state cookie tests from abart/http-state github repository These are the first steps to port the http-state cookie tests from https://github.com/abarth/http-state/tree/master/tests to the external/wpt/ directory. Accessing <server>/cookies/http-state/all-tests.html will run all tests in cookies/http-state/resources/test-files/. This ensures that tests stay isolated, ignore set cookies and clean up cookies after themselves. By accessing the server directly, single tests can be debugged. e.g. to run test file 0005 in isolation, access this URL: <server>/cookies/http-state/resources/cookie-setter.py?debug=0005 Change-Id: I1fceccf0bc5d080d024998451abd027142d6a16a Reviewed-on: https://chromium-review.googlesource.com/807988 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#542085} | 09 March 2018, 23:41:26 UTC |
8913605 | bmac | 09 March 2018, 18:42:42 UTC | Fix link to w3c-test.org in the running-tests docs | 09 March 2018, 23:00:40 UTC |
e4899e9 | Raphael Kubo da Costa | 09 March 2018, 22:23:55 UTC | accelerometer: Rename LocalCoordinateSystem to AccelerometerLocalCoordinateSystem (#9949) Adapt to w3c/accelerometer#42. | 09 March 2018, 22:23:55 UTC |
47e4c8d | Raphael Kubo da Costa | 09 March 2018, 22:23:19 UTC | gyroscope: Rename LocalCoordinateSystem to GyroscopeLocalCoordinateSystem (#9948) Adapt to w3c/gyroscope#34. | 09 March 2018, 22:23:19 UTC |
90d610b | Robert Ma | 09 March 2018, 22:17:57 UTC | Document that we wait for web fonts in reftests (#9951) | 09 March 2018, 22:17:57 UTC |
18d9e51 | Jim Evans | 07 March 2018, 00:49:50 UTC | Automatically setting session to None for new session tests There is an edge case in the current implementation where a new session test can create a new session and expressly close the created session by calling `end()`, but the next test that is not a new session test sees the "current session" object as not `None`, and failing to create a new session. This change fixes that issue. If the session is not None and has a valid session ID, the `end()` method still gets called. If the current session is not None, but has an invalid session ID, it cannot be terminated any other way, so setting the current session to None at that point is not a negative side effect. Finally, if the current session is already None, setting the variable to None again does not hurt. | 09 March 2018, 21:13:14 UTC |
de0c4ad | Fredrik Söderquist | 09 March 2018, 15:36:30 UTC | [PE] Add "image/apng" to supported image MIME types Supported for animated PNG (APNG) was added via crbug.com/437662 (commit 7d2b8c45afc9c0230410011293cc2e1dbb8943a7.) The "image/apng" MIME type is included in the "Accept" header for image requests. Add "image/apng" to kSupportedImageTypes to allow things like the <picture> element to work (select an appropriate image based on 'type'.) Add "image/apng" to kPrimaryMappings to allow the MIME type to resolve to a reasonable file extension. Bug: 730588 Change-Id: I070e8b16dc8312552b11dc32e776493b3a5be669 Reviewed-on: https://chromium-review.googlesource.com/957092 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#542113} | 09 March 2018, 15:45:56 UTC |
42c98bf | Xianzhu Wang | 06 March 2018, 00:04:42 UTC | [PE] Don't truncate table cell's padding Truncation caused inadequate logical width when padding is like 1.7px. Bug: 817342 Change-Id: Ibdb76cc528cc7e04801fe65409bb8f60e5ac69a5 Reviewed-on: https://chromium-review.googlesource.com/943827 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#540991} | 09 March 2018, 15:27:25 UTC |
6cca524 | Morten Stenshorne | 09 March 2018, 11:51:12 UTC | Don't pixel-snap the top and bottom of lines. That might cause incorrect detection of overflow, since the height of the block isn't pixel-snapped. Bug: 818873 Change-Id: I864be9dfedf6f008fe19ce02088ac6488ec274d0 Reviewed-on: https://chromium-review.googlesource.com/954022 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#542080} | 09 March 2018, 12:06:35 UTC |
d77d53e | Philipp Hancke | 09 March 2018, 08:10:27 UTC | webrtc: improve Firefox compability of RTCDTMFHelper does not check canInsertDTMF which is not implemented in Firefox yet. | 09 March 2018, 08:14:42 UTC |
6911cb3 | fantasai | 09 March 2018, 07:07:33 UTC | [css-writing-mode] Move sideways-* tests to L4 | 09 March 2018, 07:44:16 UTC |
61da32f | fantasai | 09 March 2018, 06:03:53 UTC | [css-writing-modes] Move 'text-combine-upright: digits' tests to Level 4 | 09 March 2018, 07:11:17 UTC |
0de8b99 | Han Leon | 09 March 2018, 06:19:21 UTC | [ServiceWorker] Fix an incorrect usage of assert_equals() in wpt test This prototype is 'assert_equals(actual, expected, description)', we should pass 'actual' and 'expected' in order, to make the failure message be reasonable. This CL just fixes external/wpt/service-workers/service-worker/navigate-window.https.html. BUG= Change-Id: Ic11ec67f27f7a9a5ae289ddda4362af72b4737d4 Reviewed-on: https://chromium-review.googlesource.com/955282 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542048} | 09 March 2018, 06:36:35 UTC |
81468a0 | Adam Rice | 09 March 2018, 05:25:24 UTC | Streams: Modify tests to expect abort reason passthrough (#9926) This tests the changes in https://github.com/whatwg/streams/pull/903. Replace expectations that a TypeError will be stored after abort() is called with with expectations that the reason passed to abort() will be stored instead. Also add a test of the stored error on the readable side of a TransformStream after abort() has been called on the writable size. This was not explicitly tested. Also fix a bug in the general.js test: it didn't wrap a call to assert_unreached properly, so a failure would have shown up as an unhandled rejection rather than being reported properly. | 09 March 2018, 05:25:24 UTC |
68c1f9a | Darren Shen | 09 March 2018, 03:43:25 UTC | [css-typed-om] Clean up CSSUnparsedValue & CSSVariableRefValue tests. This patch: - Splits existing tests into different files testing different parts of the IDL (e.g. separate file for cssUnparsedValue.length) - Fix some stylistic issues. Bug: 774887 Change-Id: I8b37679b96d1b1b6e44c4eb596036dcafa88264b Reviewed-on: https://chromium-review.googlesource.com/954525 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#542012} | 09 March 2018, 03:51:35 UTC |
72c64a5 | Philip Jägenstedt | 09 March 2018, 03:10:49 UTC | Add css-align/OWNERS (#9215) | 09 March 2018, 03:10:49 UTC |
311196c | Luke Bjerring | 09 March 2018, 02:37:03 UTC | Update the UI Events IDL file (#9835) | 09 March 2018, 02:37:03 UTC |
9817f7f | Luke Bjerring | 08 March 2018, 20:44:00 UTC | Updated entries-api IDL file | 08 March 2018, 23:13:19 UTC |
9a9e752 | Luke Bjerring | 02 March 2018, 17:10:07 UTC | Add entries-api idl file | 08 March 2018, 23:13:19 UTC |
df0b73b | Kriti Singh | 08 March 2018, 23:04:43 UTC | Remove tests testing <meta http-equiv=link> from cascade-import-002.xht (#9930) Remove tests g,h,q,r from cascade-import-002.xht because they test the obsoleted and removed <meta http-equiv=link>. Closes #9910 | 08 March 2018, 23:04:43 UTC |
b3b4332 | Josh Matthews | 07 March 2018, 18:41:47 UTC | Add a lint to catch adding files that would otherwise be ignored by git. | 08 March 2018, 20:10:15 UTC |
3ac8f05 | Chris Nardi | 08 March 2018, 12:25:11 UTC | Upstream CSS selectors tests to WPT Remove already existing duplicate tests, and upstream a unified version of currently existing an + b selector parsing tests. Bug: 818475 Change-Id: Id889175e0d4df27037ee335d23020c213c148b44 Reviewed-on: https://chromium-review.googlesource.com/952078 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541774} | 08 March 2018, 16:47:06 UTC |
da1dbe3 | Marcos Cáceres | 08 March 2018, 16:18:46 UTC | Add regionCode test (manual and idl) (#9706) * Add regionCode test (manual and idl) | 08 March 2018, 16:18:46 UTC |
aaea1a4 | Chandan Padhi | 08 March 2018, 11:46:05 UTC | Introduce InputDeviceInfo interface InputDeviceInfo extends MediaDeviceInfo and represents audio and video input devices. These objects are the result of calling MediaDevices.enumerateDevices(). This interface gives access to the capabilities of the input device it represents via getCapabilities() method which will be implemented in asubsequent CL. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h4sCuIqb_78 Bug: 817769 Change-Id: Ic9a016a05e622ee02b86d567f64c3ed84f0926c3 Reviewed-on: https://chromium-review.googlesource.com/942961 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#541772} | 08 March 2018, 15:58:25 UTC |
c36f238 | Andy Paicu | 08 March 2018, 11:08:00 UTC | 'navigate-to' directive tests PR: https://github.com/w3c/webappsec-csp/pull/290 Bug: 805886 Change-Id: I5bdda65c7e70e729b33a3647135fee6453e97e66 Reviewed-on: https://chromium-review.googlesource.com/934181 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#541769} | 08 March 2018, 15:48:59 UTC |
38aab7a | Reuben Morais | 05 March 2018, 12:12:24 UTC | On MacOS, search for Firefox binary in common paths (#7125) | 08 March 2018, 15:34:25 UTC |
86d68c3 | moz-wptsync-bot | 06 March 2018, 11:31:05 UTC | wdspec] Remove usage of mozlog to prevent process lock. Due to misbehavior of the threading module in how threads are forked, the mozlog module and specifically the Lock instance in StructuredLogger can cause a hang of random duration when trying to require the lock. Given that mozlog isn't used anywhere workaround this problem by removing all instances of it. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1407383 gecko-commit: c26cb6d150d56cb8b2a1e4136da7cff7c60c5d51 gecko-integration-branch: autoland gecko-reviewers: jgraham | 08 March 2018, 15:32:49 UTC |
621328b | moz-wptsync-bot | 06 March 2018, 11:31:04 UTC | wdspec] Remove unused imports from fixtures module. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1407383 gecko-commit: 880cc555591a971a9b04790a93a694315a293297 gecko-integration-branch: autoland gecko-reviewers: jgraham | 08 March 2018, 15:32:49 UTC |
6a8a912 | jgraham | 08 March 2018, 15:25:02 UTC | Require mozdownload and mozinstall when running wpt install. (#9875) mozdownload and mozinstall are now used to install Firefox. Therefore they are required to run the |wpt install| command. | 08 March 2018, 15:25:02 UTC |
7949111 | Domenic Denicola | 08 March 2018, 14:49:56 UTC | Writable streams: test changes to abort() under error conditions (#9917) Follows https://github.com/whatwg/streams/pull/901. | 08 March 2018, 14:49:56 UTC |
23261ad | Luke Bjerring | 08 March 2018, 14:34:44 UTC | Update the url IDL file (#9836) * Add url idl file * Use url.idl file from url test. | 08 March 2018, 14:34:44 UTC |
332d448 | Brandon Jones | 08 March 2018, 06:41:27 UTC | Moved XR getViewport, removed XRDevice.external Brings Chrome's implementation inline with the latest spec changes. Bug: 819744 Change-Id: I716bab14bdbcc1c452a4dd447adbe28ffef05f98 Reviewed-on: https://chromium-review.googlesource.com/953259 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#541739} | 08 March 2018, 13:58:24 UTC |
8ef3fed | Chris Nardi | 08 March 2018, 04:03:23 UTC | Upstream some CSSOM tests Tests that were duplicates of those already existing in web-platform-tests were deleted. Other tests were either moved to the CSSOM directory in WPT, or appended to already existing tests. The README was also deleted, as it is no longer accurate. Change-Id: I0acb41c6102a572a1fc2401630732a8ff1c5263d Reviewed-on: https://chromium-review.googlesource.com/945135 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541716} | 08 March 2018, 12:55:29 UTC |
6cd55d2 | Lukasz Anforowicz | 08 March 2018, 01:14:30 UTC | Move core CORB logic into //services/network. This CL moves the core CORB logic (figuring out if a given response should be CORB-protected based on 1) response metadata like initiator, MIME type, CORS headers and 2) sniffing the first bytes of the response) from //content/common into //services/network. As part of the move, this CL makes some extra, opportunistic changes: - Renames the moved files (and the moved class) to match the name agreed upon in the explainer (s/CrossSiteDocumentClassifier/CrossOriginReadBlocking) - Also moves the explainer doc to //services/network - Tweaks the old CrossSiteDocumentMimeType enum so that - It is nested in CrossOriginReadBlocking::MimeType - The enum values have shorter names In the long-term, the core CORB logic should only be needed within services/network. In the short-term, this logic has the following consumers: - content/browser/loader/cross_site_document_resource_handler.cc (integrates CORB into the old, pre-network-service, ResourceHandler-based world; this can go away after the network service ships) - content/renderer/loader/site_isolation_stats_gatherer.cc (gathers UMA that help decide what responses can be blocked by CORB with acceptably low risk of breaking existing websites; this can go away after CORB ships) - WIP(https://crbug.com/792546): services/network/url_loader.cc (this will integrate CORB into the new, network-service world). Bug: 792546 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib8fe412b1f807d23e41700b7f7090cd4b77c1783 Reviewed-on: https://chromium-review.googlesource.com/929446 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#541661} | 08 March 2018, 12:05:48 UTC |
ab1fd25 | Darren Shen | 07 March 2018, 21:53:05 UTC | [css-typed-om] Clean up parsing tests. This patch: - Deletes unused interface.html - Fixes <div> tag in tests. - Adds case-sensitivity tests. Bug: 774887 Change-Id: I194ec7549991bfcd7708e640458246b40fc3ab03 Reviewed-on: https://chromium-review.googlesource.com/952509 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#541592} | 08 March 2018, 10:21:03 UTC |
4038be6 | Ovidio Henriquez | 07 March 2018, 21:13:41 UTC | bluetooth: Use DeviceUUID in FakeBluetooth This change refactors the Web Bluetooth test API to use the DeviceUUIDs helper class defined in BluetoothDevice. Additionally, this change finishes the implementation of SimulateGATTServicesChanged, and as a result, tests are updated to set the next discovery response before calling this interface. BUG=719826 Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d Reviewed-on: https://chromium-review.googlesource.com/939984 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#541577} | 08 March 2018, 10:10:32 UTC |