https://github.com/torvalds/linux
Revision 0db99e3359234be181590463184b9959059a9ea9 authored by Mike Christie on 26 August 2006, 07:00:22 UTC, committed by James Bottomley on 26 August 2006, 15:03:14 UTC
The callers of scsi_send_eh_cmnd are setting the cmnd buffer,
and then scsi_send_eh_cmnd is copying that updated buffer to
the old_cmnd variable. Then after the command runs, we end up
copying that old_cmnd var which has the new cmnd to the scsi
command buffer. When this command gets recent, all types of fun
things happen like getting TUR or START_STOP commands with
data and scatterlists.

This patch made against scsi-rc-fixes, has the callers of
scsi_send_eh_cmnd pass in the command so scsi_send_eh_cmnd
can do the right thing. This should go into 2.6.18 since this
fixes a regression added when we removed some of the scsi_cmnd
fields and replaced them with local variables.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
1 parent 15a3758
History
Tip revision: 0db99e3359234be181590463184b9959059a9ea9 authored by Mike Christie on 26 August 2006, 07:00:22 UTC
[SCSI] fix scsi_send_eh_cmnd regression
Tip revision: 0db99e3
File Mode Size
Makefile -rw-r--r-- 112 bytes
inode.c -rw-r--r-- 19.4 KB

back to top