https://github.com/torvalds/linux
Revision 0fbbeb1ba43bd04f0f1d4f161b7f72437a1c8a03 authored by Thomas Graf on 23 August 2005, 17:12:44 UTC, committed by David S. Miller on 23 August 2005, 17:12:44 UTC
qdisc_create_dflt() is missing to destroy the newly allocated
default qdisc if the initialization fails resulting in leaks
of all kinds. The only caller in mainline which may trigger
this bug is sch_tbf.c in tbf_create_dflt_qdisc().

Note: qdisc_create_dflt() doesn't fulfill the official locking
      requirements of qdisc_destroy() but since the qdisc could
      never be seen by the outside world this doesn't matter
      and it can stay as-is until the locking of pkt_sched
      is cleaned up.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent d2287f8
History
Tip revision: 0fbbeb1ba43bd04f0f1d4f161b7f72437a1c8a03 authored by Thomas Graf on 23 August 2005, 17:12:44 UTC
[PKT_SCHED]: Fix missing qdisc_destroy() in qdisc_create_dflt()
Tip revision: 0fbbeb1

README

back to top