Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
0fc8466 Joey Perrott 16 December 2020, 23:34:24 UTC release: cut the v11.1.0-next.3 release (#40166) PR Close #40166 16 December 2020, 23:39:10 UTC
70b4816 Alan Agius 15 December 2020, 10:04:47 UTC fix(core): set `ngDevMode` to `false` when calling `enableProdMode()` (#40124) The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`. https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case. PR Close #40124 16 December 2020, 21:20:58 UTC
47d9b6d Misko Hevery 15 December 2020, 21:00:29 UTC fix(core): fix possible XSS attack in development through SSR. (#40136) Escape the content of the strings so that it can be safely inserted into a comment node. The issue is that HTML does not specify any way to escape comment end text inside the comment. `<!-- The way you close a comment is with "-->". -->`. Above the `"-->"` is meant to be text not an end to the comment. This can be created programmatically through DOM APIs. ``` div.innerHTML = div.innerHTML ``` One would expect that the above code would be safe to do, but it turns out that because comment text is not escaped, the comment may contain text which will prematurely close the comment opening up the application for XSS attack. (In SSR we programmatically create comment nodes which may contain such text and expect them to be safe.) This function escapes the comment text by looking for the closing char sequence `-->` and replace it with `-_-_>` where the `_` is a zero width space `\u200B`. The result is that if a comment contains `-->` text it will render normally but it will not cause the HTML parser to close the comment. PR Close #40136 16 December 2020, 17:38:08 UTC
2e7727c Stepan Suvorov 28 October 2020, 16:23:53 UTC docs(docs-infra): link to angular-pro screencasit (#39472) PR Close #39472 15 December 2020, 22:37:56 UTC
caa4666 Andrew Kushnir 11 December 2020, 06:12:29 UTC fix(compiler): avoid duplicate i18n blocks for i18n attrs on elements with structural directives (#40077) Currently when `ɵɵtemplate` and `ɵɵelement` instructions are generated by compiler, all static attributes are duplicated for both instructions. As a part of this duplication, i18n translation blocks for static i18n attributes are generated twice as well, causing duplicate entries in extracted translation files (when Ivy extraction mechanisms are used). This commit fixes this issue by introducing a cache for i18n translation blocks (for static attributes only). Also this commit further aligns `ɵɵtemplate` and `ɵɵelement` instruction attributes, which should help implement more effective attributes deduplication logic. Closes #39942. PR Close #40077 15 December 2020, 21:40:09 UTC
245dccc Joey Perrott 11 December 2020, 20:51:29 UTC build: update config flags for snapshot builds (#40095) Update the config flags used for snapshot builds and release builds. PR Close #40095 15 December 2020, 21:36:56 UTC
c44baa4 Joey Perrott 11 December 2020, 20:34:44 UTC feat(dev-infra): support --mode flag for building environment stamp (#40095) When building the environment stamp, support two modes: release and snapshot The release mode will always stamp using the current version of in the root package.json and in snapshot mode will use a version stamp expressing a version based on the tag and the number of commits from the tag. PR Close #40095 15 December 2020, 21:36:56 UTC
dcb3d17 Alan Agius 09 December 2020, 12:10:02 UTC docs: update optimization and source map section (#40037) With this change we split the optimization and source map configuration section section into two, improve it overall by adding theoptions a table and add the new options (`inlineCritical` and `minify`) that have been introduced in CLI version 11.1 PR Close #40037 15 December 2020, 21:32:28 UTC
db97453 Zach Arend 03 December 2020, 19:42:46 UTC refactor(compiler-cli): move template parse errors to TemplateData (#40026) Durring analysis we find template parse errors. This commit changes where the type checking context stores the parse errors. Previously, we stored them on the AnalysisOutput this commit changes the errors to be stored on the TemplateData (which is a property on the shim). That way, the template parse errors can be grouped by template. Previously, if a template had a parse error, we poisoned the module and would not procede to find typecheck errors. This change does not poison modules whose template have typecheck errors, so that ngtsc can emit typecheck errors for templates with parse errors. Additionally, all template diagnostics are produced in the same place. This allows requesting just the template template diagnostics or just other types of errors. PR Close #40026 15 December 2020, 21:30:52 UTC
9dedb62 Zach Arend 10 December 2020, 19:30:50 UTC test(compiler-cli): fix i18n error tests (#40026) Refactors the i18n error tests to be unit tests in ngtsc_spec.ts. There is two reasons for doing this. First is that the tests in compliace_old expected an expection to be be thrown but did not fail the test if no exception was thrown. That means that this test could miss catching a bug. It is also a big hacky to call compile directly and expect an exception to be thrown for diagnostics. Also, this can easily be unit tested and an end-to-end test is not necessary since we are not making use of the goldfiles for these tests. It is easier to maintain and less hacky to validate that we get helpful error messages when nesting i18n sections by calling getDiagnostics directly. PR Close #40026 15 December 2020, 21:30:52 UTC
973bb40 Alex Rickabaugh 14 December 2020, 22:10:18 UTC fix(compiler-cli): remove classes in .d.ts files from provider checks (#40118) This commit temporarily excludes classes declared in .d.ts files from checks regarding whether providers are actually injectable. Such classes used to be ignored (on accident) because the `TypeScriptReflectionHost.getConstructorParameters()` method did not return constructor parameters from d.ts files, mostly as an oversight. This was recently fixed, but caused more providers to be exposed to this check, which created a breakage in g3. This commit temporarily fixes the breakage by continuing to exclude such providers from the check, until g3 can be patched. PR Close #40118 15 December 2020, 00:14:25 UTC
2a74431 Alex Rickabaugh 08 December 2020, 01:16:31 UTC feat(language-service): completions for structural directives (#40032) This comit adds support for autocompletion of attributes that create structural directives. Such completions differ from those of normal attributes, as the structural directive syntax creates a synthetic <ng-template> node which has different attributes from the main element. PR Close #40032 14 December 2020, 20:08:41 UTC
c55bf4a Alex Rickabaugh 08 December 2020, 01:15:37 UTC refactor(compiler-cli): identify structural directives (#40032) This commit introduces an `isStructural` flag on directive metadata, which is `true` if the directive injects `TemplateRef` (and thus is at least theoretically usable as a structural directive). The flag is not used for anything currently, but will be utilized by the Language Service to offer better autocompletion results for structural directives. PR Close #40032 14 December 2020, 20:08:41 UTC
cbb6eae Alex Rickabaugh 03 December 2020, 21:45:34 UTC feat(language-service): autocomplete pipe binding expressions (#40032) This commit adds autocompletion for pipe expressions, built on existing APIs for checking which pipes are in scope. PR Close #40032 14 December 2020, 20:08:41 UTC
66378ed Alex Rickabaugh 04 December 2020, 02:08:00 UTC feat(language-service): complete attributes on elements (#40032) This commit adds attribute completion to the Language Service. It completes from 3 sources: 1. inputs/outputs of directives currently present on the element 2. inputs/outputs/attributes of directives in scope for the element, that would become present if the input/output/attribute was added 3. DOM properties and attributes We distinguish between completion of a property binding (`[foo|]`) and a completion in an attribute context (`foo|`). For the latter, bindings to the attribute are offered, as well as a property binding which adds the square bracket notation. To determine hypothetical matches (directives which would become present if a binding is added), directives in scope are scanned and matched against a hypothetical version of the element which has the attribute. PR Close #40032 14 December 2020, 20:08:41 UTC
c0ab43f Alex Rickabaugh 04 December 2020, 22:43:26 UTC refactor(compiler-cli): introduce APIs to support directive autocompletion (#40032) This commit adds two new APIs to the `TemplateTypeChecker`: `getPotentialDomBindings` and `getDirectiveMetadata`. Together, these will support the Language Service in performing autocompletion of directive inputs/outputs. PR Close #40032 14 December 2020, 20:08:41 UTC
a543e69 Alex Rickabaugh 03 December 2020, 18:52:42 UTC refactor(compiler-cli): make `TypeCheckingScopeRegistry` a general utility (#40032) The `annotations` package in the compiler previously contained a registry which tracks NgModule scopes for template type-checking, including unifying all type-checking metadata across class inheritance lines. This commit generalizes this utility and prepares it for use in the `TemplateTypeChecker` as well, to back APIs used by the language service. PR Close #40032 14 December 2020, 20:08:41 UTC
e42250f Alex Rickabaugh 19 November 2020, 01:30:52 UTC feat(language-service): autocompletion of element tags (#40032) This commit expands the autocompletion capabilities of the language service to include element tag names. It presents both DOM elements from the Angular DOM schema as well as any components (or directives with element selectors) that are in scope within the template as options for completion. PR Close #40032 14 December 2020, 20:08:40 UTC
ccaf48d Alex Rickabaugh 18 November 2020, 22:07:30 UTC refactor(language-service): add context to template target system (#40032) This commit extends the template targeting system, which determines the node being referenced given a template position, to return additional context if needed about the particular aspect of the node to which the position refers. For example, a position pointing to an element node may be pointing either to its tag name or to somewhere in the node body. This is the difference between `<div|>` and `<div foo | bar>`. PR Close #40032 14 December 2020, 20:08:40 UTC
524d581 Alexey Elin 14 December 2020, 14:06:23 UTC docs: fix typo (#40106) PR Close #40106 14 December 2020, 19:51:25 UTC
19d43af Zach Arend 11 December 2020, 20:29:25 UTC fix(dev-infra): add vim .swp files to gitignore (#40094) The vim editor produces temporarily files that can end in both .swo and .swp. This commits add .swp to the .gitignore so we don't accidentaly commit temporary files. PR Close #40094 14 December 2020, 19:39:41 UTC
c18a9d5 George Kalpakas 11 December 2020, 17:02:45 UTC ci: reduce flakiness of docs-infra `deploy-to-firebase.js` tests (#40088) The `deploy-to-firebase.js` tests rely on git info retrieved from the `angular/angular` repository (via `git ls-remote ...`). Previously, different calls to `git ls-remote ...` could return different values if a new commit was pushed or a new branch was created during test execution, resulting in errors ([example CI failure][1]). This commit makes the tests more stable by memoizing the result of `git ls-remote ...` and returning the same result for subsequent calls with the same arguments (even if meanwhile the remote has been updated). [1]: https://circleci.com/gh/angular/angular/877626 PR Close #40088 14 December 2020, 19:38:32 UTC
4f4f318 Alexey Elin 11 December 2020, 14:56:11 UTC docs: remove prefixed animation related CSS properties (#40084) Angular has stopped to support browser that requires these CSS properties. All supported browsers support standard CSS properties: * @keyframes rule * animation PR Close #40084 14 December 2020, 19:36:48 UTC
1e05109 Alexey Elin 11 December 2020, 10:00:41 UTC docs: remove unused CSS rule (#40080) Removed rule don't affect their component views. The reason - the templates don't contain elements to which that rule is applied. See https://angular.io/guide/view-encapsulation for more details PR Close #40080 14 December 2020, 19:35:36 UTC
c977e1b Andrew Kushnir 11 December 2020, 06:51:01 UTC test(compiler): use `yarn bazel` instead of `bazel` in error message (#40078) This commit replaces `bazel` with `yarn bazel` in the error message (that instructs to regenerate golden file) thrown while executing compliance tests. We use `yarn bazel` in other places (so we use the local version of bazel, not the global one). PR Close #40078 14 December 2020, 19:34:41 UTC
044cd52 Alan Agius 09 December 2020, 12:09:14 UTC docs: update CLI MAN page format (#40038) With this change we update the CLI docs template to seperate the following the default and value types from the argument field. This should make it clearer and more understandable PR Close #40038 14 December 2020, 19:31:07 UTC
3b02e4e David Shevitz 23 November 2020, 23:11:47 UTC docs: Rename Main concepts to Understanding Angular, Built-in Features to Developer Guides (#39930) PR Close #39930 14 December 2020, 19:30:21 UTC
35a1975 JiaLiPassion 11 November 2020, 17:42:36 UTC build: update to use npm_package.pack rule (#39636) Remove the work around solution for the `npm pack`, we can now use `npm_package.pack` rule of bazel, since the windows os issue has been fixed here https://github.com/bazelbuild/rules_nodejs/commit/bc36519 PR Close #39636 14 December 2020, 19:29:33 UTC
68cf012 JiaLiPassion 11 November 2020, 17:35:13 UTC build: update bazel rules_nodejs to version 2.3.1 (#39636) Update the version `rules_nodejs` to 2.3.1, so the `npm_package.pack` rule can now work on windows os. PR Close #39636 14 December 2020, 19:29:33 UTC
028e4f7 Alex Rickabaugh 11 December 2020, 19:01:51 UTC fix(language-service): force compileNonExportedClasses: false in LS (#40092) Projects opened in the LS are often larger in scope than the compilation units seen by the compiler when actually building. For example, in the LS it's not uncommon for the project to include both application as well as test files. This can create issues when the combination of files results in errors that are not otherwise present - for example, if test files have inline NgModules that re-declare components (a common Angular pattern). Such code is valid when compiling the app only (test files are excluded, so only one declaration is seen by the compiler) or when compiling tests only (since tests run in JIT mode and are not seen by the AOT compiler), but when both sets of files are mixed into a single compilation unit, the compiler sees the double declaration as an error. This commit attempts to mitigate the problem by forcing the compiler flag `compileNonExportedClasses` to `false` in a LS context. When tests contain duplicate declarations, often such declarations are inline in specs and not exported from the top level, so this flag can be used to greatly improve the IDE experience. PR Close #40092 14 December 2020, 18:09:21 UTC
2b74a05 Andrew Scott 04 November 2020, 00:49:30 UTC refactor(compiler-cli): Enable pipe information when checkTypeOfPipes=false (#39555) When `checkTypeOfPipes` is set to `false`, the configuration is meant to ignore the signature of the pipe's `transform` method for diagnostics. However, we still should produce some information about the pipe for the `TemplateTypeChecker`. This change refactors the returned symbol for pipes so that it also includes information about the pipe's class instance as it appears in the TCB. PR Close #39555 12 December 2020, 00:19:15 UTC
6e4e68c Andrew Scott 10 December 2020, 19:13:11 UTC refactor(compiler-cli): Add flag to TCB for non-diagnostic requests (#40071) The TCB utility functions used to find nodes in the TCB are currently configured to ignore results when an ignore marker is found. However, these ignore markers are only meant to affect diagnostics requests. The Language Service may have a need to find nodes with diagnostic ignore markers. The most common example of this would be finding references for generic directives. The reference appears to the generic directive's class appears on the type ctor in the TCB, which is ignored for diagnostic purposes. These functions should only skip results when the request is in the context of a larger request for _diagnostics_. In all other cases, we should get matches, even if a diagnostic ignore marker is encountered. PR Close #40071 11 December 2020, 21:56:35 UTC
8171876 Andrew Scott 10 December 2020, 19:14:44 UTC refactor(compiler-cli): rename ignore marker and helpers to be more clear (#40071) The ignore marker is only used to ignore certain nodes in the TCB for the purposes of diagnostics. The marker itself has been renamed as well as the helper function to see if the marker is present. Both now indicate that the marker is specifically for diagnostics. PR Close #40071 11 December 2020, 21:56:35 UTC
b08fd0c Alexey Elin 10 December 2020, 18:46:09 UTC docs: remove unused CSS rules (#40069) Removed rules don't affect their component views. The reason - the templates don't contain elements to which that rules are applied. See https://angular.io/guide/view-encapsulation for more details PR Close #40069 10 December 2020, 22:30:17 UTC
91fb830 Alexey Elin 10 December 2020, 14:36:29 UTC docs: remove prefixed border-radius related properties (#40066) Angular has stopped to support browser that requires these CSS properties. All supported browsers support standard CSS properties: * border-radius * border-bottom-left-radius * border-bottom-right-radius PR Close #40066 10 December 2020, 22:29:39 UTC
fea9505 George Kalpakas 10 December 2020, 10:14:30 UTC build(docs-infra): upgrade cli command docs sources to f6f0cde41 (#40064) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/416dff296...f6f0cde41): **Modified** - help/build.json - help/e2e.json - help/extract-i18n.json - help/serve.json - help/test.json PR Close #40064 10 December 2020, 22:19:29 UTC
79a42d9 Amadou Sall 10 December 2020, 08:47:11 UTC docs: update the link to the TypeScript documentation for strict mode (#40063) PR Close #40063 10 December 2020, 22:16:23 UTC
19b9ec8 Miloš Lapiš 10 December 2020, 00:47:24 UTC docs(router): Correct equivalent for 'enabled' initial navigation (#40061) With regard to the code in `router_module.ts`, the correct equivalent for `enabled` should be` enabledBlocking` and not `enabledNonBlocking`. PR Close #40061 10 December 2020, 22:07:42 UTC
3e68b79 Jessica Janiuk 09 December 2020, 23:15:41 UTC Revert "Revert "ci: update pullapprove config to add comp labels"" (#40059) This reverts commit c88e8141abb411bd955e29f2670b9e2c204cce1a. This reverts the revert that undid the doing of the pull approve approval. PR Close #40059 10 December 2020, 21:51:09 UTC
2a38641 Keen Yee Liau 09 December 2020, 23:14:58 UTC build(language-service): install @angular/language-service in root node_modules (#40058) https://github.com/angular/vscode-ng-language-service/pull/994 changed the structure of the vscode-ng-language-service repository to be a monorepo, so @angular/language-service should be installed in root node_modules. PR Close #40058 10 December 2020, 21:48:04 UTC
0817758 Pete Bacon Darwin 09 December 2020, 20:54:24 UTC feat(docs-infra): add no upcoming events message (#40055) This commit adds a message that is displayed instead of the events table if there are no upcoming events. Fixes #40052 PR Close #40055 10 December 2020, 21:46:32 UTC
973f797 Andrew Scott 09 December 2020, 18:09:55 UTC feat(language-service): enable get references for directive and component from template (#40054) This commit adds the ability to find references for a directive or component from within a component template. That is, you can find component references from the element tag `<my-c|omp></my-comp>` (where `|` is the cursor position) as well as find references for directives that match a given attribute `<div d|ir></div>`. PR Close #40054 10 December 2020, 21:45:40 UTC
1bf1b68 Andrew Scott 09 December 2020, 17:39:33 UTC fix(language-service): Prevent matching nodes after finding a keySpan (#40047) If we've already identified that we are within a `keySpan` of a node, we exit the visitor logic early. It can be the case that we have two nodes which technically match a given location when the end span of one node touches the start of the keySpan for the candidate node. Because our `isWithin` logic is inclusive on both ends, we can match both nodes. This change exits the visitor logic once we've identified a node where the position is within its `keySpan`. PR Close #40047 10 December 2020, 21:44:18 UTC
371a2c8 Andrew Scott 09 December 2020, 17:31:17 UTC refactor(language-service): adjust hybrid visitor to not throw away valid results (#40047) The visitor has a check in it with the goal of preventing the structural directive parent elements from matching when we have already found the candidate we want. However, this code did not check to ensure that it was looking at the correct type of node for this case and was evaluating this logic in places it shouldn't. This special check can be more easily done by simply not traversing the template children if we've already found a candidate on the template node itself. PR Close #40047 10 December 2020, 21:44:18 UTC
b4b21bd George Kalpakas 10 December 2020, 17:13:33 UTC fix(upgrade): fix HMR for hybrid applications (#40045) Previously, trying to apply a change via Hot Module Replacement (HMR) in a hybrid app would result in an error. This was caused by not having the AngularJS app destroyed and thus trying to bootstrap an AngularJS app on the same element twice. This commit fixes HMR for hybrid apps by ensuring the AngularJS app is destroyed when the Angular `PlatformRef` is [destroyed][1] in the [`module.hot.dispose()` callback][2]. NOTE: For "ngUpgradeLite" apps (i.e. those using `downgradeModule()`), HMR will only work if the downgraded module has been bootstrapped and there is at least one Angular component present on the page. The is due to a combination of two facts: - The logic for setting up the listener that destroys the AngularJS app depends on the downgraded module's `NgModuleRef`, which is only available after the module has been bootstrapped. - The [HMR dispose logic][3] depends on having an Angular element (identified by the auto-geenrated `ng-version` attribute) present in the DOM in order to retrieve the Angular `PlatformRef`. [1]: https://github.com/angular/angular-cli/blob/205ea2b638f154291993bfd9e065cd66ff20503/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts#L75 [2]: https://github.com/angular/angular-cli/blob/205ea2b638f154291993bfd9e065cd66ff205033/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts#L31 [3]: https://github.com/angular/angular-cli/blob/205ea2b638f154291993bfd9e065cd66ff205033/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts#L116 Fixes #39935 PR Close #40045 10 December 2020, 21:40:53 UTC
d082221 George Kalpakas 10 December 2020, 17:13:32 UTC refactor(upgrade): create a helper for cleaning jqLite/jQuery data (#40045) This commit moves the code for cleaning jqLite/jQuery data on an element to a re-usable helper function. This way it is easier to keep the code consistent across all places where we need to clean data (now and in the future). PR Close #40045 10 December 2020, 21:40:53 UTC
61376d5 George Kalpakas 10 December 2020, 17:13:31 UTC refactor(upgrade): remove unused variables (#40045) This commit removes a couple of unused variables. PR Close #40045 10 December 2020, 21:40:53 UTC
76e3de2 Alexey Elin 09 December 2020, 09:46:26 UTC docs: remove -webkit-box-sizing and -moz-box-sizing (#40039) Angular has stopped to support browser that requires these CSS properties. All supported browsers support standard box-sizing CSS property PR Close #40039 10 December 2020, 21:38:19 UTC
1f73af7 JoostK 05 December 2020, 15:30:32 UTC refactor(compiler-cli): use `ngDevMode` guard for `setClassMetadata` call (#39987) Prior to this change, the `setClassMetadata` call would be invoked inside of an IIFE that was marked as pure. This allows the call to be tree-shaken away in production builds, as the `setClassMetadata` call is only present to make the original class metadata available to the testing infrastructure. The pure marker is problematic, though, as the `setClassMetadata` call does in fact have the side-effect of assigning the metadata into class properties. This has worked under the assumption that only build optimization tools perform tree-shaking, however modern bundlers are also able to elide calls that have been marked pure so this assumption does no longer hold. Instead, an `ngDevMode` guard is used which still allows the call to be elided but only by tooling that is configured to consider `ngDevMode` as constant `false` value. PR Close #39987 10 December 2020, 21:23:13 UTC
85b07ad Teri Glover 24 November 2020, 20:31:18 UTC docs: add Teri Glover to contributor file (#39830) PR Close #39830 10 December 2020, 21:22:16 UTC
112324a Andrew Scott 16 November 2020, 23:41:39 UTC feat(router): add `relativeTo` as an input to `routerLink` (#39720) Allow configuration of `relativeTo` in the `routerLink` directive. This is related to the clearing of auxiliary routes, where you need to use `relativeTo: route.parent` in order to clear it from the activated auxiliary component itself. This is because `relativeTo: route` will consume the segment that we're trying to clear, so there is really no way to do this with routerLink at the moment. Related issue: #13523 Related (internal link): https://yaqs.corp.google.com/eng/q/5999443644645376 PR Close #39720 10 December 2020, 19:21:00 UTC
dc6d40e Kristiyan Kostadinov 24 November 2020, 17:50:47 UTC fix(compiler): handle strings inside bindings that contain binding characters (#39826) Currently the compiler treats something like `{{ '{{a}}' }}` as a nested binding and throws an error, because it doesn't account for quotes when it looks for binding characters. These changes add a bit of logic to skip over text inside quotes when parsing. Fixes #39601. PR Close #39826 10 December 2020, 19:11:21 UTC
93a8326 Alex Rickabaugh 17 November 2020, 22:43:40 UTC feat(language-service): autocompletion within expression contexts (#39727) This commit adds support to the Language Service for autocompletion within expression contexts. Specifically, this is auto completion of property reads and method calls, both in normal and safe-navigational forms. PR Close #39727 10 December 2020, 19:09:53 UTC
269a775 Andrew Scott 17 November 2020, 21:00:22 UTC refactor(compiler-cli): produce binding access when checkTypeOfOutputEvents is false (#39515) When `checkTypeOfOutputEvents` is `false`, we still need to produce the access to the `EventEmitter` so the Language Service can still get the type information about the field. That is, in a template `<div (output)="handle($event)"`, we still want to be able to grab information when the cursor is inside the "output" parens. The flag is intended only to affect whether the compiler produces diagnostics for the inferred type of the `$event`. PR Close #39515 10 December 2020, 19:04:46 UTC
702d6bf Andrew Scott 17 November 2020, 21:00:11 UTC refactor(compiler-cli): use keySpan for output event lookup (#39515) PR #39665 added the `keySpan` to the output field access so we no longer need to get there from the call expression and can instead just find the node we want directly. PR Close #39515 10 December 2020, 19:04:46 UTC
29298f4 Amadou Sall 23 May 2020, 19:28:59 UTC docs: fix the code sample displayed in the "reusable animations" guide (#37262) Currently the code sample displayed in this guide is not a valid. The `trigger` is directly used in the `@Component` decorator. It should instead be in the `animations` array of the `@Component` decorator. PR Close #37262 10 December 2020, 19:03:32 UTC
d39d64c Jessica Janiuk 09 December 2020, 19:54:28 UTC Revert "ci: update pullapprove config to add comp labels" (#40053) This reverts commit 9f8ccd577f481a3ca4508287ec06cdf863561f69. The PullApprove labeling is unfortunately removing labels rather than adding them. PR Close #40053 09 December 2020, 20:06:26 UTC
5942fb8 Joey Perrott 09 December 2020, 19:57:55 UTC release: cut the v11.1.0-next.2 release 09 December 2020, 19:57:55 UTC
85760cb Pete Bacon Darwin 09 December 2020, 12:52:04 UTC test(compiler-cli): fix and re-enable compliance source-map tests (#40040) These tests started failing because they had type-check errors in their templates, and a recent commit turned on full template type-checking by default.\ This commit fixes those templates and updates the expected files as necessary. PR Close #40040 09 December 2020, 17:21:32 UTC
42d478b Julien 09 December 2020, 10:37:06 UTC docs(common): use table layout for Pre-defined format options (#40036) easier to read PR Close #40036 09 December 2020, 17:11:03 UTC
13126d2 George Kalpakas 09 December 2020, 10:11:40 UTC build(docs-infra): upgrade cli command docs sources to 416dff296 (#40034) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/099ce69de...416dff296): **Modified** - help/add.json - help/build.json - help/config.json - help/doc.json - help/e2e.json - help/extract-i18n.json - help/generate.json - help/new.json - help/serve.json - help/test.json - help/update.json PR Close #40034 09 December 2020, 17:06:52 UTC
e39f923 Jessica Janiuk 03 December 2020, 22:06:38 UTC ci: update pullapprove config to add comp labels (#39962) This adds comp labels to each group defined in the yml file. PR Close #39962 09 December 2020, 17:05:46 UTC
13dfef1 Alexey Elin 01 December 2020, 19:33:55 UTC docs: remove cursor: hand (#39918) PR Close #39918 09 December 2020, 17:04:54 UTC
fc323d0 Aristeidis Bampakos 04 November 2020, 09:15:18 UTC docs: fix typos in the Style Precedence guide (#39560) PR Close #39560 09 December 2020, 17:02:14 UTC
1c193af Christoph Guttandin 22 October 2020, 14:38:46 UTC docs: add angular-prerender to resources.json (#39387) PR Close #39387 09 December 2020, 17:01:23 UTC
bb3f207 nseabourn 05 May 2020, 01:35:11 UTC docs: add reason to use Angular in README (#36927) PR Close #36927 09 December 2020, 16:58:10 UTC
cfb094d Andrew Scott 09 December 2020, 02:36:43 UTC test(compiler-cli): temporary disable source mapping tests which have errors (#40033) These tests do not pass the typecheck phase of the compiler and fail. The option to disable typechecking was removed recently so these tests need to be fixed to be valid applications. PR Close #40033 09 December 2020, 03:17:22 UTC
ca08625 Benjamin Kindle 02 December 2020, 22:17:08 UTC fix(animations): implement getPosition in browser animation builder (#39983) Forward `getPosition` to `animation_group_player`. PR Close #39983 09 December 2020, 00:24:41 UTC
6cc9ab1 Andrew Scott 05 December 2020, 00:39:12 UTC refactor(compiler-cli): remove internal only flag to disable type checking (#40013) A couple reasons to justify removing the flag: * It adds code to the compiler that is only meant to support test cases and not any production. We should avoid code in that's only meant to support tests. * The flag enables writing tests that do not mimic real-world behavior because they allow invalid applications PR Close #40013 09 December 2020, 00:19:07 UTC
2f8a420 Andrew Scott 17 October 2020, 00:17:15 UTC refactor(compiler-cli): Return addEventListener symbol for native output bindings (#39312) Rather than returning `null`, we can provide some useful information to the Language Service by returning a symbol for the `addEventListener` function call when the consumer of a binding as an element. PR Close #39312 09 December 2020, 00:18:24 UTC
634c393 Joey Perrott 08 December 2020, 17:12:11 UTC fix(dev-infra): correct the environment variable to skip husky during merge (#40025) With the migration to husky@5, the environment variable used to skip husky changed from `HUSKY_SKIP_HOOKS` to `HUSKY`. To continue skipping husky during the merge process as expected, the environment variable used is updated. PR Close #40025 09 December 2020, 00:16:43 UTC
61b9adb devpato 08 December 2020, 20:58:12 UTC docs: add Pato Vargas to GDE resources (#40029) PR Close #40029 09 December 2020, 00:14:32 UTC
55c21fa Andrew Scott 08 December 2020, 19:07:42 UTC ci: add atscott to language-service approvers (#40027) Add myself (atscott) to the list of approvers for language-service PRs. PR Close #40027 08 December 2020, 20:09:23 UTC
c051693 Joey Perrott 07 December 2020, 18:57:43 UTC build: exclude build-worker file from formatting (#40012) Exclude the generated build-worker.js file from formatting as it is generated and not subject to formatting restrictions. PR Close #40012 08 December 2020, 20:06:53 UTC
c043ecf Joey Perrott 07 December 2020, 18:52:40 UTC fix(dev-infra): allow build-worker to be used in forked process (#40012) Generates a local copy of the build-worker file to allow it to be loaded at runtime in a forked process. PR Close #40012 08 December 2020, 20:06:51 UTC
74e42cf Christoph Guttandin 05 December 2020, 16:37:03 UTC fix(service-worker): handle error with ErrorHandler (#39990) Errors thrown by calling serviceWorker.register() are now passed to the global ErrorHandler. Fixes #39913 PR Close #39990 08 December 2020, 20:03:27 UTC
6dc43a4 George Kalpakas 07 December 2020, 17:55:34 UTC fix(upgrade): avoid memory leak when removing downgraded components (#39965) Previously, due to the way the AngularJS and Angular clean-up processes interfere with each other when removing an AngularJS element that contains a downgraded Angular component, the data associated with the host element of the downgraded component was not removed. This data was kept in an internal AngularJS cache, which prevented the element and component instance from being garbage-collected, leading to memory leaks. This commit fixes this by ensuring the element data is explicitly removed when cleaning up a downgraded component. NOTE: This is essentially the equivalent of #26209 but for downgraded (instead of upgraded) components. Fixes #39911 Closes #39921 PR Close #39965 08 December 2020, 20:02:48 UTC
988b1e3 George Kalpakas 07 December 2020, 17:55:34 UTC refactor(upgrade): remove unused parameters/properties/variables (#39965) This commit removes some unused parameters, properties and variables in various `@angular/upgrade` functions. PR Close #39965 08 December 2020, 20:02:46 UTC
e692884 JoostK 05 December 2020, 13:35:25 UTC refactor(compiler-cli): reformat directive/pipe metadata extraction (#39961) The prior usage of a ternary expression caused the code to be formatted in a weird way, so this commit replaces the ternary with an `if` statement. PR Close #39961 08 December 2020, 20:02:00 UTC
dd8a318 JoostK 05 December 2020, 13:30:45 UTC refactor(compiler-cli): extract parsing of interpolation config (#39961) Prior to this change the interpolation config value was cast to `[string, string]` without checking whether there really were two string values available. This commit extracts the logic of parsing the interpolation config into a separate function and adds a check that the array contains exactly two strings. PR Close #39961 08 December 2020, 20:01:59 UTC
c0bccc3 JoostK 03 December 2020, 22:07:24 UTC refactor(compiler-cli): carry type information into AST value types (#39961) This change allows the `AstObject` and `AstValue` types to provide their represented type as a generic type argument, which is helpful for documentation and discoverability purposes. PR Close #39961 08 December 2020, 20:01:57 UTC
5fa026f JoostK 03 December 2020, 22:03:23 UTC refactor(compiler): add type information to `DefinitionMap` (#39961) This allows the code generation to correspond with a type, which is helpful for documentation and discoverability purposes. This does not offer any type-safety with respect to the actually generated code. PR Close #39961 08 December 2020, 20:01:56 UTC
5848439 Daniel Eisterhold 17 March 2020, 13:42:58 UTC docs(platform-browser): fix spelling of deserialized (#36102) PR Close #36102 08 December 2020, 20:01:04 UTC
bc6e669 Misko Hevery 08 December 2020, 19:06:22 UTC Revert "build: update bazel rules_nodejs to version 2.3.1 (#39636)" This reverts commit eee878c00e01e6e4766616903b83dcea4a768f30. 08 December 2020, 19:06:22 UTC
73e15bd Misko Hevery 08 December 2020, 19:06:17 UTC Revert "build: update to use npm_package.pack rule (#39636)" This reverts commit fbfc7dff48cc9c63d3dd44934c7f17f8d0ba47f4. 08 December 2020, 19:06:17 UTC
5a2a907 Kalle Järvenpää 17 May 2020, 17:04:45 UTC docs(animations): a small typo (#37164) Removed two extra closing parentheses in docs. PR Close #37164 08 December 2020, 17:22:22 UTC
fbfc7df JiaLiPassion 11 November 2020, 17:42:36 UTC build: update to use npm_package.pack rule (#39636) Remove the work around solution for the `npm pack`, we can now use `npm_package.pack` rule of bazel, since the windows os issue has been fixed here https://github.com/bazelbuild/rules_nodejs/commit/bc36519 PR Close #39636 08 December 2020, 17:15:49 UTC
eee878c JiaLiPassion 11 November 2020, 17:35:13 UTC build: update bazel rules_nodejs to version 2.3.1 (#39636) Update the version `rules_nodejs` to 2.3.1, so the `npm_package.pack` rule can now work on windows os. PR Close #39636 08 December 2020, 17:15:46 UTC
a694838 Andrew Scott 30 October 2020, 23:27:22 UTC refactor(compiler-cli): TemplateTypeChecker with checkTypeOfAttributes=false should still work (#39537) When the compiler option `checkTypeOfAttributes` is `false`, we should still be able to produce type information from the `TemplateTypeChecker`. The current behavior ignores all attributes that map to directive inputs. This commit includes those attribute bindings in the TCB but adds the "ignore for diagnostics" marker so they do not produce errors. This way, consumers of the TTC (the Language Service) can still get valid information about these attributes even when the user has configured the compiler to not produce diagnostics/errors for them. PR Close #39537 08 December 2020, 17:14:27 UTC
86fdc77 Pete Bacon Darwin 08 December 2020, 10:09:25 UTC docs: replace image with one containing correct text (#40022) The previous image referred to "Mr IQ". The example application (and the content of the referring guide) actually uses "Dr IQ". Closes #34823 PR Close #40022 08 December 2020, 17:12:01 UTC
2ffd739 m-ahmadi 22 May 2020, 01:59:50 UTC docs: rephrased two sentences (#37230) This commit rephrases a confusing sentence, and also adds more info to another sentence to be more understandable. PR Close #37230 08 December 2020, 17:02:51 UTC
f06a50f Pete Bacon Darwin 08 December 2020, 10:45:56 UTC docs: fix reference to `routes` array in TOH tutorial (#40023) The previous tutorial content referred to a `Routes` member of `AppRoutingModule`, which is not correct. Instead there is a `routes` variable that is passed to the `forRoot()` method when configuring the `AppRoutingModule`. Replaces #36583 PR Close #40023 08 December 2020, 16:56:40 UTC
8d30551 George Kalpakas 08 December 2020, 10:03:29 UTC build(docs-infra): upgrade cli command docs sources to 099ce69de (#40020) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/2eb97bf5b...099ce69de): **Modified** - help/build.json - help/generate.json - help/serve.json PR Close #40020 08 December 2020, 16:54:39 UTC
25e3dc5 Joey Perrott 30 November 2020, 22:53:05 UTC refactor(dev-infra): separate retrieving targeted branches from printing them (#39897) Separate retrieving targeted branches from printing the branches to allow for other tools to better integrate with the results. PR Close #39897 08 December 2020, 16:54:08 UTC
2292554 Panagiotis Kyriazopoulos 13 October 2020, 17:11:09 UTC docs(core): fix typos in the "View Encapsulation" guide (#39246) 1. In line 25 changed the word "components" to "component's". 2. In line 66 changed the phrase "you never refer to them" to "you should never refer to them". 3. Appended the paragraph containing the above phrase in a `div` with the class `alert is-helpful`. PR Close #39246 08 December 2020, 16:53:36 UTC
f408af3 ankitkaushik24 13 October 2020, 16:15:06 UTC docs: removes the outdated content (#39242) Remove the statements where mentions the component in the `entryComponents` array inside `NgModule` metadata. This is not required since Angular version 9. PR Close #39242 08 December 2020, 16:53:00 UTC
e8d2348 profanis 05 September 2020, 16:09:00 UTC docs: how to create a custom Attribute decorator in a child component and use it from a parent component (#38721) Aside from using the @input() decorator, we can use the @Attrbitute decorator too. Of course, those two are different and support different causes. I expected to see a working example on the Attribute Bindings section, but I didn't find one. This PR depicts the usage of the Attribute decorator between two components PR Close #38721 08 December 2020, 16:52:25 UTC
6e7a57f Ajit Singh 09 March 2020, 11:33:50 UTC docs: add note that sting based lazy loading is opt-in (#35956) after angular version 8 string based lazy loading is not activated by default it is an opt in behaviour in which you have to add the lazy loaded routes in the tsconfig file for compilation. Aded a note too that it will be removed in version 11. Fixes #35652 PR Close #35956 08 December 2020, 16:47:39 UTC
3ec2807 JoostK 05 December 2020, 15:48:04 UTC refactor(compiler-cli): add script to update all golden partial files (#39989) The golden files for the partial compliance tests need to be updated with individual Bazel run invocations, which is not very ergonomic when a large number of golden files need to updated. This commit adds a script to query the Bazel targets that update the goldens and then runs those targets sequentially. PR Close #39989 08 December 2020, 00:21:42 UTC
b8714c3 Pete Bacon Darwin 02 December 2020, 21:42:58 UTC test(compiler-cli): add source-map compliance tests for inline-templates (#39939) This test migrates source-mapping tests to the new compliance test framework. The original tests are found in the file at: `packages/compiler-cli/test/ngtsc/template_mapping_spec.ts`. These new tests also check the mappings resulting from partial compilation followed by linking, after flattening the pair of source-maps that each process generates. Note that there are some differences between the mappings for full compile and linked compile modes, due to how TypeScript and Babel use source-span information on AST nodes. To accommodate this, there are two expectation files for most of these source files. PR Close #39939 08 December 2020, 00:21:07 UTC
back to top