Revision 112fc894a7c49e6435f91faa1cebfd425e6f3ace authored by David Howells on 27 January 2015, 15:18:39 UTC, committed by Al Viro on 20 February 2015, 09:56:43 UTC
Code that does this: if (!(d_unhashed(dentry) && dentry->d_inode)) { ... simple_unlink(parent->d_inode, dentry); } is broken because: !(d_unhashed(dentry) && dentry->d_inode) is equivalent to: !d_unhashed(dentry) || !dentry->d_inode so it is possible to get into simple_unlink() with dentry->d_inode == NULL. simple_unlink(), however, assumes dentry->d_inode cannot be NULL. I think that what was meant is this: !d_unhashed(dentry) && dentry->d_inode and that the logical-not operator or the final close-bracket was misplaced. Signed-off-by: David Howells <dhowells@redhat.com> cc: Joel Becker <joel.becker@oracle.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent a457ac2
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 142 bytes |
baboon.c | -rw-r--r-- | 2.4 KB |
config.c | -rw-r--r-- | 28.4 KB |
iop.c | -rw-r--r-- | 17.5 KB |
mac_penguin.S | -rw-r--r-- | 11.7 KB |
macboing.c | -rw-r--r-- | 8.2 KB |
macints.c | -rw-r--r-- | 8.2 KB |
misc.c | -rw-r--r-- | 17.2 KB |
oss.c | -rw-r--r-- | 5.3 KB |
psc.c | -rw-r--r-- | 4.1 KB |
via.c | -rw-r--r-- | 16.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...