Revision 112fc894a7c49e6435f91faa1cebfd425e6f3ace authored by David Howells on 27 January 2015, 15:18:39 UTC, committed by Al Viro on 20 February 2015, 09:56:43 UTC
Code that does this:
if (!(d_unhashed(dentry) && dentry->d_inode)) {
...
simple_unlink(parent->d_inode, dentry);
}
is broken because:
!(d_unhashed(dentry) && dentry->d_inode)
is equivalent to:
!d_unhashed(dentry) || !dentry->d_inode
so it is possible to get into simple_unlink() with dentry->d_inode == NULL.
simple_unlink(), however, assumes dentry->d_inode cannot be NULL.
I think that what was meant is this:
!d_unhashed(dentry) && dentry->d_inode
and that the logical-not operator or the final close-bracket was misplaced.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent a457ac2
| File | Mode | Size |
|---|---|---|
| perf | ||
| .gitignore | -rw-r--r-- | 12 bytes |
| Makefile | -rw-r--r-- | 881 bytes |
| asm-offsets.c | -rw-r--r-- | 242 bytes |
| cachepart.c | -rw-r--r-- | 3.5 KB |
| clock.c | -rw-r--r-- | 2.6 KB |
| core_reg.c | -rw-r--r-- | 3.0 KB |
| da.c | -rw-r--r-- | 470 bytes |
| devtree.c | -rw-r--r-- | 1.7 KB |
| dma.c | -rw-r--r-- | 11.8 KB |
| ftrace.c | -rw-r--r-- | 3.0 KB |
| ftrace_stub.S | -rw-r--r-- | 1.4 KB |
| head.S | -rw-r--r-- | 1.7 KB |
| irq.c | -rw-r--r-- | 6.7 KB |
| kick.c | -rw-r--r-- | 3.1 KB |
| machines.c | -rw-r--r-- | 359 bytes |
| metag_ksyms.c | -rw-r--r-- | 1.1 KB |
| module.c | -rw-r--r-- | 7.8 KB |
| perf_callchain.c | -rw-r--r-- | 2.1 KB |
| process.c | -rw-r--r-- | 10.4 KB |
| ptrace.c | -rw-r--r-- | 10.2 KB |
| setup.c | -rw-r--r-- | 15.6 KB |
| signal.c | -rw-r--r-- | 8.4 KB |
| smp.c | -rw-r--r-- | 15.5 KB |
| stacktrace.c | -rw-r--r-- | 4.4 KB |
| sys_metag.c | -rw-r--r-- | 4.5 KB |
| tbiunexp.S | -rw-r--r-- | 789 bytes |
| tcm.c | -rw-r--r-- | 3.3 KB |
| time.c | -rw-r--r-- | 517 bytes |
| topology.c | -rw-r--r-- | 1.7 KB |
| traps.c | -rw-r--r-- | 24.4 KB |
| user_gateway.S | -rw-r--r-- | 2.8 KB |
| vmlinux.lds.S | -rw-r--r-- | 1.3 KB |
Computing file changes ...
