Skip to main content

Browse the archive

Revision 112fc894a7c49e6435f91faa1cebfd425e6f3ace authored by David Howells on 27 January 2015, 15:18:39 UTC, committed by Al Viro on 20 February 2015, 09:56:43 UTC 
configfs: Fix potential NULL d_inode dereference
 
Code that does this:

		if (!(d_unhashed(dentry) && dentry->d_inode)) {
			...
			simple_unlink(parent->d_inode, dentry);
		}

is broken because:

    !(d_unhashed(dentry) && dentry->d_inode)

is equivalent to:

    !d_unhashed(dentry) || !dentry->d_inode

so it is possible to get into simple_unlink() with dentry->d_inode == NULL.

simple_unlink(), however, assumes dentry->d_inode cannot be NULL.

I think that what was meant is this:

    !d_unhashed(dentry) && dentry->d_inode

and that the logical-not operator or the final close-bracket was misplaced.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent a457ac2
Raw File
Makefile 
#
# Makefile for TBX library files..
#

asflags-y		+= -mmetac=2.1 -Wa,-mfpu=metac21 -mdsp
asflags-$(CONFIG_SMP)	+= -DTBX_PERCPU_SP_SAVE

ccflags-y		+= -mmetac=2.1

lib-y			+= tbicore.o
lib-y			+= tbictx.o
lib-y			+= tbidefr.o
lib-y			+= tbilogf.o
lib-y			+= tbipcx.o
lib-y			+= tbiroot.o
lib-y			+= tbisoft.o
lib-y			+= tbistring.o
lib-y			+= tbitimer.o

lib-$(CONFIG_METAG_DSP)	+= tbidspram.o
lib-$(CONFIG_METAG_FPU)	+= tbictxfpu.o
back to top