Revision 112fc894a7c49e6435f91faa1cebfd425e6f3ace authored by David Howells on 27 January 2015, 15:18:39 UTC, committed by Al Viro on 20 February 2015, 09:56:43 UTC
Code that does this:
if (!(d_unhashed(dentry) && dentry->d_inode)) {
...
simple_unlink(parent->d_inode, dentry);
}
is broken because:
!(d_unhashed(dentry) && dentry->d_inode)
is equivalent to:
!d_unhashed(dentry) || !dentry->d_inode
so it is possible to get into simple_unlink() with dentry->d_inode == NULL.
simple_unlink(), however, assumes dentry->d_inode cannot be NULL.
I think that what was meant is this:
!d_unhashed(dentry) && dentry->d_inode
and that the logical-not operator or the final close-bracket was misplaced.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent a457ac2
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 442 bytes |
| ashldi3.c | -rw-r--r-- | 474 bytes |
| ashrdi3.c | -rw-r--r-- | 498 bytes |
| cmpdi2.c | -rw-r--r-- | 434 bytes |
| divsi3.S | -rw-r--r-- | 1.7 KB |
| fastcopy.S | -rw-r--r-- | 20.3 KB |
| libgcc.h | -rw-r--r-- | 724 bytes |
| lshrdi3.c | -rw-r--r-- | 476 bytes |
| memcpy.c | -rw-r--r-- | 4.9 KB |
| memmove.c | -rw-r--r-- | 5.3 KB |
| memset.c | -rw-r--r-- | 2.4 KB |
| modsi3.S | -rw-r--r-- | 1.7 KB |
| muldi3.c | -rw-r--r-- | 1.6 KB |
| mulsi3.S | -rw-r--r-- | 839 bytes |
| uaccess_old.S | -rw-r--r-- | 5.2 KB |
| ucmpdi2.c | -rw-r--r-- | 502 bytes |
| udivsi3.S | -rw-r--r-- | 1.9 KB |
| umodsi3.S | -rw-r--r-- | 1.9 KB |
Computing file changes ...
