Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 May 2024, 11:00:25 UTC
Revision 114279be2120a916e8a04feeb2ac976a10016f2f authored by Oleg Nesterov on 30 November 2010, 19:56:02 UTC, committed by Linus Torvalds on 01 December 2010, 01:56:38 UTC 
exec: copy-and-paste the fixes into compat_do_execve() paths
 
Note: this patch targets 2.6.37 and tries to be as simple as possible.
That is why it adds more copy-and-paste horror into fs/compat.c and
uglifies fs/exec.c, this will be cleanuped later.

compat_copy_strings() plays with bprm->vma/mm directly and thus has
two problems: it lacks the RLIMIT_STACK check and argv/envp memory
is not visible to oom killer.

Export acct_arg_size() and get_arg_page(), change compat_copy_strings()
to use get_arg_page(), change compat_do_execve() to do acct_arg_size(0)
as do_execve() does.

Add the fatal_signal_pending/cond_resched checks into compat_count() and
compat_copy_strings(), this matches the code in fs/exec.c and certainly
makes sense.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 3c77f84
History
Tip revision: 114279be2120a916e8a04feeb2ac976a10016f2f authored by Oleg Nesterov on 30 November 2010, 19:56:02 UTC
exec: copy-and-paste the fixes into compat_do_execve() paths
Tip revision: 114279b
File Mode Size
firewire
perf
usb
back to top