https://github.com/git/git
Revision 1389d9ddaa68a4cbf5018d88f971b9bbb7aaa3c9 authored by Junio C Hamano on 06 January 2007, 10:16:19 UTC, committed by Junio C Hamano on 07 January 2007, 06:57:34 UTC
The logic in an earlier round to detect reflog entries that
point at a broken commit was not sufficient.  Just like we do
not trust presense of a commit during pack transfer (we trust
only our refs), we should not trust a commit's presense, even if
the tree of that commit is complete.

A repository that had reflog enabled on some of the refs that
was rewound and then run git-repack or git-prune from older
versions of git can have reflog entries that point at a commit
that still exist but lack commits (or trees and blobs needed for
that commit) between it and some commit that is reachable from
one of the refs.

This revamps the logic -- the definition of "broken commit"
becomes: a commit that is not reachable from any of the refs and
there is a missing object among the commit, tree, or blob
objects reachable from it that is not reachable from any of the
refs.  Entries in the reflog that refer to such a commit are
expired.

Since this computation involves traversing all the reachable
objects, i.e. it has the same cost as 'git prune', it is enabled
only when a new option --fix-stale.  Fortunately, once this is
run, we should not have to ever worry about missing objects,
because the current prune and pack-objects know about reflogs
and protect objects referred by them.

Unfortunately, this will be absolutely necessary to help people
migrate to the newer prune and repack.

Signed-off-by: Junio C Hamano <junkio@cox.net>
1 parent 9442147
History
Tip revision: 1389d9ddaa68a4cbf5018d88f971b9bbb7aaa3c9 authored by Junio C Hamano on 06 January 2007, 10:16:19 UTC
reflog expire --fix-stale
Tip revision: 1389d9d
File Mode Size
.gitignore -rw-r--r-- 47 bytes
Git.pm -rw-r--r-- 21.6 KB
Makefile -rw-r--r-- 1003 bytes
Makefile.PL -rw-r--r-- 588 bytes
private-Error.pm -rw-r--r-- 18.6 KB

back to top