Revision 1401cf600d548c72f51e20b5841c330d5c11c9e2 authored by Wei Yongjun on 20 May 2020, 03:41:16 UTC, committed by David S. Miller on 22 May 2020, 00:14:18 UTC
Convert to using IS_ERR() instead of NULL test for cpsw_ale_create() error handling. Also fix to return negative error code from this error handling case instead of 0 in. Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 3469660
checkversion.pl
#! /usr/bin/env perl
# SPDX-License-Identifier: GPL-2.0
#
# checkversion find uses of LINUX_VERSION_CODE or KERNEL_VERSION
# without including <linux/version.h>, or cases of
# including <linux/version.h> that don't need it.
# Copyright (C) 2003, Randy Dunlap <rdunlap@xenotime.net>
use strict;
$| = 1;
my $debugging;
foreach my $file (@ARGV) {
next if $file =~ "include/linux/version\.h";
# Open this file.
open( my $f, '<', $file )
or die "Can't open $file: $!\n";
# Initialize variables.
my ($fInComment, $fInString, $fUseVersion);
my $iLinuxVersion = 0;
while (<$f>) {
# Strip comments.
$fInComment && (s+^.*?\*/+ +o ? ($fInComment = 0) : next);
m+/\*+o && (s+/\*.*?\*/+ +go, (s+/\*.*$+ +o && ($fInComment = 1)));
# Pick up definitions.
if ( m/^\s*#/o ) {
$iLinuxVersion = $. if m/^\s*#\s*include\s*"linux\/version\.h"/o;
}
# Strip strings.
$fInString && (s+^.*?"+ +o ? ($fInString = 0) : next);
m+"+o && (s+".*?"+ +go, (s+".*$+ +o && ($fInString = 1)));
# Pick up definitions.
if ( m/^\s*#/o ) {
$iLinuxVersion = $. if m/^\s*#\s*include\s*<linux\/version\.h>/o;
}
# Look for uses: LINUX_VERSION_CODE, KERNEL_VERSION, UTS_RELEASE
if (($_ =~ /LINUX_VERSION_CODE/) || ($_ =~ /\WKERNEL_VERSION/)) {
$fUseVersion = 1;
last if $iLinuxVersion;
}
}
# Report used version IDs without include?
if ($fUseVersion && ! $iLinuxVersion) {
print "$file: $.: need linux/version.h\n";
}
# Report superfluous includes.
if ($iLinuxVersion && ! $fUseVersion) {
print "$file: $iLinuxVersion linux/version.h not needed.\n";
}
# debug: report OK results:
if ($debugging) {
if ($iLinuxVersion && $fUseVersion) {
print "$file: version use is OK ($iLinuxVersion)\n";
}
if (! $iLinuxVersion && ! $fUseVersion) {
print "$file: version use is OK (none)\n";
}
}
close($f);
}
Computing file changes ...