https://github.com/torvalds/linux
Revision 140456f994195b568ecd7fc2287a34eadffef3ca authored by Andrey Ryabinin on 17 February 2021, 14:30:04 UTC, committed by Joerg Roedel on 04 March 2021, 12:15:56 UTC
increase_address_space() calls get_zeroed_page(gfp) under spin_lock with disabled interrupts. gfp flags passed to increase_address_space() may allow sleeping, so it comes to this: BUG: sleeping function called from invalid context at mm/page_alloc.c:4342 in_atomic(): 1, irqs_disabled(): 1, pid: 21555, name: epdcbbf1qnhbsd8 Call Trace: dump_stack+0x66/0x8b ___might_sleep+0xec/0x110 __alloc_pages_nodemask+0x104/0x300 get_zeroed_page+0x15/0x40 iommu_map_page+0xdd/0x3e0 amd_iommu_map+0x50/0x70 iommu_map+0x106/0x220 vfio_iommu_type1_ioctl+0x76e/0x950 [vfio_iommu_type1] do_vfs_ioctl+0xa3/0x6f0 ksys_ioctl+0x66/0x70 __x64_sys_ioctl+0x16/0x20 do_syscall_64+0x4e/0x100 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fix this by moving get_zeroed_page() out of spin_lock/unlock section. Fixes: 754265bcab ("iommu/amd: Fix race in increase_address_space()") Signed-off-by: Andrey Ryabinin <arbn@yandex-team.com> Acked-by: Will Deacon <will@kernel.org> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210217143004.19165-1-arbn@yandex-team.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 45e606f
Tip revision: 140456f994195b568ecd7fc2287a34eadffef3ca authored by Andrey Ryabinin on 17 February 2021, 14:30:04 UTC
iommu/amd: Fix sleeping in atomic in increase_address_space()
iommu/amd: Fix sleeping in atomic in increase_address_space()
Tip revision: 140456f
File | Mode | Size |
---|---|---|
bpf | ||
cgroup | ||
configs | ||
debug | ||
dma | ||
entry | ||
events | ||
gcov | ||
irq | ||
kcsan | ||
livepatch | ||
locking | ||
power | ||
printk | ||
rcu | ||
sched | ||
time | ||
trace | ||
.gitignore | -rw-r--r-- | 71 bytes |
Kconfig.freezer | -rw-r--r-- | 92 bytes |
Kconfig.hz | -rw-r--r-- | 1.7 KB |
Kconfig.locks | -rw-r--r-- | 4.9 KB |
Kconfig.preempt | -rw-r--r-- | 3.0 KB |
Makefile | -rw-r--r-- | 5.0 KB |
acct.c | -rw-r--r-- | 15.5 KB |
async.c | -rw-r--r-- | 10.2 KB |
audit.c | -rw-r--r-- | 63.5 KB |
audit.h | -rw-r--r-- | 10.3 KB |
audit_fsnotify.c | -rw-r--r-- | 5.2 KB |
audit_tree.c | -rw-r--r-- | 25.6 KB |
audit_watch.c | -rw-r--r-- | 13.7 KB |
auditfilter.c | -rw-r--r-- | 34.1 KB |
auditsc.c | -rw-r--r-- | 71.8 KB |
backtracetest.c | -rw-r--r-- | 1.9 KB |
bounds.c | -rw-r--r-- | 751 bytes |
capability.c | -rw-r--r-- | 14.6 KB |
compat.c | -rw-r--r-- | 7.3 KB |
configs.c | -rw-r--r-- | 2.0 KB |
context_tracking.c | -rw-r--r-- | 6.4 KB |
cpu.c | -rw-r--r-- | 61.0 KB |
cpu_pm.c | -rw-r--r-- | 5.4 KB |
crash_core.c | -rw-r--r-- | 12.8 KB |
crash_dump.c | -rw-r--r-- | 1.1 KB |
cred.c | -rw-r--r-- | 23.3 KB |
delayacct.c | -rw-r--r-- | 4.7 KB |
dma.c | -rw-r--r-- | 3.3 KB |
exec_domain.c | -rw-r--r-- | 1.1 KB |
exit.c | -rw-r--r-- | 43.7 KB |
extable.c | -rw-r--r-- | 4.4 KB |
fail_function.c | -rw-r--r-- | 7.0 KB |
fork.c | -rw-r--r-- | 74.2 KB |
freezer.c | -rw-r--r-- | 4.4 KB |
futex.c | -rw-r--r-- | 109.5 KB |
gen_kheaders.sh | -rwxr-xr-x | 3.2 KB |
groups.c | -rw-r--r-- | 4.9 KB |
hung_task.c | -rw-r--r-- | 7.5 KB |
iomem.c | -rw-r--r-- | 4.7 KB |
irq_work.c | -rw-r--r-- | 4.8 KB |
jump_label.c | -rw-r--r-- | 20.9 KB |
kallsyms.c | -rw-r--r-- | 18.6 KB |
kcmp.c | -rw-r--r-- | 5.4 KB |
kcov.c | -rw-r--r-- | 27.7 KB |
kexec.c | -rw-r--r-- | 8.0 KB |
kexec_core.c | -rw-r--r-- | 31.1 KB |
kexec_elf.c | -rw-r--r-- | 11.4 KB |
kexec_file.c | -rw-r--r-- | 33.3 KB |
kexec_internal.h | -rw-r--r-- | 976 bytes |
kheaders.c | -rw-r--r-- | 1.6 KB |
kmod.c | -rw-r--r-- | 5.0 KB |
kprobes.c | -rw-r--r-- | 67.3 KB |
ksysfs.c | -rw-r--r-- | 6.3 KB |
kthread.c | -rw-r--r-- | 38.6 KB |
latencytop.c | -rw-r--r-- | 7.2 KB |
module-internal.h | -rw-r--r-- | 782 bytes |
module.c | -rw-r--r-- | 118.9 KB |
module_signature.c | -rw-r--r-- | 1.1 KB |
module_signing.c | -rw-r--r-- | 1.1 KB |
notifier.c | -rw-r--r-- | 16.3 KB |
nsproxy.c | -rw-r--r-- | 12.8 KB |
padata.c | -rw-r--r-- | 28.0 KB |
panic.c | -rw-r--r-- | 18.3 KB |
params.c | -rw-r--r-- | 22.7 KB |
pid.c | -rw-r--r-- | 17.0 KB |
pid_namespace.c | -rw-r--r-- | 11.2 KB |
profile.c | -rw-r--r-- | 14.8 KB |
ptrace.c | -rw-r--r-- | 36.4 KB |
range.c | -rw-r--r-- | 3.0 KB |
reboot.c | -rw-r--r-- | 19.0 KB |
regset.c | -rw-r--r-- | 1.9 KB |
relay.c | -rw-r--r-- | 30.0 KB |
resource.c | -rw-r--r-- | 45.4 KB |
resource_kunit.c | -rw-r--r-- | 4.3 KB |
rseq.c | -rw-r--r-- | 9.8 KB |
scftorture.c | -rw-r--r-- | 17.9 KB |
scs.c | -rw-r--r-- | 2.8 KB |
seccomp.c | -rw-r--r-- | 61.6 KB |
signal.c | -rw-r--r-- | 119.6 KB |
smp.c | -rw-r--r-- | 26.8 KB |
smpboot.c | -rw-r--r-- | 11.8 KB |
smpboot.h | -rw-r--r-- | 640 bytes |
softirq.c | -rw-r--r-- | 18.0 KB |
stackleak.c | -rw-r--r-- | 3.6 KB |
stacktrace.c | -rw-r--r-- | 9.6 KB |
static_call.c | -rw-r--r-- | 10.6 KB |
stop_machine.c | -rw-r--r-- | 17.8 KB |
sys.c | -rw-r--r-- | 63.1 KB |
sys_ni.c | -rw-r--r-- | 10.0 KB |
sysctl-test.c | -rw-r--r-- | 10.8 KB |
sysctl.c | -rw-r--r-- | 80.5 KB |
task_work.c | -rw-r--r-- | 3.9 KB |
taskstats.c | -rw-r--r-- | 15.2 KB |
test_kprobes.c | -rw-r--r-- | 5.9 KB |
torture.c | -rw-r--r-- | 22.2 KB |
tracepoint.c | -rw-r--r-- | 15.6 KB |
tsacct.c | -rw-r--r-- | 4.7 KB |
ucount.c | -rw-r--r-- | 5.6 KB |
uid16.c | -rw-r--r-- | 5.1 KB |
uid16.h | -rw-r--r-- | 442 bytes |
umh.c | -rw-r--r-- | 15.0 KB |
up.c | -rw-r--r-- | 2.3 KB |
user-return-notifier.c | -rw-r--r-- | 1.3 KB |
user.c | -rw-r--r-- | 5.5 KB |
user_namespace.c | -rw-r--r-- | 33.2 KB |
usermode_driver.c | -rw-r--r-- | 4.1 KB |
utsname.c | -rw-r--r-- | 3.8 KB |
utsname_sysctl.c | -rw-r--r-- | 3.2 KB |
watch_queue.c | -rw-r--r-- | 16.4 KB |
watchdog.c | -rw-r--r-- | 20.1 KB |
watchdog_hld.c | -rw-r--r-- | 7.7 KB |
workqueue.c | -rw-r--r-- | 166.3 KB |
workqueue_internal.h | -rw-r--r-- | 2.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...