https://github.com/angular/angular

sort by:
Revision Author Date Message Commit Date
1445dba release: cut the v12.2.0-next.1 release (#42723) 30 June 2021, 20:29:51 UTC
24624e6 docs: release notes for the v12.1.1 release (#42722) 30 June 2021, 20:23:36 UTC
59fe159 build: update API goldens to reflect new tool (#42688) Updates the TS API guardian goldens with their equivalents based on the new shared dev-infra tool. PR Close #42688 30 June 2021, 18:43:48 UTC
9db69a9 build: use api-golden tool from dev-infra for testing public API (#42688) Switches our TS API guardian targets to rather use the new tool from dev-infra that relies on Microsoft's API extractor. PR Close #42688 30 June 2021, 18:43:48 UTC
56bd21d feat(dev-infra): introduce shared tool for validating API signature (#42688) For the last years the Angular repositories relied on `ts-api-guardian` for testing the public API signature. This project worked well in general but its another inconvenience to maintain if we could rely on Microsoft's `api-extractor` tool. Especially since with TypeScript 4.3 issues with export aliases appeared that would require us to extend TS API guardian to support such exports. This is not as straightforward as it sounds, given it requires rewriting of declarations to show-case the proper name in the API golden. Microsoft's API extractor has integrated support for this. As of TypeScript 4.3, we want to start using the new `override` keyword. We are not able to use that keyword currently because an old version of API extractor is used in the `ng_module` rule to flatten the types into a single file. To fix this, we need to update `api-extractor`, but this unveils the issue with TS API guardian because the most recent version of api-extractor uses alias exports to avoid potential conflicts with globals available through the TypeScript default libraries (e.g. `dom.d.ts`). PR Close #42688 30 June 2021, 18:43:48 UTC
0e20b05 docs: add last updated date to roadmap (#42615) PR Close #42615 30 June 2021, 18:41:57 UTC
9f5cc7c feat(compiler): support number separators in templates (#42672) As of ES2021, JavaScript allows using underscores as separators inside numbers, in order to make them more readable (e.g. `1_000_000` vs `1000000`). TypeScript has had support for separators for a while so these changes expand the template parser to handle them as well. PR Close #42672 30 June 2021, 17:36:15 UTC
234b5ed fix(platform-browser): in `Meta.addTag()` do not add duplicate meta tags (#42703) Previously, if there were two tags with the same "name" or "property" attribute selector, then only the first was checked for duplicates when deciding whether to add a new meta tag. Fixes #42700 Fixes #19606 PR Close #42703 30 June 2021, 17:35:30 UTC
f3965ff docs: setting context value inside an interceptor (#42699) Usage of `get`/`set` methods should be done on a context object instead of a `HttpRequest` instance. PR Close #42699 30 June 2021, 16:13:46 UTC
8528073 fix(dev-infra): remove bots from special thanks section (#42697) With this change we remove known used bots from special thanks section in the changelog. PR Close #42697 29 June 2021, 18:13:50 UTC
f29fe5c fix(dev-infra): use API pagination for retrieving project branches (#42666) We rely on a Github API `/branches` request to determine the active release trains. Currently this logic is broken if more than 100 protected branches exist within a repository. This issue surfaced recently where the `items_per_page` setting was set to `30`, causing the merge tooling and release tooling to not detect the proper "latest" release train. This commit uses Github pagination for retrieving branches to determine the active release trains, and makes the logic more long-term proof. PR Close #42666 29 June 2021, 17:33:54 UTC
279e63f refactor(dev-infra): update octokit to latest version v18 (#42666) We previously held off with updating Octokit to v18 due to their more noticable issues with typings. This commit updates us to the latest version in order to take advantage of the new pagination API (which is also strongly-typed), and to not fall behind too much over time (Octokit seems to change quite often..) We work around the problem with the types for `getContent` by just using a type cast with a TODO (and link to the issue). Similarly we work around a problem where the Octokit types have an incorrect type for the name of the labels array in an API response. PR Close #42666 29 June 2021, 17:33:54 UTC
0274255 refactor(docs-infra): make angular.io and docs examples compatible with RxJS v7 (#42660) This commit applies the necessary changes to make angular.io and (most) docs examples compatible with both RxJS v6 and v7. It also adds new steps to relevant CI jobs to test angular.io and docs examples against RxJS v7 as well (to catch potential regressions). NOTE: Some of the docs examples are not compatible with RxJS v7 and are therefore excluded from the tests. The SystemJS-based ngUpgrade examples in particular are excluded, since they require a different SystemJS configs to run against RxJS v6 and v7 and the extra complexity of managing that is not worth it for the 4 affected examples. PR Close #42660 29 June 2021, 17:29:58 UTC
188a738 test(docs-infra): allow excluding certain docs examples from tests (#42660) This commit adds support for excluding certain docs examples from the command used to run tests. This is useful to run extra tests on CI that might not be compatible with all examples (for example, run tests with different versions of a dependency). In a subsequent commit, this will be used to run tests against RxJS v7 as a quick way to catch potential regressions. PR Close #42660 29 June 2021, 17:29:58 UTC
2c490d5 docs: remove duplicate link to `guide/inputs-outputs.md` (#42654) When you click on `Understanding Angular > Components > Sharing data between child and parent directives and components` in navigation sidebar, another item gets selected: `Understanding Angular > Templates > Inputs and Outputs` Both of them are linked to the same guide but the view cannot handle situations when several entries point to the same guide. This commit fixes that by removing the second entry. Fixes #42652 PR Close #42654 29 June 2021, 16:27:47 UTC
41823ff feat(dev-infra): add command for printing release train information (#42644) Currently the active release trains are printed when a developer runs `ng-dev publish release`. This is not ideal because it requires the developer to provide an OAuth token, to be on the next branch, and to have no uncommitted changes, while the actual release train information is not dependent on these checks. This commit introduces a new command called `ng-dev release info` that can be used to retrieve relase information without the aforementioned requirements. Note that this command provides more detailed information about release branches than the `ng-dev caretaker check` command (which also requires on authentication as a side note). The `release info` command also prints active LTS branches for example. PR Close #42644 28 June 2021, 18:50:57 UTC
b54e8ae docs: update fonts optimization options description (#42642) In version 12.1, we included font inlining for Adobe fonts, see: https://github.com/angular/angular-cli/pull/21189 PR Close #42642 28 June 2021, 18:28:01 UTC
c93df7d docs: correct literal string example (#42623) Change literal string example `pi` to `'pi'`. PR Close #42623 28 June 2021, 17:05:09 UTC
1142b51 fix(docs-infra): styling fix on error pages (#42627) Add Center Aligment for heading texts and additional styles on 404 (not found) related pages PR Close #42627 28 June 2021, 16:50:24 UTC
4bea630 docs(core): add context jsdoc param to createEmbeddedView (#42675) PR Close #42675 28 June 2021, 16:34:17 UTC
2a260dc docs: update Roadmap section header from "Done" to "Completed" (#42620) "Completed" just sounds better (to me). PR Close #42620 28 June 2021, 16:33:18 UTC
70def3d fix(docs-infra): fix styling of `<summary>` elements on dark theme (#42620) Previously, the color of `<summary>` elements was hard-coded to `black`. This did not work well on the dark theme, where the background color of the page is also very dark. This commit fixes it by removing the explicit color style, thus letting `<summary>` elements inherit the color of their container. Closes #42616 PR Close #42620 28 June 2021, 16:33:18 UTC
e5b4b83 fix(docs-infra): improve styling of completed Roadmap projects (#42620) This commit improves the styling of the "Completed projects" section of the Roadmap by (a) making it consistent with the rest of the Roadmap sections and (b) making it more similar with `<details>` elements on other pages. **Before:** _Collapsed:_ ![completed projects collapsed (before)][1] _Expanded:_ ![completed projects expanded (before)][2] **After:** _Collapsed:_ ![completed projects collapsed (after)][3] _Expanded:_ ![completed projects expanded (after)][4] [1]: https://user-images.githubusercontent.com/8604205/122917101-50c2ca00-d366-11eb-8348-01efd69cedf2.png [2]: https://user-images.githubusercontent.com/8604205/122917109-515b6080-d366-11eb-9f18-c794fcea8dd1.png [3]: https://user-images.githubusercontent.com/8604205/122917115-528c8d80-d366-11eb-947a-2d7da3950069.png [4]: https://user-images.githubusercontent.com/8604205/122917117-53252400-d366-11eb-93e7-9384a7431c0d.png PR Close #42620 28 June 2021, 16:33:17 UTC
fd78678 refactor(docs-infra): make `<details>` styles more re-usable (#42620) This commit makes the styling for `<details>` elements (including expand/collapse actions in their `<summary>`) more re-usable. PR Close #42620 28 June 2021, 16:33:17 UTC
09ec62a refactor(docs-infra): merge duplicate `code.scss` files (#42620) PR #41129 reorganized the SCSS files of the angular.io app moving most of them in sub-directories. Due to incorrectly resolved merge conflicts for PRs targeting the SCSS files around that time, we ended up with duplicate style files for `<code>` elements: - `styles/2-modules/_code.scss` - `styles/2-modules/code/_code.scss` + `styles/2-modules/code/_code-theme.scss` This commit gets rid of the extra file (`styles/2-modules/_code.scss`) and ports any changes from it to the correct files inside the `code/` sub-directory. PR Close #42620 28 June 2021, 16:33:17 UTC
56fb4eb docs(compiler): interally typo fixed (#42676) PR Close #42676 28 June 2021, 16:32:23 UTC
37a740c fix(compiler-cli): add support for partially evaluating types (#41661) Add support to the partial evaluator for evaluating literal types and tuples. resolves #41338 PR Close #41661 25 June 2021, 16:59:27 UTC
45d24d2 docs: remove default linting tool in workspace guide (#42655) PR Close #42655 25 June 2021, 16:55:53 UTC
261b060 fix(dev-infra): fetch 100 branches from Github instead of 30 (#42658) This commit fixes an issue with the ng-dev tool, where Github's API returns paginated branch data. Only 30 branches are returned by default, and Angular now has more than 30 branches in its repo. This commit increases the number of branches returned to the API limit of 100, which should buy us some time until we can implement proper pagination. PR Close #42658 25 June 2021, 00:26:24 UTC
6e84ede release: cut the v12.2.0-next.0 release 24 June 2021, 21:30:33 UTC
d71d521 release: cut the v12.1.0 release 24 June 2021, 21:02:10 UTC
2203217 build(docs-infra): disambiguate doc paths for global APIs (#42648) In #41788, the `disambiguateDocsPathsProcessor` was introduced to fix an issue with case-insensitively equal paths. This processor may alter the output paths of some docs. Due to its nature, the `disambiguateDocPathsProcessor` must be the last processor in the pipeline that updates a doc's output path. However, the `updateGlobalApiPathProcess` (which also alters the output paths of some docs) was not configured to run before `disambiguateDocPathsProcessor`. As a result, the changes made by `disambiguateDocPathsProcessor` were overridden by `updateGlobalApiPathProcess`, resulting in the app's failing to load such global API docs pages. An example of such an API page is: https://angular.io/api/core/global/ngApplyChanges This commit fixes it by ensuring that the `updateGlobalApiPathProcess` is explicitly run before the `disambiguateDocPathsProcessor`, so that the former does not override the changes made by the latter. PR Close #42648 24 June 2021, 19:28:21 UTC
637ac00 docs: Fix reference to SwUpdate.isEnabled boolean (#42634) SwUpdate has an `isEnabled` boolean rather than an `isEnabled()` method. Removed parentheses for accuracy. PR Close #42634 24 June 2021, 19:27:38 UTC
c88e18a ci: exclude `service-worker/` sub-directories from `fw-testing` PullApprove group (#42631) The `fw-testing` PullApprove group, which by default owns all `testing/` sub-directories, is supposed to own resources related to testing Angular applications (from an end-user's perspective). The `service-worker` package source code includes some `testing/` sub-directories which are intended for internal use only (i.e. to test the `service-worker` package itself) and are not distributed to end-users of the package. Previously, changes in these `testing/` sub-directories would incorrectly require approval from the `fw-testing` group. This commit fixes this by excluding the `service-worker` package sub-directories from the files owned by the `fw-testing` group. PR Close #42631 24 June 2021, 19:26:51 UTC
4e46aef build: update dependency madge to v5 (#42629) PR Close #42629 24 June 2021, 17:10:32 UTC
cc30dc0 fix(service-worker): ensure obsolete caches are always cleaned up (#42622) Previously, the SW was only able to clean up caches for app-versions found in the `Driver`'s `versions` map. If (for some reason) the `Driver` failed to load a valid stored state (including app-versions) and ended up with an [empty `versions` map][1], any obsolete versions would remain in the cache storage. This case was rare but possible. This commit makes the cache clean-up logic more robust by ensuring that all app-version caches are removed unless they are currently used by the SW to serve active clients (with the exception of the latest app-version, which is always retained). Fixes #41728 [1]: https://github.com/angular/angular/blob/9de65dbdceac3077881fbc49717f33d0f379e21d/packages/service-worker/worker/src/driver.ts#L515-L529 PR Close #42622 24 June 2021, 16:55:32 UTC
01128f5 fix(service-worker): ensure caches are cleaned up when failing to load state (#42622) Previously, obsolete caches were only cleaned up when successfully loading the stored state. When the state failed to be loaded, cleaning up the caches would be skipped until the next SW initialization. This commit changes this, ensuring that the caches are cleaned up regardless if the stored state was loaded successfully or not. PR Close #42622 24 June 2021, 16:55:32 UTC
356dd21 refactor(service-worker): simplify accessing `CacheStorage` throughout the ServiceWorker (#42622) This commit simplifies/systemizes accessing the `CacheStorage` through a wrapper, with the following benefits: - Ensuring a consistent cache name prefix is used for all caches (without having to repeat the prefix in different places). - Allowing referring to caches using their name without the common cache name prefix. - Exposing the cache name on cache instances, which for example makes it easier to delete caches without having to keep track of the name used to create them. PR Close #42622 24 June 2021, 16:55:32 UTC
73b0275 fix(service-worker): improve ServiceWorker cache names (#42622) This commit improves the cache names generated by the ServiceWorker by making them shorter and non-repetitive. In particular, the following changes are made: - Data-group cache names no longer include the `dynamic` infix, since it does not add any value. Before: `ngsw:<...>:data:dynamic:<...>` After: `ngsw:<...>:data:<...>` - `CacheDatabase` table names no longer include the `ngsw:<path>` prefix twice. Before: `ngsw:<path>:db:ngsw:<path>:<...>` After: `ngsw:<path>:db:<...>` NOTE 1: This change will result in different cache names being generated for the same app-versions with the new SericeWorker script. This means that some of the previously cached data will need to be re-downloaded (because the ServiceWorker will not be able to re-use the old caches), but that should be transparent for the end user. While possible, adding logic to allow the ServiceWorker to retrieve data from the old caches is not worth the extra complecity and maintenance cost. NOTE 2: Generating different cache names for some of the caches means that the ServiceWorker will not be able to clean-up some of the old caches. This will be taken care of in a subsequent commit that will rework the clean-up logic to be more robust (covering changes such as this one and other edgecases). PR Close #42622 24 June 2021, 16:55:32 UTC
7507ed2 fix(service-worker): use correct names when listing `CacheDatabase` tables (#42622) `CacheDatabase` uses the un-prefixed table names to interact with database tables. However, the `list()` method returns the raw, prefixed table names (which are not useful, since they cannot be used to open/delete a table). This commit fixes this by removing the prefix from the cache names returned by the `list()` method. NOTE: This method is currently not used anywhere, so this change does not affect the ServiceWorker behavior. PR Close #42622 24 June 2021, 16:55:32 UTC
53fe557 feat(service-worker): include ServiceWorker version in debug info (#42622) This commit includes the ServiceWorker version in the debug info shown at `/ngsw/state` to make it easier to know what version of the ServiceWorker script is controlling the page. PR Close #42622 24 June 2021, 16:55:32 UTC
4962ef5 refactor(service-worker): minor refactorings to improve readability/maintainability (#42622) This commit makes some minor refactorings to improve the code readability and maintainability, including: - Avoiding code duplication. - Using more descriptive variable names. - Using `async/await` instead of `Promise#then()`. - Accessing variables directly instead of via `this` when possible. PR Close #42622 24 June 2021, 16:55:32 UTC
874de59 fix(compiler-cli): change default ngcc hash algorithm to be FIPS compliant (#42582) The previous default algorithm was `md5`, which is not compliant with FIPS. The default is now set to `sha256`, which is compliant. Fixes #42577 PR Close #42582 24 June 2021, 15:42:38 UTC
b8ef83b refactor(compiler-cli): ngcc entry-point manifest hash is now configurable (#42582) The hash algorithm for the entry-point manifest was hardcoded to `md5`. This can now be configured by the `hashAlgorithm` property on the ngcc.config.js project configuration. PR Close #42582 24 June 2021, 15:42:38 UTC
a3b6d65 refactor(compiler-cli): make ngcc configuration hash algorithm configurable! (#42582) The ngcc configuration gets hashed to be used when caching but it was hardcoded to use the `md5` algorithm, which is not FIPS compliant. Now the hash algorithm can be configured in the ngcc.config.js file at the project level. PR Close #42582 24 June 2021, 15:42:38 UTC
8da6f66 ci: replace RBE instance name for components-repo-unit-tests job (#42636) Temporarily replaces the RBE instance name for the `components-repo-unit-tests` job until https://github.com/angular/components/pull/23056 is available. PR Close #42636 24 June 2021, 15:28:57 UTC
2340cbc build: update to new remote instance name for RBE (#42636) Update to use remote instance name, primary_instance, for RBE PR Close #42636 24 June 2021, 15:28:57 UTC
3567231 build: lock file maintenance (#42568) PR Close #42568 23 June 2021, 17:36:41 UTC
d546501 feat(service-worker): add `openWindow`, `focusLastFocusedOrOpen` and `navigateLastFocusedOrOpen` (#42520) Add `openWindow`, `focusLastFocusedOrOpen` and `navigateLastFocusedOrOpen` abilty to the notificationclick handler such that when either a notification or notification action is clicked the service-worker can act accordinly without the need for the app to be open PR Close #26907 PR Close #42520 23 June 2021, 16:31:09 UTC
9de65db fix(compiler): should not break a text token on a non-valid start tag (#42605) Previously the lexer would break out of consuming a text token if it contains a `<` character. Then if the next characters did not indicate an HTML syntax item, such as a tag or comment, then it would start a new text token. These consecutive text tokens are then merged into each other in a post tokenization step. In the commit before this, interpolation no longer leaks across text tokens. The approach given above to handling `<` characters that appear in text is no longer adequate. This change ensures that the lexer only breaks out of a text token if the next characters indicate a valid HTML tag, comment, CDATA etc. PR Close #42605 22 June 2021, 16:37:00 UTC
c873440 fix(compiler): do not allow unterminated interpolation to leak into later tokens (#42605) When consuming a text token, the lexer tracks whether it is reading characters from inside an interpolation so that it can identify invalid ICU expressions. Inside an interpolation there will be no ICU expression so it is safe to have unmatched `{` characters, but outside an interpolation this is an error. Previously, if an interpolation was started, by an opening marker (e.g. `{{`) in a text token but the text came to an end before the closing marker (e.g. `}}`) then the lexer was not clearing its internal state that tracked that it was inside an interpolation. When the next text token was being consumed, the lexer, incorrectly thought it was already within an interpolation. This resulted in invalid ICU expression errors not being reported. For example, in the following snippet, the first text block has a prematurely ended interpolation, and the second text block contains an invalid `{` character. ``` <div>{{</div> <div>{</div> ``` Previously, the lexer would not have identified this as an error. Now there will be an EOF error that looks like: ``` TS-995002: Unexpected character "EOF" (Do you have an unescaped "{" in your template? Use "{{ '{' }}") to escape it.) ``` PR Close #42605 22 June 2021, 16:37:00 UTC
8a67770 docs(core): improve applicationref.bootstrap docs (#42407) add proper examples and update usage notes add references to the method at relevant places in the docs PR Close #42407 22 June 2021, 16:30:37 UTC
9498da1 fix(service-worker): correctly determine client ID on navigation requests (#42607) The ServiceWorker assigns an app-version to a each client to ensure that all subsequent requests for a client are served using the same app-version. The assignment is done based on the client ID. Previously, the ServiceWorker would only try to read the client's ID off of the `FetchEvent`'s `clientId` property. However, for navigation requests the new client's ID will be set on [resultingClientId][1], while `clientId` will either be empty or hold the ID of the client where the request initiated from. See also related discussions in w3c/ServiceWorker#870 and w3c/ServiceWorker#1266. In theory, this could lead to the navigation request (i.e. `index.html`) being served from a different app-version than the subsequent sub-resource requests (i.e. assets). In practice, the likelihood of this happening is probably very low though, since it would require the latest app-version to be updated between the initial navigation request and the first sub-resource request, which should happen very shortly after the navigation request. This commit ensures that the correct client ID is determined even for navigation requests by also taking the `resultingClientId` property into account. [1]: https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent/resultingClientId PR Close #42607 22 June 2021, 16:28:24 UTC
81a19e4 feat(dev-infra): update pullapprove verification to ensure all groups have reviewers (#42614) Update the pullapprove verification tooling to ensure a reviewer is defined for each group. This is being done in preparation for the upcoming change to how pullapprove billing works. The new billing will work on a seats based approach rather than flat usage. PR Close #42614 22 June 2021, 16:27:36 UTC
75bbcf7 docs: improve styles of the roadmap done section (#42616) The "Done" section was previously broken in dark mode. This PR: - Fixes the dark mode styles - Expands the done section by default PR Close #42616 22 June 2021, 16:26:47 UTC
cc672f0 feat(compiler): add support for shorthand property declarations in templates (#42421) Adds support for shorthand property declarations inside Angular templates. E.g. doing `{foo, bar}` instead of `{foo: foo, bar: bar}`. Fixes #10277. PR Close #42421 21 June 2021, 23:40:47 UTC
699a8b4 test(compiler-cli): add additional safe keyed read tests (#42421) This commit adds some tests that were mistakenly omitted from the original change for safe keyed reads/writes. PR Close #42421 21 June 2021, 23:40:47 UTC
6b2a475 docs: add new i18n formats to i18n guide (#42597) PR Close #42597 21 June 2021, 18:48:19 UTC
a9dd7e2 refactor(compiler-cli): enable relative imports in the type parameter emitter (#42492) Previously, the template type checker would only opt-in to inline type constructors if it could import all type references from absolute module specifiers. This limitation was put into place in an abundance of caution as there was a safe, but less performant, fallback available. The language service is not capable of using this fallback, which now means that the limitation of absolute module specifiers limits the language service's ability to use accurate types for component/directive classes that have generic type parameters. This commit loosens the restriction such that type references are now eligible for emit as long as they are exported. PR Close #42492 21 June 2021, 18:34:05 UTC
729eea5 fix(compiler-cli): transform type references in generic type parameter default (#42492) When a component/directive has a generic type parameter, the template type checker attempts to translate the type parameter such that the type parameters can be replicated in the type constructor that is emitted into the typecheck file. Type parameters with a default clause would incorrectly be emitted into the typecheck file using the original `ts.TypeNode` for the default clause, such that `ts.TypeReferenceNode`s within the default clause would likely be invalid (i.e. referencing a type for which no import is present in the typecheck file). This did not result in user-facing type-check errors as errors reported in type constructors are not translated into template positions Regardless, this commit ensures that `ts.TypeReferenceNode`s within defaults are properly translated into the typecheck file. PR Close #42492 21 June 2021, 18:34:05 UTC
16aaa23 refactor(compiler-cli): use TypeScript transform to emit type parameters (#42492) The template type checker is capable of recreating generic type bounds in a different context, rewriting type references along the way (if possible). This was previously done using a visitor that only supported a limited set of types, resulting in the inability to emit all sorts of types (even if they don't contain type references at all). The inability to emit generic type bounds was not critical when the type parameter emitting logic was introduced, as the compiler also has a fallback strategy of creating inline type constructors. However, this fallback is not available to the language service, resulting in inaccurate types when components/directives use a complex generic type. To mitigate this problem, the specialized visitor has been replaced with a generalized TypeScript transform, where only type references get special treatment. This allows for more complex types to be emitted, such as union and intersection types, object literal types and tuple types. PR Close #42492 21 June 2021, 18:34:05 UTC
f52df99 fix(compiler): generate view restoration for keyed write inside template listener (#42603) If an implcit receiver is accessed in a listener inside of an `ng-template`, we generate some extra code in order to ensure that we're assigning to the correct object. The problem is that the logic wasn't covering keyed writes which caused it to write to the wrong object and throw an assertion error at runtime. These changes expand the logic to cover keyed writes. Fixes #41267. PR Close #42603 21 June 2021, 18:30:37 UTC
8793d1a ci: update pullapprove config (#42613) Update the fallback group in pullapprove to define a reviewer for the group, in preparation for the upcoming change to how pullapprove billing works. The new billing will work on a seats based approach rather than flat usage. PR Close #42613 21 June 2021, 17:36:56 UTC
e83d7cb refactor(compiler-cli): support xi18n in ngtsc (#42485) xi18n is the operation of extracting i18n messages from templates in the compilation. Previously, only View Engine was able to perform xi18n. This commit implements xi18n in the Ivy compiler, and a copy of the View Engine test for Ivy verifies that the results are identical. PR Close #42485 21 June 2021, 16:50:28 UTC
4538bd6 refactor(compiler-cli): extract xi18n utility functions to a separate file (#42485) This commit moves some xi18n-related functions in the View Engine ng.Program into a new file. This is necessary in order to depend on them from the Ivy ng.Program while avoiding a cycle. PR Close #42485 21 June 2021, 16:50:28 UTC
d77f560 build: update to typescript 4.3.4 (#42600) Updates to TypeScript 4.3.4 which contains a fix for a printer regression that caused unexpected JavaScript output with our compiler transforms. See: https://github.com/microsoft/TypeScript/pull/44070. Updates to TypeScript 4.3.4 which contains a fix for a printer PR Close #42600 21 June 2021, 16:42:49 UTC
b8eb24e Revert "test: update compiler-cli compliance goldens due to TS 4.3 emit format regression (#42022)" (#42600) This reverts commit 71e14a71f5b8e0a7569df8442402a0c122fec870. PR Close #42600 21 June 2021, 16:42:48 UTC
4429188 docs(docs-infra): document how to configure redirects (#42452) PR Close #42452 18 June 2021, 17:32:58 UTC
d07e736 build(docs-infra): auto-generate SW `navigationUrls` from Firebase config (#42452) Previously, redirects had to be configured in both the Firebase config (`firebase.json`) and the ServiceWorker config (`ngsw-config.json`). This made it challenging to correctly configure redirects, since one had to understand the different formats of the two configs, and was also prone to getting out-of-sync configs. This commit simplifies the process of adding redirects by removing the need to update the ServiceWorker config (`ngsw-config.json`) and keep it in sync with the Firebase config (`firebase.json`). Instead the ServiceWorker `navigationUrls` are automatically generated from the list of redirects in the Firebase config. NOTE: Currently, the automatic generation only supports the limited set of patterns that are necessary to translate the existing redirects. It can be made more sophisticated in the future, should the need arise. PR Close #42452 18 June 2021, 17:32:58 UTC
982521f build(docs-infra): align `navigationUrls` in `ngsw-config.json` with Firebase redirects (#42452) The ServiceWorker `navigationUrls` globs defined in `ngsw-config.json` are supposed to exclude any URLs that are redirected on the server (as configured in `firebase.json`). However, the list of redirected URLs/globs in `firebase.json` and `ngsw-config.json` have gotten out of sync. This commit updates the globs in `ngsw-config.json` to match the ones in `firebase.json`. This is in preparation of automatically generating the ServiceWorker `navigationUrls` based on `firebase.json`. PR Close #42452 18 June 2021, 17:32:58 UTC
fe3c79f build(docs-infra): alphabetically sort all `navigationUrls` in `ngsw-config.json` (#42452) This commit sorts all `navigationUrls` in `ngsw-config.json` alphabetically. This is in preparation of automatically generating the ServiceWorker `navigationUrls` based on `firebase.json`. PR Close #42452 18 June 2021, 17:32:58 UTC
932f246 build(docs-infra): allow a trailing `/` in more `navigationUrls` globs in `ngsw-config.json` (#42452) Previously, we were not consistent in allowing a trailing `/` in `navigationUrls` globs in `ngsw-config.json`. And when we did, we used two globs: one with and one without the trailing `/`. This commit updates all appropriate `navigationUrls` globs to allow a trailing `/`. It also merges the two glob patterns (the one with and the one without the `/`) into one. This is in preparation of automatically generating the ServiceWorker `navigationUrls` based on `firebase.json`. PR Close #42452 18 June 2021, 17:32:58 UTC
4635d4f build(docs-infra): remove redundant `navigationUrls` globs from `ngsw-config.json` (#42452) This commit removes some `navigationUrls` globs from `ngsw-config.json` that have no effect. More specifically: - It removes globs of the form `!/**/xyz.html`, since these are already covered by the more generic `!/**/*.*` glob. - It removes `!/api/**/NgFor`, since it does not have a corresponding redirect rule in `firebase.json`. This is in preparation of automatically generating the ServiceWorker `navigationUrls` based on `firebase.json`. PR Close #42452 18 June 2021, 17:32:58 UTC
36fb574 build(docs-infra): add missing redirect rule for `api/http` in `firebase.json` (#42452) Previously, only sub-paths, such as `api/http/foo`, were redirected to `guide/deprecations#http`. This commit ensures that also `api/http` itself (which used to point to the `http` module's API page) is redirected as well. PR Close #42452 18 June 2021, 17:32:58 UTC
c397b59 test(docs-infra): ensure all redirect rules are tested (#42452) This commit adds a test assertion to verify that all redirect rules defined in `firebase.json` are tested, i.e. that each rule is applied to at least one testcase from `URLS_TO_REDIRECT.txt`. This will ensure that any redirect rules added in the future will be tested. PR Close #42452 18 June 2021, 17:32:57 UTC
c66423a test(docs-infra): unnest unnecessarily nested test suite (#42452) Previously, the `destinations` test suite in `testFirebaseRedirection.spec.ts` was nested under the `with legacy URLs` test suite. However, the two suites are unrelated and there is no reason to have them nested. This commit moves the `destinations` test suite to be beside (instead of inside) the `with legacy URLs` one. PR Close #42452 18 June 2021, 17:32:57 UTC
e033818 test(docs-infra): add testcases for all redirect rules (#42452) This commit adds testcases in `URLS_TO_REDIRECT.txt` for all redirect rules defined in `firebase.json`. This ensures that all rules are tested and work as expected. PR Close #42452 18 June 2021, 17:32:57 UTC
0c105c3 fix(docs-infra): make `NotificationComponent` elements non-focusable when hidden (#42584) Previously, the `NotificationComponent` would be hidden by reducing its height to `0`. This allowed for a smoother hide animation when closing the notification, but left the component's interactive elements focusable via keyboard navigation. This was confusing for users, because the focused elements would not be visible on the page. This commit fixes the issue be also setting the `display` CSS property to `none` when the `NotificationComponent` is hidden, thus ensuring that its contents are not focusable via keyboard navigation. (This does not affect the hide animation, since the `display` style is not animatable and is only applied at the end of the animation.) PR Close #42584 18 June 2021, 17:32:26 UTC
29302e3 fix(docs-infra): remove redundant `MatIcon` element (#42584) Previously, we included a dummy `MatIcon` element in `AppComponent` in order to ensure that the `Material Icons` font would be requested (and thus cached by the ServiceWorker) on every navigation. However, #41129 introduced the `ThemeToggleComponent`, which will be present on all pages (since it is located in the top-menu) and relies on the `Material Icons` font. Therefore, the work-around for loading the `Material Icons` font is no longer necessary. This commit removes the now redundant `MatIcon` from `AppComponent`. PR Close #42584 18 June 2021, 17:32:26 UTC
fd8f9ab fix(docs-infra): convert external links to `MatIconButton`s (#42584) This commit changes the anchor elements used for external links to `MatIconButton`s. While the appearance remains the same (with the exception of hover/focus styles), this better aligns the styling of external link icons with other nearby icon buttons (i.e. the theme toggle) and alows as to simplify the CSS for external links (since much of their styling is handled by Angular Material). PR Close #42584 18 June 2021, 17:32:26 UTC
0f6ebe1 refactor(docs-infra): remove redundant CSS rule (#42584) Since we now use SVG for external link icons, there are no `<img>` elements inside the anchor elements. So, the CSS rule does not match any element and can be removed. PR Close #42584 18 June 2021, 17:32:26 UTC
1264448 ci: start tracking CSS payload sizes for angular.io (#42584) Previously, we only tracked the sizes of the eagerly loaded JS bundles. However, the CSS styles (which also have a non-negligible size) must also be downloaded and parsed by the browser, thus affecting the initial rendering time. This commit starts tracking the CSS styles payload sizes. (Originally discussed in https://github.com/angular/angular/pull/42584#discussion_r653787961) PR Close #42584 18 June 2021, 17:32:26 UTC
983c540 docs: fix pipe params (#42593) The addition of overloads to some of the number pipes caused the documentation to lose the parameter descriptions. This change fixes that by moving the JSDOC block in from of the primary method signature, rather than the first overload. Fixes #42590 PR Close #42593 17 June 2021, 23:03:08 UTC
b037df2 Revert "fix(docs-infra): do not redirect disambiguated URLs" (#42414) This reverts commit 61ad68a586135a4d7b2b920fda0cb4238c6422fe, since there are no longer any disambiguated paths that need special handling. PR Close #42414 17 June 2021, 18:14:53 UTC
15fca6c build(docs-infra): remove `disambiguator` doc-type (#42414) Now that we disambiguate files by encoding the outputPath, there is no need for the `disambiguator` doc-type. PR Close #42414 17 June 2021, 18:14:53 UTC
b0592c1 build(docs-infra): use case-insensitive encoding for content files (#42414) To avoid having content files that have the same file path on case-insensitive file-systems, we now encode the paths to remove uppercase characters. PR Close #42414 17 June 2021, 18:14:53 UTC
07c1ddc fix(router): error if module is destroyed before location is initialized (#42560) This is something I ran into while working on a fix for the `TestBed` module teardown behavior for #18831. In the `RouterInitializer.appInitializer` we have a callback to the `LOCATION_INITIALIZED` which has to do some DI lookups. The problem is that if the module is destroyed before the location promise resolves, the `Injector.get` calls will fail. This is unlikely to happen in a real app, but it'll show up in unit tests once the test module teardown behavior is fixed. PR Close #42560 17 June 2021, 18:11:53 UTC
166e98a build: update all non-major dependencies (#42544) PR Close #42544 17 June 2021, 18:09:31 UTC
0af9b89 build: update angular to v12.0.5 (#42588) PR Close #42588 17 June 2021, 18:08:55 UTC
873229f feat(core): add opt-in test module teardown configuration (#42566) We currently have two long-standing issues related to how `TestBed` tests are torn down: 1. The dynamically-created test module isn't going to be destroyed, preventing the `ngOnDestroy` hooks on providers from running and keeping the component `style` nodes in the DOM. 2. The test root elements aren't going to be removed from the DOM. Instead, they will be removed whenever another test component is created. By themselves, these issues are easy to resolve, but given how long they've been around, there are a lot of unit tests out there that depend on the broken behavior. These changes address the issues by introducing APIs that allow users to opt into the correct test teardown behavior either at the application level via `TestBed.initTestEnvironment` or the test suite level via `TestBed.configureTestingModule`. At the moment, the new teardown behavior is opt-in, but the idea is that we'll eventually make it opt-out before removing the configuration altogether. Fixes #18831. PR Close #42566 17 June 2021, 18:03:47 UTC
f8e17c8 release: cut the v12.1.0-next.6 release (#42587) PR Close #42587 16 June 2021, 23:45:23 UTC
0e33521 Revert "release: bump the next branch to v12.2.0-next.0" This reverts commit 7961e2fc52e08c4e3c0a8a2f901a4787fee8f87a. This is not actually how we configure new minor releases. 16 June 2021, 23:31:32 UTC
7961e2f release: bump the next branch to v12.2.0-next.0 16 June 2021, 23:12:20 UTC
5c25595 docs: release notes for the v12.0.5 release (#42586) PR Close #42586 16 June 2021, 23:01:36 UTC
eb04684 fix(docs-infra): make anchor in list item inherit line-height (#42572) in order to have a consistent line-height between list items containing text and list items containing links the anchors should inherit the list item's line-height PR Close #42572 16 June 2021, 21:03:32 UTC
7b85a4d fix(docs-infra): add horizontal margins to nav menu (#42561) add a 2px left and right margin to the aio-nav-menu to make sure that the items outline doesn't get cropped PR Close #42561 16 June 2021, 21:02:53 UTC
40612d1 fix(docs-infra): fix width of sidenav icons (#42561) make sure that the width of the sidenav chervon icon is 2.4rem (this needs to be done using the flex property and not the width one as that can change in flex containers) also center chevron icon inside mat-icon container in order to maintain the correct icon positioning at any font-size PR Close #42561 16 June 2021, 21:02:53 UTC
91e307b fix(docs-infra): prevent vertical nav item overflowing (#42561) prevent the overflowing unwanted effect that happens during a nav item opening and closing (during the chevron rotation) PR Close #42561 16 June 2021, 21:02:53 UTC
3b81528 fix(docs-infra): improve card layout for different browser font sizes (#42533) Remove the fixed height set on the card elements present in angular.io, allowing the cards to have a dynamic height derived from their content and thus removing overflow issues related to the browser's font-size, make other minor css related adjustments to allow the card to look good on the different browser's font-size settings PR Close #42533 16 June 2021, 21:02:24 UTC
f3a7987 docs(forms): correct sample code for FormArray.reset (#42477) Remove unexpected this, correct output comment for arr.value and correct parameter type for FormArray.get(). PR Close #42477 16 June 2021, 21:01:55 UTC
back to top