Revision 14571a699ae56859bc30a22946f563a8b48b80c4 authored by Manuel Rego Casasnovas on 21 March 2018, 13:42:37 UTC, committed by Chromium WPT Sync on 21 March 2018, 13:42:37 UTC
We have been calling testGridTemplateColumnsRows() with
and without arrays.
Arrays are needed because the serialization of 2 tracks of the same size
can be "100px 100px" or "repeat(2, 100px)".
But in the rest of the cases we don't need an array,
so we call the method with a single value.
testGridTemplateColumnsRows() was not ready to support that,
and it wasn't actually checking anything in that case.

The patch modifies testing-utils.js, so it wraps values in an array
when required.
Now testGridTemplateColumnsRows() will be actually checking things.

Change-Id: I7e360677c391df74dedb474922bf5c04247141c5
Reviewed-on: https://chromium-review.googlesource.com/973063
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#544681}
1 parent fc04bb5
Raw File
.gitmodules
[submodule "css/tools/apiclient"]
	path = css/tools/apiclient
	url = https://github.com/w3c/csswg-apiclient.git
[submodule "css/tools/w3ctestlib"]
	path = css/tools/w3ctestlib
	url = https://github.com/w3c/csswg-w3ctestlib.git
[submodule "tools/html5lib/html5lib/tests/testdata"]
	path = tools/html5lib/html5lib/tests/testdata
	url = https://github.com/html5lib/html5lib-tests.git
[submodule "resources/webidl2/test/widlproc"]
	path = resources/webidl2/test/widlproc
	url = https://github.com/dontcallmedom/widlproc.git
back to top