Revision 14571a699ae56859bc30a22946f563a8b48b80c4 authored by Manuel Rego Casasnovas on 21 March 2018, 13:42:37 UTC, committed by Chromium WPT Sync on 21 March 2018, 13:42:37 UTC
We have been calling testGridTemplateColumnsRows() with
and without arrays.
Arrays are needed because the serialization of 2 tracks of the same size
can be "100px 100px" or "repeat(2, 100px)".
But in the rest of the cases we don't need an array,
so we call the method with a single value.
testGridTemplateColumnsRows() was not ready to support that,
and it wasn't actually checking anything in that case.
The patch modifies testing-utils.js, so it wraps values in an array
when required.
Now testGridTemplateColumnsRows() will be actually checking things.
Change-Id: I7e360677c391df74dedb474922bf5c04247141c5
Reviewed-on: https://chromium-review.googlesource.com/973063
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#544681}
1 parent fc04bb5
CONTRIBUTING.md
Grant of License
----------------
By contributing to this repository, you and the company you represent, if the
company holds any copyrights in the contribution, grant to the W3C a perpetual,
non-exclusive, royalty-free, world-wide right and license under all of your
copyrights in this contribution to copy, publish, use, and modify the
contribution and to distribute the contribution under a BSD License or one with
more restrictive terms, as well as a right and license of the same scope to any
derivative works prepared by the W3C and based on or incorporating all or part
of the contribution. You further agree that any derivative works of this
contribution prepared by the W3C shall be solely owned by the W3C.
You state, to the best of your knowledge, that you, or the company you
represent, have all rights necessary to contribute the materials.
W3C will retain attribution of initial authorship to you. The W3C makes no
a-priori commitment to support or distribute contributions.
Disclaimer
----------
All content from this repository is provided as is, and W3C makes no
representations or warranties, express or implied, including, but not limited
to, warranties of merchantability, fitness for a particular purpose,
non-infringement, or title; nor that the contents of this repository are
suitable for any purpose. We make no representations, express or implied, that
the content of this repository or the use thereof indicates conformance to a
specification. All content is provided as-is to help reach interoperability.
Documentation
-------------
See [web-platform-tests.org](http://web-platform-tests.org/).
Computing file changes ...
