Revision 14571a699ae56859bc30a22946f563a8b48b80c4 authored by Manuel Rego Casasnovas on 21 March 2018, 13:42:37 UTC, committed by Chromium WPT Sync on 21 March 2018, 13:42:37 UTC
We have been calling testGridTemplateColumnsRows() with
and without arrays.
Arrays are needed because the serialization of 2 tracks of the same size
can be "100px 100px" or "repeat(2, 100px)".
But in the rest of the cases we don't need an array,
so we call the method with a single value.
testGridTemplateColumnsRows() was not ready to support that,
and it wasn't actually checking anything in that case.

The patch modifies testing-utils.js, so it wraps values in an array
when required.
Now testGridTemplateColumnsRows() will be actually checking things.

Change-Id: I7e360677c391df74dedb474922bf5c04247141c5
Reviewed-on: https://chromium-review.googlesource.com/973063
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#544681}
1 parent fc04bb5
History
File Mode Size
reference
resources
OWNERS -rw-r--r-- 41 bytes
css-vars-custom-property-case-sensitive-001.html -rw-r--r-- 1.5 KB
css-vars-custom-property-inheritance.html -rw-r--r-- 967 bytes
test_variable_legal_values.html -rw-r--r-- 4.2 KB
variable-animation-from-to.html -rw-r--r-- 2.6 KB
variable-animation-over-transition.html -rw-r--r-- 2.9 KB
variable-animation-substitute-into-keyframe-shorthand.html -rw-r--r-- 2.4 KB
variable-animation-substitute-into-keyframe-transform.html -rw-r--r-- 2.2 KB
variable-animation-substitute-into-keyframe.html -rw-r--r-- 2.3 KB
variable-animation-substitute-within-keyframe-fallback.html -rw-r--r-- 2.5 KB
variable-animation-substitute-within-keyframe-multiple.html -rw-r--r-- 2.4 KB
variable-animation-substitute-within-keyframe.html -rw-r--r-- 2.3 KB
variable-animation-to-only.html -rw-r--r-- 2.1 KB
variable-created-document.html -rw-r--r-- 1.5 KB
variable-created-element.html -rw-r--r-- 1.8 KB
variable-cssText.html -rw-r--r-- 2.3 KB
variable-definition-border-shorthand-serialize.html -rw-r--r-- 933 bytes
variable-definition-cascading.html -rw-r--r-- 2.6 KB
variable-definition-keywords.html -rw-r--r-- 2.6 KB
variable-definition.html -rw-r--r-- 6.5 KB
variable-first-letter.html -rw-r--r-- 3.3 KB
variable-first-line.html -rw-r--r-- 3.4 KB
variable-generated-content-dynamic-001-ref.html -rw-r--r-- 89 bytes
variable-generated-content-dynamic-001.html -rw-r--r-- 590 bytes
variable-invalidation.html -rw-r--r-- 5.0 KB
variable-presentation-attribute.html -rw-r--r-- 8.5 KB
variable-pseudo-element.html -rw-r--r-- 3.2 KB
variable-reference-cssom.html -rw-r--r-- 2.5 KB
variable-reference-refresh.html -rw-r--r-- 2.2 KB
variable-reference-shorthands-cssom.html -rw-r--r-- 1.3 KB
variable-reference-shorthands.html -rw-r--r-- 2.8 KB
variable-reference-variable.html -rw-r--r-- 1.3 KB
variable-reference-without-whitespace.html -rw-r--r-- 1.6 KB
variable-reference.html -rw-r--r-- 3.3 KB
variable-substitution-background-properties.html -rw-r--r-- 4.7 KB
variable-substitution-basic.html -rw-r--r-- 4.6 KB
variable-substitution-filters.html -rw-r--r-- 2.8 KB
variable-substitution-plus-box-shadow.html -rw-r--r-- 2.0 KB
variable-substitution-replaced-size.html -rw-r--r-- 1.5 KB
variable-substitution-shadow-properties.html -rw-r--r-- 1.8 KB
variable-substitution-shorthands.html -rw-r--r-- 7.4 KB
variable-substitution-variable-declaration.html -rw-r--r-- 6.2 KB
variable-transitions-from-no-value.html -rw-r--r-- 2.6 KB
variable-transitions-to-no-value.html -rw-r--r-- 2.6 KB
variable-transitions-transition-property-all-before-value.html -rw-r--r-- 2.7 KB
variable-transitions-transition-property-variable-before-value.html -rw-r--r-- 2.7 KB
variable-transitions-value-before-transition-property-all.html -rw-r--r-- 2.7 KB
variable-transitions-value-before-transition-property-variable.html -rw-r--r-- 2.6 KB
vars-background-shorthand-001.html -rw-r--r-- 885 bytes
vars-border-shorthand-serialize.html -rw-r--r-- 1.3 KB
vars-font-shorthand-001.html -rw-r--r-- 1.1 KB

back to top