Revision 156b56480a786db4d967bde5eb6d5edee56a27d0 authored by Brad King on 27 September 2019, 17:06:56 UTC, committed by Brad King on 27 September 2019, 18:15:00 UTC
Revert the main logic change from commit 827da1119e (Makefiles: Make
build root targets "all", "clean" and "preinstall" recursive,
2019-05-17, v3.15.0-rc1~96^2~2) for the "all" and "preinstall" targets.

The commit cleaned up the Makefile generator to use the same logic for
the "all" target in the top-level directory as for subdirectories.  It
exposed a long-existing bug that caused the "all" target in a
subdirectory to include the "all" targets from sub-subdirectories even
if they are marked `EXCLUDE_FROM_ALL`.  The `Tests/SubDir` test should
fail but the problem is currently covered up by another bug introduced
by commit dc6888573d (Pass EXCLUDE_FROM_ALL from directory to targets,
2019-01-15, v3.14.0-rc1~83^2) that causes the "all" targets in
`EXCLUDE_FROM_ALL` subdirectories to be empty.

Revert the top-level "all" and "preinstall" targets to the old approach
to prepare to fix the latter bug without exposing the long-existing bug
at the top-level.  Leave the "clean" target in the new approach because
it does not honor `EXCLUDE_FROM_ALL` anyway.

Issue: #19753
1 parent 26a0e20
History
File Mode Size
form
.NoDartCoverage -rw-r--r-- 39 bytes
CMakeLists.txt -rw-r--r-- 1.3 KB
ccmake.cxx -rw-r--r-- 4.7 KB
cmCursesBoolWidget.cxx -rw-r--r-- 1.2 KB
cmCursesBoolWidget.h -rw-r--r-- 975 bytes
cmCursesCacheEntryComposite.cxx -rw-r--r-- 3.4 KB
cmCursesCacheEntryComposite.h -rw-r--r-- 1.1 KB
cmCursesDummyWidget.cxx -rw-r--r-- 601 bytes
cmCursesDummyWidget.h -rw-r--r-- 872 bytes
cmCursesFilePathWidget.cxx -rw-r--r-- 472 bytes
cmCursesFilePathWidget.h -rw-r--r-- 613 bytes
cmCursesForm.cxx -rw-r--r-- 859 bytes
cmCursesForm.h -rw-r--r-- 1.6 KB
cmCursesLabelWidget.cxx -rw-r--r-- 806 bytes
cmCursesLabelWidget.h -rw-r--r-- 972 bytes
cmCursesLongMessageForm.cxx -rw-r--r-- 4.1 KB
cmCursesLongMessageForm.h -rw-r--r-- 1.4 KB
cmCursesMainForm.cxx -rw-r--r-- 34.5 KB
cmCursesMainForm.h -rw-r--r-- 4.3 KB
cmCursesOptionsWidget.cxx -rw-r--r-- 2.2 KB
cmCursesOptionsWidget.h -rw-r--r-- 1.1 KB
cmCursesPathWidget.cxx -rw-r--r-- 2.0 KB
cmCursesPathWidget.h -rw-r--r-- 1.1 KB
cmCursesStandardIncludes.h -rw-r--r-- 1.1 KB
cmCursesStringWidget.cxx -rw-r--r-- 5.8 KB
cmCursesStringWidget.h -rw-r--r-- 2.0 KB
cmCursesWidget.cxx -rw-r--r-- 1.0 KB
cmCursesWidget.h -rw-r--r-- 1.8 KB

back to top