Revision 15bff9162530113b426664eb0c1deb7ea9e3a90d authored by Tim Foley on 13 April 2018, 20:36:26 UTC, committed by GitHub on 13 April 2018, 20:36:26 UTC
A previous fix avoided crashes when an `import`ed module has errors by making the "failed to import" error a fatal one. Unfortunately, the code path that handles fatal errors was failing to copy diagnostic output from the sink over to the member variable on the `CompileRequest` that exposes the output through the API. This meant that API users lost all context on error messages in `import`ed code. This change fixes the immediate issue by plumbing through the error output, but doesn't fix the more fundamental issue: the front-end should not crash when an `import` fails, by any means.
1 parent 021a492
.travis.yml
# .travis.yml
#
# This is the configuration file to drive Travis CI for Slang.
language: cpp
env:
- SLANG_TEST_FLAGS=-travis
# Build and test (clang, gcc) x (debug, release)
#
# We customize the set of tests run per-target to
# avoid having the build take too long.
matrix:
include:
- os: linux
compiler: gcc
env:
- CONFIGURATION=debug
- SLANG_TEST_CATEGORY=smoke
- os: linux
compiler: clang
env:
- CONFIGURATION=debug
- SLANG_TEST_CATEGORY=smoke
- os: linux
compiler: clang
env:
- CONFIGURATION=release
- SLANG_TEST_CATEGORY=smoke
- os: linux
compiler: gcc
env:
- CONFIGURATION=release
- SLANG_TEST_CATEGORY=full
- SLANG_DEPLOY=true
# Travis wants to default to a build script that invokes
# `./configure && make && make test` which is appropriate
# for autoconf, but I don't want to get into that mess..
#
script: make && make test
before_deploy: |
export SLANG_OS_NAME=${TRAVIS_OS_NAME}
export SLANG_ARCH_NAME=`uname -p`
export SLANG_TAG=${TRAVIS_TAG#v}
export SLANG_BINARY_ARCHIVE=slang-${SLANG_TAG}-${SLANG_OS_NAME}-${SLANG_ARCH_NAME}.zip
zip -r ${SLANG_BINARY_ARCHIVE} bin/*/*/slangc bin/*/*/libslang.so bin/*/*/libslang-glslang.so docs/*.md README.md LICENSE slang.h
# We are going to deploy to GitHub Releases
# on a successful build from a tag, but only
# on the one target in the build matrix that set
# `SLANG_DEPLOY`
deploy:
provider: releases
api_key: "$GITHUB_RELEASE_TOKEN"
file: "$SLANG_BINARY_ARCHIVE"
skip_cleanup: true
on:
condition: "$SLANG_DEPLOY = true"
tags: true
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...