https://github.com/openai/baselines
Revision 165c62257216fad44aa13fa924e2b224703d234d authored by AurelianTactics on 30 October 2018, 17:13:39 UTC, committed by pzhokhov on 30 October 2018, 17:13:39 UTC
* DDPG has unused 'seed' argument DeepQ, PPO2, ACER, trpo_mpi, A2C, and ACKTR have the code for: ``` from baselines.common import set_global_seeds ... def learn(...): ... set_global_seeds(seed) ``` DDPG has the argument 'seed=None' but doesn't have the two lines of code needed to set the global seeds. * DDPG: duplicate variable assignment variable nb_actions assigned same value twice in space of 10 lines nb_actions = env.action_space.shape[-1] * DDPG: noise_type 'normal_x' and 'ou_x' cause assert noise_type default 'adaptive-param_0.2' works but the arguments that change from parameter noise to actor noise (like 'normal_0.2' and 'ou_0.2' cause an assert message and DDPG not to run. Issue is noise following block: ''' if self.action_noise is not None and apply_noise: noise = self.action_noise() assert noise.shape == action.shape action += noise ''' noise is not nested: [number_of_actions] actions is nested: [[number_of_actions]] Can either nest noise or unnest actions * Revert "DDPG: noise_type 'normal_x' and 'ou_x' cause assert" * DDPG: noise_type 'normal_x' and 'ou_x' cause AssertionError noise_type default 'adaptive-param_0.2' works but the arguments that change from parameter noise to actor noise (like 'normal_0.2' and 'ou_0.2') cause an assert message and DDPG not to run. Issue is the following block: ''' if self.action_noise is not None and apply_noise: noise = self.action_noise() assert noise.shape == action.shape action += noise ''' noise is not nested: [number_of_actions] action is nested: [[number_of_actions]] Hence the shapes do not pass the assert line even though the action += noise line is correct
1 parent 93c7cc2
Tip revision: 165c62257216fad44aa13fa924e2b224703d234d authored by AurelianTactics on 30 October 2018, 17:13:39 UTC
DDPG: noise_type 'normal_x' and 'ou_x' cause AssertionError (#680)
DDPG: noise_type 'normal_x' and 'ou_x' cause AssertionError (#680)
Tip revision: 165c622
File | Mode | Size |
---|---|---|
cartpole.gif | -rw-r--r-- | 327.1 KB |
fetchPickAndPlaceContrast.png | -rw-r--r-- | 68.3 KB |
logo.jpg | -rw-r--r-- | 118.8 KB |
Computing file changes ...