Skip to main content

Browse the archive

https://github.com/web-platform-tests/wpt
26 December 2018, 22:31:15 UTC
Revision 168e0e121c233c19292757f66fd949a444efffc1 authored by Philip Jägenstedt on 04 April 2018, 15:24:36 UTC, committed by Blink WPT Bot on 04 April 2018, 15:45:44 UTC 
Simplify assert_throws in two places where error messages were passed
 
This was discovered in
https://chromium-review.googlesource.com/c/chromium/src/+/980757 by
letting assert_throws also check that the message matches. That change
itself isn't a good idea, but it's still just as well to use plain
TypeErrors here to not make it seems like more is being tested than in
fact is.

Change-Id: I8f964e9b25cc94942cb86f3ee0017530f230e04a
Reviewed-on: https://chromium-review.googlesource.com/995192
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548060}
1 parent e502344
History
Tip revision: 168e0e121c233c19292757f66fd949a444efffc1 authored by Philip Jägenstedt on 04 April 2018, 15:24:36 UTC
Simplify assert_throws in two places where error messages were passed
Tip revision: 168e0e1
File Mode Size
custom-element-registry
htmlconstructor
parser
reactions
resources
upgrading
CustomElementRegistry.html -rw-r--r-- 30.6 KB
Document-createElement-svg.svg -rw-r--r-- 1.1 KB
Document-createElement.html -rw-r--r-- 16.6 KB
Document-createElementNS.html -rw-r--r-- 3.2 KB
HTMLElement-constructor.html -rw-r--r-- 4.5 KB
OWNERS -rw-r--r-- 108 bytes
adopted-callback.html -rw-r--r-- 5.9 KB
attribute-changed-callback.html -rw-r--r-- 12.3 KB
builtin-coverage.html -rw-r--r-- 8.0 KB
connected-callbacks.html -rw-r--r-- 3.7 KB
custom-element-reaction-queue.html -rw-r--r-- 6.9 KB
disconnected-callbacks.html -rw-r--r-- 3.9 KB
historical.html -rw-r--r-- 1.3 KB
microtasks-and-constructors.html -rw-r--r-- 3.4 KB
pseudo-class-defined.html -rw-r--r-- 4.1 KB
reaction-timing.html -rw-r--r-- 3.2 KB
upgrading.html -rw-r--r-- 10.3 KB
back to top