https://github.com/apache/spark
Revision 16986b29e22553797e0e78df445eac94a44285c7 authored by Wenchen Fan on 18 December 2018, 18:09:56 UTC, committed by Dongjoon Hyun on 18 December 2018, 18:10:30 UTC
## What changes were proposed in this pull request? This is kind of a followup of https://github.com/apache/spark/pull/23239 The `UnsafeProject` will normalize special float/double values(NaN and -0.0), so the sorter doesn't have to handle it. However, for consistency and future-proof, this PR proposes to normalize `-0.0` in the prefix comparator, so that it's same with the normal ordering. Note that prefix comparator handles NaN as well. This is not a bug fix, but a safe guard. ## How was this patch tested? existing tests Closes #23334 from cloud-fan/sort. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit befca983d2da4f7828aa7a7cd7345d17c4f291dd) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
1 parent 0a69787
Tip revision: 16986b29e22553797e0e78df445eac94a44285c7 authored by Wenchen Fan on 18 December 2018, 18:09:56 UTC
[SPARK-26382][CORE] prefix comparator should handle -0.0
[SPARK-26382][CORE] prefix comparator should handle -0.0
Tip revision: 16986b2
| File | Mode | Size |
|---|---|---|
| .github | ||
| R | ||
| assembly | ||
| bin | ||
| build | ||
| common | ||
| conf | ||
| core | ||
| data | ||
| dev | ||
| docs | ||
| examples | ||
| external | ||
| graphx | ||
| hadoop-cloud | ||
| launcher | ||
| licenses | ||
| licenses-binary | ||
| mllib | ||
| mllib-local | ||
| project | ||
| python | ||
| repl | ||
| resource-managers | ||
| sbin | ||
| sql | ||
| streaming | ||
| tools | ||
| .gitattributes | -rw-r--r-- | 40 bytes |
| .gitignore | -rw-r--r-- | 1.3 KB |
| CONTRIBUTING.md | -rw-r--r-- | 995 bytes |
| LICENSE | -rw-r--r-- | 13.0 KB |
| LICENSE-binary | -rw-r--r-- | 20.9 KB |
| NOTICE | -rw-r--r-- | 1.5 KB |
| NOTICE-binary | -rw-r--r-- | 41.9 KB |
| README.md | -rw-r--r-- | 3.9 KB |
| appveyor.yml | -rw-r--r-- | 2.2 KB |
| pom.xml | -rw-r--r-- | 100.4 KB |
| scalastyle-config.xml | -rw-r--r-- | 18.0 KB |
Computing file changes ...
