Revision 18bc7bd523e0fc5be8d76bf84bde733a97a8c375 authored by Andy Lutomirski on 10 August 2016, 09:29:14 UTC, committed by Ingo Molnar on 11 August 2016, 09:15:00 UTC
The initialization process for trampoline_cr4_features and
mmu_cr4_features was confusing.  The intent is for mmu_cr4_features
and *trampoline_cr4_features to stay in sync, but
trampoline_cr4_features is NULL until setup_real_mode() runs.  The
old code synchronized *trampoline_cr4_features *twice*, once in
setup_real_mode() and once in setup_arch().  It also initialized
mmu_cr4_features in setup_real_mode(), which causes the actual value
of mmu_cr4_features to potentially depend on when setup_real_mode()
is called.

With this patch, mmu_cr4_features is initialized directly in
setup_arch(), and *trampoline_cr4_features is synchronized to
mmu_cr4_features when the trampoline is set up.

After this patch, it should be safe to defer setup_real_mode().

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mario Limonciello <mario_limonciello@dell.com>
Cc: Matt Fleming <mfleming@suse.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/d48a263f9912389b957dd495a7127b009259ffe0.1470821230.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 007b756
History
File Mode Size
ib.h -rw-r--r-- 3.3 KB
ib_addr.h -rw-r--r-- 9.8 KB
ib_cache.h -rw-r--r-- 6.2 KB
ib_cm.h -rw-r--r-- 18.7 KB
ib_fmr_pool.h -rw-r--r-- 3.4 KB
ib_mad.h -rw-r--r-- 27.3 KB
ib_marshall.h -rw-r--r-- 2.0 KB
ib_pack.h -rw-r--r-- 8.8 KB
ib_pma.h -rw-r--r-- 5.4 KB
ib_sa.h -rw-r--r-- 16.5 KB
ib_smi.h -rw-r--r-- 5.5 KB
ib_umem.h -rw-r--r-- 3.5 KB
ib_umem_odp.h -rw-r--r-- 5.2 KB
ib_verbs.h -rw-r--r-- 95.0 KB
iw_cm.h -rw-r--r-- 8.4 KB
iw_portmap.h -rw-r--r-- 7.5 KB
mr_pool.h -rw-r--r-- 954 bytes
opa_port_info.h -rw-r--r-- 14.7 KB
opa_smi.h -rw-r--r-- 4.4 KB
rdma_cm.h -rw-r--r-- 12.9 KB
rdma_cm_ib.h -rw-r--r-- 2.1 KB
rdma_netlink.h -rw-r--r-- 2.5 KB
rdma_vt.h -rw-r--r-- 14.4 KB
rdmavt_cq.h -rw-r--r-- 3.4 KB
rdmavt_mr.h -rw-r--r-- 4.7 KB
rdmavt_qp.h -rw-r--r-- 16.8 KB
rw.h -rw-r--r-- 2.7 KB

back to top