Revision 18d685dd4f0b48df6a7d270bf27d4e18b76b2311 authored by Amanpreet Singh on 12 February 2021, 20:29:05 UTC, committed by Facebook GitHub Bot on 12 February 2021, 20:30:49 UTC
Summary: The diff address a bug that was introduced in text position ids by a recent change in https://github.com/facebookresearch/mmf/issues/760. The fix is to actually make single feature dim modalities B X 1 X D before passing to backend instead of making multiple assumption in backend layer which tend to be conflicting with text input ids. This also adds some comments to better explain stack version of text. The PR also refactors MMFT to be more readble and reduce cyclomatic complexity. Finally, this PR adds extensive tests to make sure a change like https://github.com/facebookresearch/mmf/issues/760 doesn't break MMFT again. Pull Request resolved: https://github.com/facebookresearch/mmf/pull/774 Test Plan: Adds extensive tests for MMFT Tested disney's model. Reviewed By: ytsheng Differential Revision: D26410408 Pulled By: apsdehal fbshipit-source-id: 059af500739b3463219b8594b3bb72001326a0a2
1 parent 95a2225
| File | Mode | Size |
|---|---|---|
| .circleci | ||
| .github | ||
| docs | ||
| mmf | ||
| mmf_cli | ||
| projects | ||
| tests | ||
| tools | ||
| website | ||
| .editorconfig | -rw-r--r-- | 191 bytes |
| .flake8 | -rw-r--r-- | 187 bytes |
| .gitignore | -rw-r--r-- | 255 bytes |
| .pre-commit-config.yaml | -rw-r--r-- | 1.1 KB |
| LICENSE | -rw-r--r-- | 1.5 KB |
| MANIFEST.in | -rw-r--r-- | 130 bytes |
| NOTICES | -rw-r--r-- | 2.7 KB |
| README.md | -rw-r--r-- | 2.2 KB |
| pyproject.toml | -rw-r--r-- | 854 bytes |
| requirements.txt | -rw-r--r-- | 290 bytes |
| setup.py | -rw-r--r-- | 5.0 KB |
Computing file changes ...
