Revision - 199cac7 - Strip trailing slashes in `JULIA_DEPOT_PATH` when embedding [...] - origin: https://github.com/JuliaLang/julia

visit type:

https://github.com/JuliaLang/julia

19 April 2024, 06:28:37 UTC

Revision 199cac7d1d474d6bf512943fb6485a53e574e8eb authored by Elliot Saba on 27 October 2023, 17:38:05 UTC, committed by GitHub on 27 October 2023, 17:38:05 UTC

Strip trailing slashes in `JULIA_DEPOT_PATH` when embedding `@depot` (#51892)

The new relocatable cache file work uses simple text substitution when
stripping out the depot from a cache file's paths, and when substituting
it in again over the `@depot` marker. However, if a user starts julia
with `JULIA_DEPOT_PATH=/opt/foo/`, the embedded path for `Foo.jl`'s
includes list will look like `@depotpackages/Foo/XYZ/src/Foo.jl`, and if
the user then uses `JULIA_DEPOT_PATH=/opt/foo` (which should be
equivalent) the cache file will fail to load with the message:

```
Failed to determine depot from srctext files
```

This commit standardizes the serialization format to always contain a
trailing `pathsep()`, so that textual substitution is more likely to
work regardless of slightly-inconsistent `JULIA_DEPOT_PATH` settings.

1 parent 8382d51

Files
Changes

Permalinks

Tip revision: 199cac7d1d474d6bf512943fb6485a53e574e8eb authored by Elliot Saba on 27 October 2023, 17:38:05 UTC
Strip trailing slashes in `JULIA_DEPOT_PATH` when embedding `@depot` (#51892)

Tip revision: 199cac7

File	Mode	Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version	-rw-r--r--	5 bytes
.clang-format	-rw-r--r--	3.3 KB
.clangd	-rw-r--r--	114 bytes
.codecov.yml	-rw-r--r--	52 bytes
.git-blame-ignore-revs	-rw-r--r--	371 bytes
.gitattributes	-rw-r--r--	65 bytes
.gitignore	-rw-r--r--	523 bytes
.mailmap	-rw-r--r--	12.7 KB
CITATION.bib	-rw-r--r--	513 bytes
CITATION.cff	-rw-r--r--	940 bytes
CONTRIBUTING.md	-rw-r--r--	23.4 KB
HISTORY.md	-rw-r--r--	372.8 KB
LICENSE.md	-rw-r--r--	1.3 KB
Make.inc	-rw-r--r--	55.7 KB
Makefile	-rw-r--r--	30.3 KB
NEWS.md	-rw-r--r--	4.7 KB
README.md	-rw-r--r--	7.3 KB
THIRDPARTY.md	-rw-r--r--	3.8 KB
VERSION	-rw-r--r--	11 bytes
julia.spdx.json	-rw-r--r--	35.8 KB
pkgimage.mk	-rw-r--r--	5.9 KB
sysimage.mk	-rw-r--r--	4.2 KB
typos.toml	-rw-r--r--	78 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/JuliaLang/julia

Strip trailing slashes in `JULIA_DEPOT_PATH` when embedding `@depot` (#51892)

README.md