Revision 1a07a94b47b1f528f39c3e6187b5eaf02efe44ea authored by Ondrej Jirman on 05 April 2019, 23:30:48 UTC, committed by Maxime Ripard on 08 April 2019, 08:30:23 UTC
There are two problems here: 1. Not all clk_data->hws[] need to be initialized, depending on various configured quirks. This leads to NULL ptr deref in clk_hw_unregister_gate() in sun8i_tcon_top_unbind() 2. If there is error when registering the clk_data->hws[], err_unregister_gates error path will try to unregister IS_ERR()=true (invalid) pointer. For problem (1) I have this stack trace: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 Call trace: clk_hw_unregister+0x8/0x18 clk_hw_unregister_gate+0x14/0x28 sun8i_tcon_top_unbind+0x2c/0x60 component_unbind.isra.4+0x2c/0x50 component_bind_all+0x1d4/0x230 sun4i_drv_bind+0xc4/0x1a0 try_to_bring_up_master+0x164/0x1c0 __component_add+0xa0/0x168 component_add+0x10/0x18 sun8i_dw_hdmi_probe+0x18/0x20 platform_drv_probe+0x3c/0x70 really_probe+0xcc/0x278 driver_probe_device+0x34/0xa8 Problem (2) was identified by head scratching. Signed-off-by: Ondrej Jirman <megous@megous.com> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190405233048.3823-1-megous@megous.com
1 parent b85d00b
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.1 KB |
| Makefile | -rw-r--r-- | 721 bytes |
| dsa.c | -rw-r--r-- | 8.3 KB |
| dsa2.c | -rw-r--r-- | 16.4 KB |
| dsa_priv.h | -rw-r--r-- | 6.4 KB |
| legacy.c | -rw-r--r-- | 15.7 KB |
| master.c | -rw-r--r-- | 7.7 KB |
| port.c | -rw-r--r-- | 10.9 KB |
| slave.c | -rw-r--r-- | 42.7 KB |
| switch.c | -rw-r--r-- | 8.6 KB |
| tag_brcm.c | -rw-r--r-- | 5.2 KB |
| tag_dsa.c | -rw-r--r-- | 3.8 KB |
| tag_edsa.c | -rw-r--r-- | 4.4 KB |
| tag_gswip.c | -rw-r--r-- | 2.7 KB |
| tag_ksz.c | -rw-r--r-- | 4.5 KB |
| tag_lan9303.c | -rw-r--r-- | 4.4 KB |
| tag_mtk.c | -rw-r--r-- | 3.1 KB |
| tag_qca.c | -rw-r--r-- | 3.2 KB |
| tag_trailer.c | -rw-r--r-- | 2.1 KB |
Computing file changes ...
