Skip to main content

Browse the archive

Revision 1a698128c15bce0c05b0664bb1458842e1e55511 authored by Tim Foley on 06 June 2018, 04:35:48 UTC, committed by GitHub on 06 June 2018, 04:35:48 UTC 
Fix atomic operations on RWBuffer (#593)
 
* Fix atomic operations on RWBuffer

An earlier change added support for passing true pointers to `__ref` parameters to fix the global `Interlocked*()` functions when applied to `groupshared` variables or `RWStructureBuffer<T>` elements.
That change didn't apply to `RWBuffer<T>` or `RWTexture2D<T>`, etc. because those types had so far only declared `get` and `set` accessors, but not any `ref` accessors (which return a pointer).

The main fixes here are:

* Add `ref` accessors to the subscript oeprations on the `RW*` resource types

* Adjust the logic for emitting calls to subscript accessors so that we don't get quite as eager about invoking a `ref` accessor, and instead try to invoke just a `get` or `set` accessor when these will suffice. This is important for Vulkan cross-compilation, where we don't yet support the semantics of our `ref` accessors.

* Add a test case for atomics on a `RWBuffer`

* Fix up `render-test` so that we can specify a format for a buffer resource, which allows us to use things other than `*StructuredBuffer` and `*ByteAddressBuffer`. The work there is probably not complete; I just did what I could to get the test working.

* A bunch of files got whitespace edits thanks to the fact that I'm using editorconfig and others on the project seemingly arent...

* fixup: remove ifdefed-out code
1 parent 8b16bbf
Raw File
.travis.yml 
# .travis.yml
#
# This is the configuration file to drive Travis CI for Slang.

language: cpp

env:
  - SLANG_TEST_FLAGS=-travis

# Build and test (clang, gcc) x (debug, release)
#
# We customize the set of tests run per-target to
# avoid having the build take too long.
matrix:
  include:
    - os: linux
      compiler: gcc
      env:
        - CONFIGURATION=debug
        - SLANG_TEST_CATEGORY=smoke
    - os: linux
      compiler: clang
      env:
        - CONFIGURATION=debug
        - SLANG_TEST_CATEGORY=smoke
    - os: linux
      compiler: clang
      env:
        - CONFIGURATION=release
        - SLANG_TEST_CATEGORY=smoke
    - os: linux
      compiler: gcc
      env:
        - CONFIGURATION=release
        - SLANG_TEST_CATEGORY=full
        - SLANG_DEPLOY=true

# Travis wants to default to a build script that invokes
# `./configure && make && make test` which is appropriate
# for autoconf, but I don't want to get into that mess..
#
script: make && make test

before_deploy: |
  export SLANG_OS_NAME=${TRAVIS_OS_NAME}
  export SLANG_ARCH_NAME=`uname -p`
  export SLANG_TAG=${TRAVIS_TAG#v}
  export SLANG_BINARY_ARCHIVE=slang-${SLANG_TAG}-${SLANG_OS_NAME}-${SLANG_ARCH_NAME}.zip
  zip -r ${SLANG_BINARY_ARCHIVE} bin/*/*/slangc bin/*/*/libslang.so bin/*/*/libslang-glslang.so docs/*.md README.md LICENSE slang.h

# We are going to deploy to GitHub Releases
# on a successful build from a tag, but only
# on the one target in the build matrix that set
# `SLANG_DEPLOY`
deploy:
  provider: releases
  api_key: "$GITHUB_RELEASE_TOKEN"
  file: "$SLANG_BINARY_ARCHIVE"
  skip_cleanup: true
  on:
    condition: "$SLANG_DEPLOY =  true"
    tags: true
back to top