https://github.com/torvalds/linux
Revision 1b3922a8bc74231f9a767d1be6d9a061a4d4eeab authored by Qu Wenruo on 08 January 2019, 06:08:18 UTC, committed by David Sterba on 10 January 2019, 16:13:00 UTC
[BUG] Linux v5.0-rc1 will fail fstests/btrfs/163 with the following kernel message: BTRFS error (device dm-6): dev extent devid 1 physical offset 13631488 len 8388608 is beyond device boundary 0 BTRFS error (device dm-6): failed to verify dev extents against chunks: -117 BTRFS error (device dm-6): open_ctree failed [CAUSE] Commit cf90d884b347 ("btrfs: Introduce mount time chunk <-> dev extent mapping check") introduced strict check on dev extents. We use btrfs_find_device() with dev uuid and fs uuid set to NULL, and only dependent on @devid to find the real device. For seed devices, we call clone_fs_devices() in open_seed_devices() to allow us search seed devices directly. However clone_fs_devices() just populates devices with devid and dev uuid, without populating other essential members, like disk_total_bytes. This makes any device returned by btrfs_find_device(fs_info, devid, NULL, NULL) is just a dummy, with 0 disk_total_bytes, and any dev extents on the seed device will not pass the device boundary check. [FIX] This patch will try to verify the device returned by btrfs_find_device() and if it's a dummy then re-search in seed devices. Fixes: cf90d884b347 ("btrfs: Introduce mount time chunk <-> dev extent mapping check") CC: stable@vger.kernel.org # 4.19+ Reported-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent a6d8654
Tip revision: 1b3922a8bc74231f9a767d1be6d9a061a4d4eeab authored by Qu Wenruo on 08 January 2019, 06:08:18 UTC
btrfs: Use real device structure to verify dev extent
btrfs: Use real device structure to verify dev extent
Tip revision: 1b3922a
File | Mode | Size |
---|---|---|
9p | ||
adfs | ||
affs | ||
afs | ||
autofs | ||
befs | ||
bfs | ||
btrfs | ||
cachefiles | ||
ceph | ||
cifs | ||
coda | ||
configfs | ||
cramfs | ||
crypto | ||
debugfs | ||
devpts | ||
dlm | ||
ecryptfs | ||
efivarfs | ||
efs | ||
exofs | ||
exportfs | ||
ext2 | ||
ext4 | ||
f2fs | ||
fat | ||
freevxfs | ||
fscache | ||
fuse | ||
gfs2 | ||
hfs | ||
hfsplus | ||
hostfs | ||
hpfs | ||
hugetlbfs | ||
isofs | ||
jbd2 | ||
jffs2 | ||
jfs | ||
kernfs | ||
lockd | ||
minix | ||
nfs | ||
nfs_common | ||
nfsd | ||
nilfs2 | ||
nls | ||
notify | ||
ntfs | ||
ocfs2 | ||
omfs | ||
openpromfs | ||
orangefs | ||
overlayfs | ||
proc | ||
pstore | ||
qnx4 | ||
qnx6 | ||
quota | ||
ramfs | ||
reiserfs | ||
romfs | ||
squashfs | ||
sysfs | ||
sysv | ||
tracefs | ||
ubifs | ||
udf | ||
ufs | ||
xfs | ||
Kconfig | -rw-r--r-- | 7.4 KB |
Kconfig.binfmt | -rw-r--r-- | 7.2 KB |
Makefile | -rw-r--r-- | 4.2 KB |
aio.c | -rw-r--r-- | 54.5 KB |
anon_inodes.c | -rw-r--r-- | 4.5 KB |
attr.c | -rw-r--r-- | 9.7 KB |
bad_inode.c | -rw-r--r-- | 5.3 KB |
binfmt_aout.c | -rw-r--r-- | 10.8 KB |
binfmt_elf.c | -rw-r--r-- | 63.8 KB |
binfmt_elf_fdpic.c | -rw-r--r-- | 47.3 KB |
binfmt_em86.c | -rw-r--r-- | 2.8 KB |
binfmt_flat.c | -rw-r--r-- | 27.7 KB |
binfmt_misc.c | -rw-r--r-- | 18.3 KB |
binfmt_script.c | -rw-r--r-- | 3.0 KB |
block_dev.c | -rw-r--r-- | 53.8 KB |
buffer.c | -rw-r--r-- | 89.9 KB |
char_dev.c | -rw-r--r-- | 16.6 KB |
compat.c | -rw-r--r-- | 3.4 KB |
compat_binfmt_elf.c | -rw-r--r-- | 3.4 KB |
compat_ioctl.c | -rw-r--r-- | 31.0 KB |
coredump.c | -rw-r--r-- | 21.2 KB |
d_path.c | -rw-r--r-- | 11.2 KB |
dax.c | -rw-r--r-- | 45.7 KB |
dcache.c | -rw-r--r-- | 81.2 KB |
dcookies.c | -rw-r--r-- | 7.0 KB |
direct-io.c | -rw-r--r-- | 40.8 KB |
drop_caches.c | -rw-r--r-- | 1.6 KB |
eventfd.c | -rw-r--r-- | 10.8 KB |
eventpoll.c | -rw-r--r-- | 62.8 KB |
exec.c | -rw-r--r-- | 47.0 KB |
fcntl.c | -rw-r--r-- | 23.3 KB |
fhandle.c | -rw-r--r-- | 6.8 KB |
file.c | -rw-r--r-- | 23.4 KB |
file_table.c | -rw-r--r-- | 10.0 KB |
filesystems.c | -rw-r--r-- | 6.2 KB |
fs-writeback.c | -rw-r--r-- | 70.4 KB |
fs_pin.c | -rw-r--r-- | 2.0 KB |
fs_struct.c | -rw-r--r-- | 3.3 KB |
inode.c | -rw-r--r-- | 56.6 KB |
internal.h | -rw-r--r-- | 5.0 KB |
ioctl.c | -rw-r--r-- | 17.7 KB |
iomap.c | -rw-r--r-- | 53.1 KB |
libfs.c | -rw-r--r-- | 31.8 KB |
locks.c | -rw-r--r-- | 73.1 KB |
mbcache.c | -rw-r--r-- | 12.0 KB |
mount.h | -rw-r--r-- | 3.9 KB |
mpage.c | -rw-r--r-- | 21.1 KB |
namei.c | -rw-r--r-- | 123.0 KB |
namespace.c | -rw-r--r-- | 84.6 KB |
no-block.c | -rw-r--r-- | 688 bytes |
nsfs.c | -rw-r--r-- | 6.2 KB |
open.c | -rw-r--r-- | 28.4 KB |
pipe.c | -rw-r--r-- | 26.9 KB |
pnode.c | -rw-r--r-- | 15.3 KB |
pnode.h | -rw-r--r-- | 1.9 KB |
posix_acl.c | -rw-r--r-- | 21.4 KB |
proc_namespace.c | -rw-r--r-- | 7.8 KB |
read_write.c | -rw-r--r-- | 49.6 KB |
readdir.c | -rw-r--r-- | 11.4 KB |
select.c | -rw-r--r-- | 34.6 KB |
seq_file.c | -rw-r--r-- | 24.4 KB |
signalfd.c | -rw-r--r-- | 9.0 KB |
splice.c | -rw-r--r-- | 39.7 KB |
stack.c | -rw-r--r-- | 2.5 KB |
stat.c | -rw-r--r-- | 19.4 KB |
statfs.c | -rw-r--r-- | 9.7 KB |
super.c | -rw-r--r-- | 40.4 KB |
sync.c | -rw-r--r-- | 9.9 KB |
timerfd.c | -rw-r--r-- | 13.4 KB |
userfaultfd.c | -rw-r--r-- | 50.3 KB |
utimes.c | -rw-r--r-- | 7.4 KB |
xattr.c | -rw-r--r-- | 23.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...