https://github.com/torvalds/linux
Revision 1bd3a76880b2bce017987cf53780b372cf59528e authored by Zhu Wang on 19 August 2023, 08:39:41 UTC, committed by Martin K. Petersen on 25 August 2023, 02:30:32 UTC
Commit 41320b18a0e0 ("scsi: snic: Fix possible memory leak if device_add()
fails") fixed the memory leak caused by dev_set_name() when device_add()
failed. However, it did not consider that 'tgt' has already been released
when put_device(&tgt->dev) is called. Remove kfree(tgt) in the error path
to avoid double free of 'tgt' and move put_device(&tgt->dev) after the
removed kfree(tgt) to avoid a use-after-free.

Fixes: 41320b18a0e0 ("scsi: snic: Fix possible memory leak if device_add() fails")
Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Link: https://lore.kernel.org/r/20230819083941.164365-1-wangzhu9@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 60c5fd2
History
Tip revision: 1bd3a76880b2bce017987cf53780b372cf59528e authored by Zhu Wang on 19 August 2023, 08:39:41 UTC
scsi: snic: Fix double free in snic_tgt_create()
Tip revision: 1bd3a76
File Mode Size
apparmor
bpf
integrity
keys
landlock
loadpin
lockdown
safesetid
selinux
smack
tomoyo
yama
Kconfig -rw-r--r-- 9.4 KB
Kconfig.hardening -rw-r--r-- 14.5 KB
Makefile -rw-r--r-- 892 bytes
commoncap.c -rw-r--r-- 42.5 KB
device_cgroup.c -rw-r--r-- 21.8 KB
inode.c -rw-r--r-- 10.6 KB
lsm_audit.c -rw-r--r-- 10.8 KB
min_addr.c -rw-r--r-- 1.3 KB
security.c -rw-r--r-- 150.5 KB

back to top