Revision 1c118b8226922d225a7df4127926ed2a2d73baaf authored by Xiao Guangrong on 18 July 2013, 04:52:37 UTC, committed by Paolo Bonzini on 18 July 2013, 10:26:57 UTC
Currently, fast page fault incorrectly tries to fix mmio page fault when
the generation number is invalid (spte.gen != kvm.gen).  It then returns
to guest to retry the fault since it sees the last spte is nonpresent.
This causes an infinite loop.

Since fast page fault only works for direct mmu, the issue exists when
1) tdp is enabled. It is only triggered only on AMD host since on Intel host
   the mmio page fault is recognized as ept-misconfig whose handler call
   fault-page path with error_code = 0

2) guest paging is disabled. Under this case, the issue is hardly discovered
   since paging disable is short-lived and the sptes will be invalid after
   memslot changed for 150 times

Fix it by filtering out MMIO page faults in page_fault_can_be_fast.

Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent ad81f05
History
File Mode Size
ac97
ali5451
asihpi
au88x0
aw2
ca0106
cs46xx
cs5535audio
ctxfi
echoaudio
emu10k1
hda
ice1712
korg1212
lola
lx6464es
mixart
nm256
oxygen
pcxhr
riptide
rme9652
trident
vx222
ymfpci
Kconfig -rw-r--r-- 24.6 KB
Makefile -rw-r--r-- 2.1 KB
ad1889.c -rw-r--r-- 26.1 KB
ad1889.h -rw-r--r-- 7.9 KB
ak4531_codec.c -rw-r--r-- 17.1 KB
als300.c -rw-r--r-- 23.5 KB
als4000.c -rw-r--r-- 31.4 KB
atiixp.c -rw-r--r-- 45.6 KB
atiixp_modem.c -rw-r--r-- 35.7 KB
azt3328.c -rw-r--r-- 85.2 KB
azt3328.h -rw-r--r-- 15.5 KB
bt87x.c -rw-r--r-- 29.6 KB
cmipci.c -rw-r--r-- 101.8 KB
cs4281.c -rw-r--r-- 64.4 KB
cs5530.c -rw-r--r-- 7.1 KB
ens1370.c -rw-r--r-- 79.1 KB
ens1371.c -rw-r--r-- 38 bytes
es1938.c -rw-r--r-- 55.3 KB
es1968.c -rw-r--r-- 79.4 KB
fm801.c -rw-r--r-- 41.6 KB
intel8x0.c -rw-r--r-- 92.7 KB
intel8x0m.c -rw-r--r-- 37.5 KB
maestro3.c -rw-r--r-- 81.6 KB
rme32.c -rw-r--r-- 57.6 KB
rme96.c -rw-r--r-- 66.3 KB
sis7019.c -rw-r--r-- 40.0 KB
sis7019.h -rw-r--r-- 13.3 KB
sonicvibes.c -rw-r--r-- 51.4 KB
via82xx.c -rw-r--r-- 77.6 KB
via82xx_modem.c -rw-r--r-- 34.4 KB

back to top