https://github.com/torvalds/linux
Revision 1c5c12ee308aacf635c8819cd4baa3bd58f8a8b7 authored by Tao Ren on 24 April 2019, 01:43:32 UTC, committed by David S. Miller on 24 April 2019, 04:15:15 UTC
Previously BMC's MAC address is calculated by simply adding 1 to the
last byte of network controller's MAC address, and it produces incorrect
result when network controller's MAC address ends with 0xFF.

The problem can be fixed by calling eth_addr_inc() function to increment
MAC address; besides, the MAC address is also validated before assigning
to BMC.

Fixes: cb10c7c0dfd9 ("net/ncsi: Add NCSI Broadcom OEM command")
Signed-off-by: Tao Ren <taoren@fb.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent ffbf987
History
Tip revision: 1c5c12ee308aacf635c8819cd4baa3bd58f8a8b7 authored by Tao Ren on 24 April 2019, 01:43:32 UTC
net/ncsi: handle overflow when incrementing mac address
Tip revision: 1c5c12e
File Mode Size
fallbacks
atomic-tbl.sh -rwxr-xr-x 3.3 KB
atomics.tbl -rwxr-xr-x 1.1 KB
check-atomics.sh -rwxr-xr-x 730 bytes
gen-atomic-fallback.sh -rwxr-xr-x 4.6 KB
gen-atomic-instrumented.sh -rwxr-xr-x 4.3 KB
gen-atomic-long.sh -rwxr-xr-x 2.1 KB
gen-atomics.sh -rw-r--r-- 591 bytes

back to top