swh:1:snp:b37d435721bbd450624165f334724e3585346499
Revision 1cefac0f876828632d234eb55f42579365664f3d authored by Anders Hartvoll Ruud on 08 October 2018, 09:31:26 UTC, committed by Blink WPT Bot on 08 October 2018, 09:42:19 UTC
In CSS Typed OM, types that are not yet supported by a specialized
CSSStyleValue subclass are represented by "direct" CSSStyleValue objects.
These objects are only valid for their associated property. For instance,
you may not get a (direct) CSSStyleValue object from 'color', and then
set it on 'background-color'; the (direct) CSSStyleValue acquired from
'color' is valid for 'color' only.

The same should apply for registered custom properties; a direct
CSSStyleValue acquired from '--x' is only valid for '--x'.

To do this, blink::CSSUnsupportedStyleValue must be aware of the
custom property name. This means the AtomicString with the custom property
name must be passed around to almost everything. However, if the property
at hand is not a custom property, I want to avoid AtomicString-ing the
name of the property. Hence there are DCHECKs to make sure this is avoided.

Reminder: this CL would be much less ... grotesque and perhaps less
error-prone if dynamic CSSProperties (Ribbon) were in place, but because
we like pain, we decided to not give that project a very high priority.

R=chrishtr@chromium.org

Bug: 641877
Change-Id: I99af4745d1d33365759e9fd4acef5082ab213229
Reviewed-on: https://chromium-review.googlesource.com/c/1257916
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597503}
1 parent a950440
History
Tip revision: 259d0612af038d14f2cd889a14a3adb6c9e96d96 authored by Josh Matthews on 23 December 2018, 05:25:51 UTC
Claim to support testdriver in servodriver
Tip revision: 259d061
File Mode Size
.well-known
2dcontext
BackgroundSync
FileAPI
IndexedDB
WebCryptoAPI
WebIDL
accelerometer
accname
acid
ambient-light
animation-worklet
annotation-model
annotation-protocol
annotation-vocab
apng
appmanifest
async-local-storage
audio-output
background-fetch
battery-status
beacon
bluetooth
clear-site-data
client-hints
clipboard-apis
common
compat
conformance-checkers
console
content-security-policy
cookie-store
cookies
core-aam
cors
credential-management
css
custom-elements
device-memory
docs
dom
domparsing
domxpath
dpub-aam
dpub-aria
editing
encoding
encrypted-media
entries-api
eventsource
feature-policy
fetch
fonts
fullscreen
gamepad
generic-sensor
geolocation-API
geolocation-sensor
graphics-aam
gyroscope
hr-time
html
html-longdesc
html-media-capture
imagebitmap-renderingcontext
images
inert
infrastructure
input-device-capabilities
input-events
interfaces
intersection-observer
js
keyboard-lock
keyboard-map
lifecycle
longtask-timing
magnetometer
mathml
media
media-capabilities
media-source
mediacapture-depth
mediacapture-fromelement
mediacapture-image
mediacapture-record
mediacapture-streams
mediasession
mimesniff
mixed-content
mst-content-hint
navigation-timing
netinfo
network-error-logging
notifications
offscreen-canvas
old-tests
orientation-event
orientation-sensor
origin-policy
page-visibility
paint-timing
payment-handler
payment-method-basic-card
payment-method-id
payment-request
performance-timeline
permissions
picture-in-picture
pointerevents
pointerlock
preload
presentation-api
priority-hints
proximity
push-api
quirks
referrer-policy
remote-playback
reporting
requestidlecallback
resize-observer
resource-timing
resources
screen-capture
screen-orientation
scroll-animations
secure-contexts
selection
server-timing
service-workers
shadow-dom
shape-detection
speech-api
storage
streams
subresource-integrity
svg
svg-aam
tools
touch-events
trusted-types
uievents
upgrade-insecure-requests
url
user-timing
vibration
visual-viewport
wai-aria
wake-lock
wasm
web-animations
web-locks
web-nfc
web-share
webaudio
webauthn
webdriver
webgl
webmessaging
webmidi
webrtc
webrtc-stats
websockets
webstorage
webusb
webvr
webvtt
webxr
workers
worklets
x-frame-options
xhr
.codecov.yml -rw-r--r-- 66 bytes
.gitignore -rw-r--r-- 340 bytes
.gitmodules -rw-r--r-- 138 bytes
.pyup.yml -rw-r--r-- 1.0 KB
.taskcluster.yml -rw-r--r-- 6.2 KB
.travis.yml -rw-r--r-- 3.3 KB
CODEOWNERS -rw-r--r-- 98 bytes
CONTRIBUTING.md -rw-r--r-- 1.6 KB
LICENSE.md -rw-r--r-- 5.1 KB
README.md -rw-r--r-- 17.3 KB
check_stability.ini -rw-r--r-- 463 bytes
lint.whitelist -rw-r--r-- 46.1 KB
serve.py -rw-r--r-- 263 bytes
server-side.md -rw-r--r-- 8.1 KB
testharness_runner.html -rw-r--r-- 95 bytes
update-built-tests.sh -rwxr-xr-x 208 bytes
wpt -rwxr-xr-x 95 bytes
wpt.py -rw-r--r-- 15 bytes

README.md

back to top