https://github.com/Microsoft/TypeScript
Revision 1cfab760e14e9f291c7176d95f81d716dc3dd37d authored by Nathan Shively-Sanders on 08 October 2018, 17:01:04 UTC, committed by GitHub on 08 October 2018, 17:01:04 UTC
`@constructor` put on anything incorrectly makes it a JS constructor. This is a problem for actual constructors, because getJSClassType doesn't work on actual classes. The fix is to make isJSConstructor require that its declaration is a function.
1 parent 95dc1f2
- HEAD
- refs/heads/3.9.2-insiders
- refs/heads/4.0-insiders
- refs/heads/4.6-insider-branch
- refs/heads/NonNullableClassic
- refs/heads/add-undefined-to-parameter-name-type
- refs/heads/allowAccessorsInAmbientContext
- refs/heads/always-suggesting-spelling-correction
- refs/heads/alwaysBeEmittingAny
- refs/heads/alwaysBindJsDoc
- refs/heads/alwaysCacheUnionIntersectionRelations
- refs/heads/annotateTransforms
- refs/heads/arbExt
- refs/heads/asyncSimpleArrow
- refs/heads/avoidFullWalkReturn
- refs/heads/avoidSharedClonesInAccessors
- refs/heads/avoidWidenedReturnTypes
- refs/heads/awaited
- refs/heads/awaitedType2WithLKG
- refs/heads/bak-release-4.4
- refs/heads/bak2-release-4.4
- refs/heads/becauseItsLiterallyTheWorst
- refs/heads/betterNeverErrors
- refs/heads/bindObjectTypesInJSDoc
- refs/heads/bindOperator
- refs/heads/braceSourceMaps
- refs/heads/buildInfoSize
- refs/heads/bumpTo5.0
- refs/heads/cacheGlobalTaggedTemplates
- refs/heads/cacheModuleResolution
- refs/heads/cacheScanIdentifier
- refs/heads/chakraHostPretty
- refs/heads/check-for-require-when-binding-commonjs
- refs/heads/checkNodeDeferredLists
- refs/heads/comparabilitySpecUpdate
- refs/heads/compilerPluginModel
- refs/heads/computed-property-names-are-const-contexts
- refs/heads/conditionalOriginalKeywordKind
- refs/heads/contextual-type-methods-only
- refs/heads/contextualFreshener
- refs/heads/contextuallyTypeImplementedProperties2
- refs/heads/contextuallyTypedArrowFunctionReturn
- refs/heads/controlFlowImplicitAny
- refs/heads/controlFlowLimit
- refs/heads/correctlyScopedtaggedTemplates-release-2.6
- refs/heads/crashFix(51162)
- refs/heads/dev/naoshl/test-branch
- refs/heads/dogfoodUnknownInCatchVariables
- refs/heads/dontUseThisBranchForExperimentalPipelineInProductionOrYouWillBeFired
- refs/heads/dump-variances
- refs/heads/eagerRemoveEmptyIntersections
- refs/heads/emptyObjectAndIndexSignatures
- refs/heads/emptyObjectUnionIntersection
- refs/heads/ensureNoEmptyEdits
- refs/heads/errorMessageImprovementsOnDiscriminant
- refs/heads/experimentRelativePaths
- refs/heads/experimentalTransforms
- refs/heads/exposeMatchFiles
- refs/heads/extensions
- refs/heads/factoryPerf
- refs/heads/fastPathSymbolIsSameReference
- refs/heads/feature/lspSession
- refs/heads/fix(33829)
- refs/heads/fix(50751)
- refs/heads/fix(52604)
- refs/heads/fix-51554
- refs/heads/fix-undefined-globalObjectType-in-symbol-merging
- refs/heads/fix13117
- refs/heads/fix33458
- refs/heads/fix33823
- refs/heads/fix33872
- refs/heads/fix35414-2
- refs/heads/fix37526
- refs/heads/fix37659
- refs/heads/fix37856
- refs/heads/fix37979
- refs/heads/fix39364
- refs/heads/fix41581
- refs/heads/fix41977
- refs/heads/fix44572
- refs/heads/fix44572-2
- refs/heads/fix48070
- refs/heads/fix49852
- refs/heads/fix53307
- refs/heads/fixAddMissingMemberTruncation
- refs/heads/fixCheckInReturnValueCodefix
- refs/heads/fixGenericSignatureRelation
- refs/heads/fixParserBracketMatching
- refs/heads/fixSharedCaching
- refs/heads/fixTransformFlagsForES2020
- refs/heads/fixTypeVariableLogicalAnd
- refs/heads/forEachChildTable-object
- refs/heads/forbid-function-named-require-in-js
- refs/heads/freezeTemplateObjects
- refs/heads/functionTypeRelations
- refs/heads/gabritto/alwaysError
- refs/heads/gabritto/issue40129
- refs/heads/gabritto/issue45801
- refs/heads/gabritto/issue46119
- refs/heads/gabritto/issue46140
- refs/heads/gabritto/issue48364
- refs/heads/gabritto/issue52121
- refs/heads/gabritto/issue52370
- refs/heads/gabritto/snippetorder
- refs/heads/getTypeAtLocation-support-class-expr
- refs/heads/harnessCleanup
- refs/heads/id-cleanup-2
- refs/heads/incremental
- refs/heads/inferPromiseTypeFromResolve
- refs/heads/inferToPromiseLikeTypes
- refs/heads/inferTypeExtendsWithTemplateInference
- refs/heads/internalModifier
- refs/heads/iteratorVoidResult
- refs/heads/lazyBind
- refs/heads/literallyBeLessStupidInCasts
- refs/heads/main
- refs/heads/make-spread-overwrite-error-more-lenient
- refs/heads/mappedObjectTypesSpec
- refs/heads/mappingsWithArrayJoin
- refs/heads/maybeFix39923
- refs/heads/mergeCommentWriter
- refs/heads/metadataDecoratorOption
- refs/heads/minestarks-synctest
- refs/heads/moduleResolutionLogs
- refs/heads/more-dym-plainjs-errors-on-classes
- refs/heads/multiline-backticks
- refs/heads/newlineInGulpfile
- refs/heads/no-objectAllocator
- refs/heads/noReductionOnContextuallyTypedArrays
- refs/heads/noRedundantIntersectionsInUnions
- refs/heads/nodeFactory-perf
- refs/heads/nullishCoalesceStage1
- refs/heads/objectCreateNull
- refs/heads/objectFreezeConstTypeParameter
- refs/heads/objectIdentifiersMap
- refs/heads/optimizeControlFlowEffects
- refs/heads/optimizeInstantiation
- refs/heads/optionalChainingStage1
- refs/heads/optionalVoidProperties
- refs/heads/overloadTagCompletions
- refs/heads/packageJsonWatch
- refs/heads/perfInServer
- refs/heads/pick-fix51538-to-4.9
- refs/heads/pipelineStage1
- refs/heads/placeholders
- refs/heads/plain-js-checker-errors
- refs/heads/possiblyVoid
- refs/heads/preAllocateMap
- refs/heads/preallocateContainers
- refs/heads/preloadPaths
- refs/heads/preserveSourceNewlinesAllTheThings
- refs/heads/promiseShim
- refs/heads/promised
- refs/heads/promisedType
- refs/heads/quickFixFunctionNames
- refs/heads/range-types
- refs/heads/rbuckton/WIP-extractPrinter
- refs/heads/rbuckton/WIP-parser
- refs/heads/rbuckton/WIP-vifs
- refs/heads/rbuckton/matchType
- refs/heads/rbuckton/pipeline
- refs/heads/rbuckton/promisedTypeWIP
- refs/heads/readonlyTypes
- refs/heads/reduce-megamorphism
- refs/heads/reduceIntersectionsByDiscriminant
- refs/heads/reduceStackDepth
- refs/heads/reducedInference
- refs/heads/refs
- refs/heads/relaxAssertionCallRestrictions
- refs/heads/release
- refs/heads/release-.20
- refs/heads/release-1.0.3
- refs/heads/release-1.1
- refs/heads/release-1.3
- refs/heads/release-1.4
- refs/heads/release-1.5
- refs/heads/release-1.7
- refs/heads/release-1.8
- refs/heads/release-2.0
- refs/heads/release-2.0.5
- refs/heads/release-2.1
- refs/heads/release-2.2
- refs/heads/release-2.3
- refs/heads/release-2.4
- refs/heads/release-2.5
- refs/heads/release-2.6
- refs/heads/release-2.7
- refs/heads/release-2.8
- refs/heads/release-2.9
- refs/heads/release-3.0
- refs/heads/release-3.1
- refs/heads/release-3.2
- refs/heads/release-3.3
- refs/heads/release-3.4
- refs/heads/release-3.5
- refs/heads/release-3.6
- refs/heads/release-3.7
- refs/heads/release-3.8
- refs/heads/release-3.9
- refs/heads/release-4.0
- refs/heads/release-4.1
- refs/heads/release-4.2
- refs/heads/release-4.3
- refs/heads/release-4.4
- refs/heads/release-4.4-insiders
- refs/heads/release-4.5
- refs/heads/release-4.6
- refs/heads/release-4.6-insiders
- refs/heads/release-4.7
- refs/heads/release-4.8
- refs/heads/release-4.8-cherry-pick-86f4962
- refs/heads/release-4.9
- refs/heads/release-5.0
- refs/heads/remove-external-compile-runner
- refs/heads/removeCompletions
- refs/heads/removeIdentityMapper
- refs/heads/removeNonNullAssertions
- refs/heads/removeWhitespace
- refs/heads/report-deprecation-object-literal-2
- refs/heads/resolutionSimplify
- refs/heads/restorePromiseAllOverloads
- refs/heads/revert-31893-enhancement/only-import-from-package-json
- refs/heads/revert-33074
- refs/heads/revert-41308-fix40251
- refs/heads/revert-49330-nullableImprovements
- refs/heads/safeNavigation
- refs/heads/server-vfs-support
- refs/heads/serverCommandsFromFile
- refs/heads/sharedTypes
- refs/heads/skipEffectFreeControlFlows
- refs/heads/skipExcessPropertyElaborations
- refs/heads/stop-double-dts-emit
- refs/heads/strictAny
- refs/heads/strictCompiler
- refs/heads/strongTypesForLargeErrors
- refs/heads/symboltracker-perf
- refs/heads/tagged-template-inference
- refs/heads/task29988
- refs/heads/this-types-for-all-methods
- refs/heads/throwOperator
- refs/heads/trackNodeRecurrenceInFormatting
- refs/heads/transforms-minGenerators
- refs/heads/triple-slash-jsdoc
- refs/heads/ts-nonewline
- refs/heads/ts-plugins-on-web
- refs/heads/turn-off-web-server
- refs/heads/typeOperations
- refs/heads/typePredicateOverloadCompat
- refs/heads/umdGlobal
- refs/heads/useAwaitedTypeForAwait
- refs/heads/useExplicitObjectLiteralsInConstructors
- refs/heads/useLessNodeId
- refs/heads/useNoPropertyAccessFromIndexSignature
- refs/heads/variadicPromiseAll
- refs/heads/vfs-vscode-sync-api-client
- refs/heads/voidContextualType
- refs/heads/watchPlugins
- refs/heads/watchVfs
- refs/heads/weakTypeChecksComparability
- refs/heads/weakenPromiseLike
- refs/heads/wip-decoratorsWithPrivateFieldAccess
- refs/heads/wrapImportInEmitter
- refs/reviewable/pr3642/r1
- refs/reviewable/pr3642/r2
- refs/reviewable/pr3642/r3
- refs/reviewable/pr3642/r4
- refs/reviewable/pr3642/r5
- refs/reviewable/pr3642/r6
- refs/reviewable/pr3642/r7
- refs/reviewable/pr3642/r8
- refs/reviewable/pr3642/r9
- refs/reviewable/pr3762/r1
- refs/reviewable/pr3762/r2
- refs/reviewable/pr3762/r3
- refs/reviewable/pr3762/r4
- refs/reviewable/pr3762/r5
- refs/reviewable/pr3762/r6
- refs/reviewable/pr3762/r7
- refs/reviewable/pr3763/r1
- refs/reviewable/pr3763/r2
- refs/reviewable/pr3763/r3
- refs/reviewable/pr3763/r4
- refs/reviewable/pr3763/r5
- refs/reviewable/pr6892/r1
- refs/reviewable/pr6892/r2
- refs/reviewable/pr6892/r3
- refs/reviewable/pr6892/r4
- refs/reviewable/pr6892/r5
- refs/reviewable/pr6892/r6
- refs/reviewable/pr6986/r1
- refs/reviewable/pr6986/r10
- refs/reviewable/pr6986/r11
- refs/reviewable/pr6986/r12
- refs/reviewable/pr6986/r13
- refs/reviewable/pr6986/r14
- refs/reviewable/pr6986/r15
- refs/reviewable/pr6986/r16
- refs/reviewable/pr6986/r17
- refs/reviewable/pr6986/r18
- refs/reviewable/pr6986/r2
- refs/reviewable/pr6986/r3
- refs/reviewable/pr6986/r4
- refs/reviewable/pr6986/r5
- refs/reviewable/pr6986/r6
- refs/reviewable/pr6986/r7
- refs/reviewable/pr6986/r8
- refs/reviewable/pr6986/r9
- refs/reviewable/pr6987/r1
- refs/reviewable/pr6987/r10
- refs/reviewable/pr6987/r11
- refs/reviewable/pr6987/r12
- refs/reviewable/pr6987/r13
- refs/reviewable/pr6987/r14
- refs/reviewable/pr6987/r15
- refs/reviewable/pr6987/r16
- refs/reviewable/pr6987/r2
- refs/reviewable/pr6987/r3
- refs/reviewable/pr6987/r4
- refs/reviewable/pr6987/r5
- refs/reviewable/pr6987/r6
- refs/reviewable/pr6987/r7
- refs/reviewable/pr6987/r8
- refs/reviewable/pr6987/r9
- refs/reviewable/pr7191/r1
- refs/reviewable/pr7191/r10
- refs/reviewable/pr7191/r11
- refs/reviewable/pr7191/r12
- refs/reviewable/pr7191/r13
- refs/reviewable/pr7191/r2
- refs/reviewable/pr7191/r3
- refs/reviewable/pr7191/r4
- refs/reviewable/pr7191/r5
- refs/reviewable/pr7191/r6
- refs/reviewable/pr7191/r7
- refs/reviewable/pr7191/r8
- refs/reviewable/pr7191/r9
- refs/reviewable/pr7192/r1
- refs/reviewable/pr7192/r2
- refs/reviewable/pr7192/r3
- refs/reviewable/pr7194/r1
- refs/reviewable/pr7194/r2
- refs/reviewable/pr7194/r3
- refs/reviewable/pr7194/r4
- refs/reviewable/pr7307/r1
- refs/reviewable/pr7307/r2
- refs/tags/v1.1
- refs/tags/v1.1.0.1
- refs/tags/v1.3
- refs/tags/v1.4
- refs/tags/v1.5.0-alpha
- refs/tags/v1.5.0-beta
- refs/tags/v1.5.3
- refs/tags/v1.5.4
- refs/tags/v1.6.0-beta
- refs/tags/v1.6.2
- refs/tags/v1.7.2
- refs/tags/v1.7.3
- refs/tags/v1.8.0-beta
- refs/tags/v1.8.10
- refs/tags/v1.8.2
- refs/tags/v1.8.5
- refs/tags/v1.8.7
- refs/tags/v1.8.9
- refs/tags/v2.0-rc
- refs/tags/v2.0.0-beta
- refs/tags/v2.0.10
- refs/tags/v2.0.2
- refs/tags/v2.0.3
- refs/tags/v2.0.5
- refs/tags/v2.0.6
- refs/tags/v2.0.7
- refs/tags/v2.0.8
- refs/tags/v2.0.9
- refs/tags/v2.1-rc
- refs/tags/v2.1.1
- refs/tags/v2.1.2
- refs/tags/v2.1.4
- refs/tags/v2.1.5
- refs/tags/v2.1.6
- refs/tags/v2.2-rc
- refs/tags/v2.2.1
- refs/tags/v2.2.2
- refs/tags/v2.3-rc
- refs/tags/v2.3.0
- refs/tags/v2.3.1
- refs/tags/v2.3.2
- refs/tags/v2.3.3
- refs/tags/v2.3.4
- refs/tags/v2.4-rc
- refs/tags/v2.4.0
- refs/tags/v2.4.1
- refs/tags/v2.4.2
- refs/tags/v2.5-rc
- refs/tags/v2.5.0
- refs/tags/v2.5.1
- refs/tags/v2.5.2
- refs/tags/v2.5.3
- refs/tags/v2.6-rc
- refs/tags/v2.6.0
- refs/tags/v2.6.1
- refs/tags/v2.6.2
- refs/tags/v2.7-rc
- refs/tags/v2.7.0
- refs/tags/v2.7.1
- refs/tags/v2.7.2
- refs/tags/v2.8-rc
- refs/tags/v2.8.0
- refs/tags/v2.8.1
- refs/tags/v2.8.2
- refs/tags/v2.8.3
- refs/tags/v2.8.4
- refs/tags/v2.9-rc
- refs/tags/v2.9.0
- refs/tags/v2.9.1
- refs/tags/v2.9.2
- refs/tags/v3.0-rc
- refs/tags/v3.0.0
- refs/tags/v3.0.1
- refs/tags/v3.0.3
- refs/tags/v3.1-rc
- refs/tags/v3.1.1
- refs/tags/v3.1.2
- refs/tags/v3.1.3
- refs/tags/v3.1.4
- refs/tags/v3.1.5
- refs/tags/v3.1.6
- refs/tags/v3.1.7
- refs/tags/v3.1.8
- refs/tags/v3.2-rc
- refs/tags/v3.2.1
- refs/tags/v3.2.2
- refs/tags/v3.2.4
- refs/tags/v3.3-rc
- refs/tags/v3.3.1
- refs/tags/v3.3.3
- refs/tags/v3.3.3333
- refs/tags/v3.3.4000
- refs/tags/v3.4-rc
- refs/tags/v3.4.1
- refs/tags/v3.4.2
- refs/tags/v3.4.3
- refs/tags/v3.4.4
- refs/tags/v3.4.5
- refs/tags/v3.5.1
- refs/tags/v3.5.2
- refs/tags/v3.5.3
- refs/tags/v3.6-beta
- refs/tags/v3.6-rc
- refs/tags/v3.6.2
- refs/tags/v3.6.3
- refs/tags/v3.6.4
- refs/tags/v3.6.5
- refs/tags/v3.7-beta
- refs/tags/v3.7-rc
- refs/tags/v3.7.2
- refs/tags/v3.7.3
- refs/tags/v3.7.4
- refs/tags/v3.7.5
- refs/tags/v3.7.6
- refs/tags/v3.7.7
- refs/tags/v3.8-beta
- refs/tags/v3.8-rc
- refs/tags/v3.8.2
- refs/tags/v3.8.3
- refs/tags/v3.9-beta
- refs/tags/v3.9-rc
- refs/tags/v3.9.10
- refs/tags/v3.9.2
- refs/tags/v3.9.3
- refs/tags/v3.9.5
- refs/tags/v3.9.6
- refs/tags/v3.9.7
- refs/tags/v3.9.8
- refs/tags/v3.9.9
- refs/tags/v4.0-beta
- refs/tags/v4.0-rc
- refs/tags/v4.0.2
- refs/tags/v4.0.3
- refs/tags/v4.0.5
- refs/tags/v4.0.6
- refs/tags/v4.0.7
- refs/tags/v4.0.8
- refs/tags/v4.1-beta
- refs/tags/v4.1-rc
- refs/tags/v4.1.2
- refs/tags/v4.1.3
- refs/tags/v4.1.4
- refs/tags/v4.1.5
- refs/tags/v4.1.6
- refs/tags/v4.2-beta
- refs/tags/v4.2-rc
- refs/tags/v4.2.2
- refs/tags/v4.2.3
- refs/tags/v4.2.4
- refs/tags/v4.3-beta
- refs/tags/v4.3-rc
- refs/tags/v4.3.2
- refs/tags/v4.3.3
- refs/tags/v4.3.4
- refs/tags/v4.3.5
- refs/tags/v4.4-beta
- refs/tags/v4.4-rc
- refs/tags/v4.4.2
- refs/tags/v4.4.3
- refs/tags/v4.4.4
- refs/tags/v4.5-beta
- refs/tags/v4.5-rc
- refs/tags/v4.5.2
- refs/tags/v4.5.3
- refs/tags/v4.5.4
- refs/tags/v4.5.5
- refs/tags/v4.6-beta
- refs/tags/v4.6-rc
- refs/tags/v4.6.2
- refs/tags/v4.6.3
- refs/tags/v4.6.4
- refs/tags/v4.7-beta
- refs/tags/v4.7-rc
- refs/tags/v4.7.2
- refs/tags/v4.7.3
- refs/tags/v4.7.4
- refs/tags/v4.8-beta
- refs/tags/v4.8-rc
- refs/tags/v4.8.2
- refs/tags/v4.8.3
- refs/tags/v4.8.4
- refs/tags/v4.9-beta
- refs/tags/v4.9-rc
- refs/tags/v4.9.3
- refs/tags/v4.9.4
- refs/tags/v4.9.5
- refs/tags/v5.0-beta
- refs/tags/v5.0-rc
- refs/tags/v5.0.2
- 1cfab760e14e9f291c7176d95f81d716dc3dd37d
History 
Cook and download a directory from the Software Heritage Vault
You have requested the cooking of the directory with identifier swh:1:dir:9b0b37d4650ac0c13b5514ef4dba1a4ca0d69dbb into a standard tar.gz archive.
Are you sure you want to continue ?
Download a directory from the Software Heritage Vault
You have requested the download of the directory with identifier swh:1:dir:9b0b37d4650ac0c13b5514ef4dba1a4ca0d69dbb as a standard tar.gz archive.
Are you sure you want to continue ?
Cook and download a revision from the Software Heritage Vault
You have requested the cooking of the history heading to revision with identifier swh:1:rev:1cfab760e14e9f291c7176d95f81d716dc3dd37d into a bare git archive.
Are you sure you want to continue ?
Download a revision from the Software Heritage Vault
You have requested the download of the history heading to revision with identifier swh:1:rev:1cfab760e14e9f291c7176d95f81d716dc3dd37d as a bare git archive.
Are you sure you want to continue ?
Invalid Email !
The provided email is not well-formed.
Download link has expired
The requested archive is no longer available for download from the Software Heritage Vault.
Do you want to cook it again ?
Take a new snapshot of a software origin
If the archived software origin currently browsed is not synchronized with its upstream version (for instance when new commits have been issued), you can explicitly request Software Heritage to take a new snapshot of it.
Use the form below to proceed. Once a request has been submitted and accepted, it will be processed as soon as possible. You can then check its processing state by visiting this dedicated page. Processing "take a new snapshot" request ...
Permalinks
To reference or cite the objects present in the Software Heritage archive, permalinks based on SoftWare Hash IDentifiers (SWHIDs) must be used.
Select below a type of object currently browsed in order to display its associated SWHID and permalink.
Tip revision: 1cfab760e14e9f291c7176d95f81d716dc3dd37d authored by Nathan Shively-Sanders on 08 October 2018, 17:01:04 UTC
Only functions can be constructor functions (#27369)
Only functions can be constructor functions (#27369)
Tip revision: 1cfab76
| File | Mode | Size |
|---|---|---|
| .github | ||
| .vscode | ||
| bin | ||
| doc | ||
| lib | ||
| scripts | ||
| src | ||
| tests | ||
| .editorconfig | -rw-r--r-- | 188 bytes |
| .gitattributes | -rw-r--r-- | 42 bytes |
| .gitignore | -rw-r--r-- | 2.0 KB |
| .gitmodules | -rw-r--r-- | 2.0 KB |
| .mailmap | -rw-r--r-- | 18.6 KB |
| .npmignore | -rw-r--r-- | 312 bytes |
| .npmrc | -rw-r--r-- | 18 bytes |
| .travis.yml | -rw-r--r-- | 407 bytes |
| AUTHORS.md | -rw-r--r-- | 6.0 KB |
| CONTRIBUTING.md | -rw-r--r-- | 9.3 KB |
| CopyrightNotice.txt | -rw-r--r-- | 819 bytes |
| Gulpfile.js | -rw-r--r-- | 26.6 KB |
| Jakefile.js | -rw-r--r-- | 33.4 KB |
| LICENSE.txt | -rw-r--r-- | 9.0 KB |
| README.md | -rw-r--r-- | 4.8 KB |
| ThirdPartyNoticeText.txt | -rw-r--r-- | 36.9 KB |
| package.json | -rw-r--r-- | 3.5 KB |
| tslint.json | -rw-r--r-- | 4.7 KB |
The diff you're trying to view is too large. Only the first 1000 changed files have been loaded.
Computing file changes ...
