Skip to main content

Browse the archive

Revision 1dbcf198f22f1b541f61a1a64f02fc8e9656755a authored by Steven Johnson on 21 December 2020, 17:08:20 UTC, committed by GitHub on 21 December 2020, 17:08:20 UTC 
Decouple wasm's +bulk-memory from wasm_threads (#5574)
 
* Decouple wasm's +bulk-memory from threads

When `wasm_threads` was added, `+bulk-memory` codegen was enabled in conjunction with this feature, due to some inscrutable error which apparently didn't get recorded. From inspection of the spec for bulk-memory, and experimentation with the most recent version of Emscripten (2.0.10), I can't find any reason that this actually needs to be enabled, so I've moved it into its own new feature flag.

Also: drive-by fix in Target to format the tables in `get_runtime_compatible_target()` better, and to remove some wasm-related entries from the 'must match' table that didn't actually need to match.

* Create .gitignore
1 parent ef45c87
Raw File
CMakePresets.json 
{
  "version": 1,
  "cmakeMinimumRequired": {
    "major": 3,
    "minor": 16,
    "patch": 0
  },
  "configurePresets": [
    {
      "name": "gcc-debug",
      "displayName": "GCC (Debug)",
      "description": "Debug build using Ninja generator and GCC-compatible compiler",
      "generator": "Ninja",
      "binaryDir": "${sourceDir}/build",
      "cacheVariables": {
        "CMAKE_BUILD_TYPE": "Debug",
        "CMAKE_CXX_FLAGS_RELEASE": "-O2",
        "CMAKE_CXX_FLAGS_RELWITHDEBINFO": "-O2 -g",
        "CMAKE_CXX_FLAGS_MINSIZEREL": "-Os"
      }
    },
    {
      "name": "gcc-release",
      "inherits": "gcc-debug",
      "displayName": "GCC (Release)",
      "description": "Release build using Ninja generator and GCC-compatible compiler",
      "cacheVariables": {
        "CMAKE_BUILD_TYPE": "Release"
      }
    },
    {
      "name": "msvc-debug",
      "displayName": "MSVC (Debug)",
      "description": "Debug build using Ninja generator and MSVC with vcpkg dependencies.",
      "generator": "Ninja",
      "binaryDir": "${sourceDir}/build",
      "cacheVariables": {
        "CMAKE_BUILD_TYPE": "Debug",
        "CMAKE_TOOLCHAIN_FILE": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"
      }
    },
    {
      "name": "msvc-release",
      "displayName": "MSVC (Release)",
      "description": "Debug build using Ninja generator and MSVC with vcpkg dependencies.",
      "generator": "Ninja",
      "binaryDir": "${sourceDir}/build",
      "cacheVariables": {
        "CMAKE_BUILD_TYPE": "Release",
        "CMAKE_TOOLCHAIN_FILE": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"
      }
    },
    {
      "name": "win32",
      "displayName": "Win32 (Visual Studio)",
      "description": "Visual Studio-based Win32 build with vcpkg dependencies.",
      "generator": "Visual Studio 16 2019",
      "architecture": "Win32",
      "toolset": "host=x64",
      "binaryDir": "${sourceDir}/build",
      "cacheVariables": {
        "CMAKE_TOOLCHAIN_FILE": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"
      }
    },
    {
      "name": "win64",
      "displayName": "Win64 (Visual Studio)",
      "description": "Visual Studio-based Win64 build with vcpkg dependencies.",
      "generator": "Visual Studio 16 2019",
      "architecture": "x64",
      "toolset": "host=x64",
      "binaryDir": "${sourceDir}/build",
      "cacheVariables": {
        "CMAKE_TOOLCHAIN_FILE": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"
      }
    }
  ]
}
back to top