Skip to main content

Browse the archive

Revision 1dbcf198f22f1b541f61a1a64f02fc8e9656755a authored by Steven Johnson on 21 December 2020, 17:08:20 UTC, committed by GitHub on 21 December 2020, 17:08:20 UTC 
Decouple wasm's +bulk-memory from wasm_threads (#5574)
 
* Decouple wasm's +bulk-memory from threads

When `wasm_threads` was added, `+bulk-memory` codegen was enabled in conjunction with this feature, due to some inscrutable error which apparently didn't get recorded. From inspection of the spec for bulk-memory, and experimentation with the most recent version of Emscripten (2.0.10), I can't find any reason that this actually needs to be enabled, so I've moved it into its own new feature flag.

Also: drive-by fix in Target to format the tables in `get_runtime_compatible_target()` better, and to remove some wasm-related entries from the 'must match' table that didn't actually need to match.

* Create .gitignore
1 parent ef45c87
Raw File
Argument.cpp 
#include "Argument.h"

namespace Halide {

bool ArgumentEstimates::operator==(const ArgumentEstimates &rhs) const {
    if (buffer_estimates.size() != rhs.buffer_estimates.size()) {
        return false;
    }
    for (size_t i = 0; i < buffer_estimates.size(); ++i) {
        if (!buffer_estimates[i].min.same_as(rhs.buffer_estimates[i].min) ||
            !buffer_estimates[i].extent.same_as(rhs.buffer_estimates[i].extent)) {
            return false;
        }
    }
    return scalar_def.same_as(rhs.scalar_def) &&
           scalar_min.same_as(rhs.scalar_min) &&
           scalar_max.same_as(rhs.scalar_max) &&
           scalar_estimate.same_as(rhs.scalar_estimate);
}

Argument::Argument(const std::string &_name, Kind _kind, const Type &_type, int _dimensions, const ArgumentEstimates &argument_estimates)
    : name(_name), kind(_kind), dimensions((uint8_t)_dimensions), type(_type), argument_estimates(argument_estimates) {
    internal_assert(dimensions >= 0 && dimensions <= 255);
    user_assert(!(is_scalar() && dimensions != 0)) << "Scalar Arguments must specify dimensions of 0";
    user_assert(argument_estimates.buffer_estimates.empty() ||
                argument_estimates.buffer_estimates.size() == dimensions)
        << "buffer_estimates must match dimensionality for Argument " << name;
}

}  // namespace Halide
back to top