Revision - 1e07381 - rpc: /dial_peers: only mark peers as persistent if flag is on (#3620) - origin: https://github.com/tendermint/tendermint

visit type:

https://github.com/tendermint/tendermint

05 April 2024, 22:58:32 UTC

Revision 1e073817de69eca661d99b024810e6d31ff0b50e authored by Anton Kaliaev on 07 May 2019, 07:09:06 UTC, committed by GitHub on 07 May 2019, 07:09:06 UTC

rpc: /dial_peers: only mark peers as persistent if flag is on (#3620)

## Description

also

    handle errors from DialPeersAsync
    remove nil addr from log msg
    fix TestPEXReactorDoesNotDisconnectFromPersistentPeerInSeedMode

This is a follow-up from
#3593 (review)

Fixes most of the #3617, except #3593 (comment)

## Commits

* rpc: /dial_peers: only mark peers as persistent if flag is on

also

- handle errors from DialPeersAsync
- remove nil addr from log msg
- fix TestPEXReactorDoesNotDisconnectFromPersistentPeerInSeedMode

This is a follow-up from
https://github.com/tendermint/tendermint/pull/3593#pullrequestreview-233556909

* remove a call to AddPersistentPeers

TestDialFail will trigger a reconnect

1 parent 2bb1a87

Files
Changes

Permalinks

Tip revision: 1e073817de69eca661d99b024810e6d31ff0b50e authored by Anton Kaliaev on 07 May 2019, 07:09:06 UTC
rpc: /dial_peers: only mark peers as persistent if flag is on (#3620)

Tip revision: 1e07381

File	Mode	Size
conn
mock
pex
trust
upnp
README.md	-rw-r--r--	790 bytes
base_reactor.go	-rw-r--r--	1.4 KB
conn_set.go	-rw-r--r--	1.2 KB
errors.go	-rw-r--r--	4.2 KB
fuzz.go	-rw-r--r--	3.8 KB
key.go	-rw-r--r--	3.1 KB
key_test.go	-rw-r--r--	1.1 KB
metrics.go	-rw-r--r--	2.8 KB
netaddress.go	-rw-r--r--	9.7 KB
netaddress_test.go	-rw-r--r--	4.6 KB
node_info.go	-rw-r--r--	7.5 KB
node_info_test.go	-rw-r--r--	4.4 KB
peer.go	-rw-r--r--	8.8 KB
peer_set.go	-rw-r--r--	3.3 KB
peer_set_test.go	-rw-r--r--	5.3 KB
peer_test.go	-rw-r--r--	5.2 KB
switch.go	-rw-r--r--	21.2 KB
switch_test.go	-rw-r--r--	16.8 KB
test_util.go	-rw-r--r--	6.5 KB
transport.go	-rw-r--r--	12.8 KB
transport_test.go	-rw-r--r--	13.0 KB
types.go	-rw-r--r--	164 bytes
wire.go	-rw-r--r--	211 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/tendermint/tendermint

rpc: /dial_peers: only mark peers as persistent if flag is on (#3620)

README.md