Revision - 1e07381 - rpc: /dial_peers: only mark peers as persistent if flag is on (#3620) - origin: https://github.com/tendermint/tendermint

visit type:

https://github.com/tendermint/tendermint

05 April 2024, 22:58:32 UTC

Revision 1e073817de69eca661d99b024810e6d31ff0b50e authored by Anton Kaliaev on 07 May 2019, 07:09:06 UTC, committed by GitHub on 07 May 2019, 07:09:06 UTC

rpc: /dial_peers: only mark peers as persistent if flag is on (#3620)

## Description

also

    handle errors from DialPeersAsync
    remove nil addr from log msg
    fix TestPEXReactorDoesNotDisconnectFromPersistentPeerInSeedMode

This is a follow-up from
#3593 (review)

Fixes most of the #3617, except #3593 (comment)

## Commits

* rpc: /dial_peers: only mark peers as persistent if flag is on

also

- handle errors from DialPeersAsync
- remove nil addr from log msg
- fix TestPEXReactorDoesNotDisconnectFromPersistentPeerInSeedMode

This is a follow-up from
https://github.com/tendermint/tendermint/pull/3593#pullrequestreview-233556909

* remove a call to AddPersistentPeers

TestDialFail will trigger a reconnect

1 parent 2bb1a87

Files
Changes

Permalinks

Tip revision: 1e073817de69eca661d99b024810e6d31ff0b50e authored by Anton Kaliaev on 07 May 2019, 07:09:06 UTC
rpc: /dial_peers: only mark peers as persistent if flag is on (#3620)

Tip revision: 1e07381

File	Mode	Size
.circleci
.github
DOCKER
abci
benchmarks
blockchain
cmd
config
consensus
crypto
docs
evidence
libs
lite
mempool
mock
networks
node
p2p
privval
proxy
rpc
scripts
state
test
tools
types
version
.editorconfig	-rw-r--r--	280 bytes
.gitignore	-rw-r--r--	494 bytes
.golangci.yml	-rw-r--r--	1.1 KB
CHANGELOG.md	-rw-r--r--	104.6 KB
CHANGELOG_PENDING.md	-rw-r--r--	2.2 KB
CODE_OF_CONDUCT.md	-rw-r--r--	4.9 KB
CONTRIBUTING.md	-rw-r--r--	7.1 KB
Gopkg.lock	-rw-r--r--	15.3 KB
Gopkg.toml	-rw-r--r--	2.0 KB
LICENSE	-rw-r--r--	11.1 KB
Makefile	-rw-r--r--	10.4 KB
PHILOSOPHY.md	-rw-r--r--	7.5 KB
README.md	-rw-r--r--	6.9 KB
ROADMAP.md	-rw-r--r--	861 bytes
SECURITY.md	-rw-r--r--	1.7 KB
UPGRADING.md	-rw-r--r--	12.6 KB
Vagrantfile	-rw-r--r--	2.1 KB
appveyor.yml	-rw-r--r--	279 bytes
codecov.yml	-rw-r--r--	330 bytes
docker-compose.yml	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/tendermint/tendermint

rpc: /dial_peers: only mark peers as persistent if flag is on (#3620)

README.md