Skip to main content

Browse the archive

Revision 1e073817de69eca661d99b024810e6d31ff0b50e authored by Anton Kaliaev on 07 May 2019, 07:09:06 UTC, committed by GitHub on 07 May 2019, 07:09:06 UTC 
rpc: /dial_peers: only mark peers as persistent if flag is on (#3620)
 
## Description

also

    handle errors from DialPeersAsync
    remove nil addr from log msg
    fix TestPEXReactorDoesNotDisconnectFromPersistentPeerInSeedMode

This is a follow-up from
#3593 (review)

Fixes most of the #3617, except #3593 (comment)

## Commits

* rpc: /dial_peers: only mark peers as persistent if flag is on

also

- handle errors from DialPeersAsync
- remove nil addr from log msg
- fix TestPEXReactorDoesNotDisconnectFromPersistentPeerInSeedMode

This is a follow-up from
https://github.com/tendermint/tendermint/pull/3593#pullrequestreview-233556909

* remove a call to AddPersistentPeers

TestDialFail will trigger a reconnect
1 parent 2bb1a87
Raw File
Makefile 
build:
	@sh -c "'$(CURDIR)/build.sh'"

push:
	@sh -c "'$(CURDIR)/push.sh'"

build_develop:
	docker build -t "tendermint/tendermint:develop" -f Dockerfile.develop .

build_testing:
	docker build --tag tendermint/testing -f ./Dockerfile.testing .

push_develop:
	docker push "tendermint/tendermint:develop"

.PHONY: build build_develop push push_develop
back to top