Skip to main content

Browse the archive

Revision 1e5de2837c166535f9bb4232bfe97ea1f9fc7a1c authored by Linus Torvalds on 08 July 2007, 19:02:55 UTC, committed by Linus Torvalds on 08 July 2007, 19:02:55 UTC 
Fix permission checking for the new utimensat() system call
 
Commit 1c710c896eb461895d3c399e15bb5f20b39c9073 added the utimensat()
system call, but didn't handle the case of checking for the writability
of the target right, when the target was a file descriptor, not a
filename.

We cannot use vfs_permission(MAY_WRITE) for that case, and need to
simply check whether the file descriptor is writable.  The oops from
using the wrong function was noticed and narrowed down by Markus
Trippelsdorf.

Cc: Ulrich Drepper <drepper@redhat.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Al Viro <viro@ftp.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4e99325
Raw File
hdrcheck.sh 
#!/bin/sh

for FILE in `grep '^[ \t]*#[ \t]*include[ \t]*<' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
    if [ ! -r $1/$FILE ]; then
	echo $2 requires $FILE, which does not exist in exported headers
	exit 1
    fi
done
# FIXME: List dependencies into $3
touch $3
back to top