Revision - 1e699e1 - Revert "hwmon: (pmbus) Add regulator supply into macro" - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

17 May 2024, 11:00:25 UTC

Revision 1e699e177e339e462cdc8571e3d0fcf29665608e authored by Guenter Roeck on 04 November 2022, 23:37:30 UTC, committed by Guenter Roeck on 04 November 2022, 23:47:01 UTC

Revert "hwmon: (pmbus) Add regulator supply into macro"

This reverts commit 54cc3dbfc10dc3db7cb1cf49aee4477a8398fbde.

Zev Weiss reports that the reverted patch may cause a regulator
undercount. Here is his report:

... having regulator-dummy set as a supply on my PMBus regulators
(instead of having them as their own top-level regulators without
an upstream supply) leads to enable-count underflow errors when
disabling them:

    # echo 0 > /sys/bus/platform/devices/efuse01/state
    [  906.094477] regulator-dummy: Underflow of regulator enable count
    [  906.100563] Failed to disable vout: -EINVAL
    [  136.992676] reg-userspace-consumer efuse01: Failed to configure state: -22

Zev reports that reverting the patch fixes the problem. So let's do that
for now.

Fixes: 54cc3dbfc10d ("hwmon: (pmbus) Add regulator supply into macro")
Cc: Marcello Sylvester Bauer <sylv@sylv.io>
Reported-by: Zev Weiss <zev@bewilderbeest.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

1 parent c4f6837

Files
Changes

Permalinks

Tip revision: 1e699e177e339e462cdc8571e3d0fcf29665608e authored by Guenter Roeck on 04 November 2022, 23:37:30 UTC
Revert "hwmon: (pmbus) Add regulator supply into macro"

Tip revision: 1e699e1

File	Mode	Size
Documentation
LICENSES
arch
block
certs
crypto
drivers
fs
include
init
io_uring
ipc
kernel
lib
mm
net
rust
samples
scripts
security
sound
tools
usr
virt
.clang-format	-rw-r--r--	19.9 KB
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	151 bytes
.gitattributes	-rw-r--r--	62 bytes
.gitignore	-rw-r--r--	2.0 KB
.mailmap	-rw-r--r--	24.2 KB
.rustfmt.toml	-rw-r--r--	369 bytes
COPYING	-rw-r--r--	496 bytes
CREDITS	-rw-r--r--	99.1 KB
Kbuild	-rw-r--r--	2.5 KB
Kconfig	-rw-r--r--	555 bytes
MAINTAINERS	-rw-r--r--	671.3 KB
Makefile	-rw-r--r--	69.0 KB
README	-rw-r--r--	727 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

Revert "hwmon: (pmbus) Add regulator supply into macro"

README