Skip to main content

Browse the archive

Revision 1e801bf543872315879cefe3d755d83834eff0b1 authored by Makoto Shimazu on 10 April 2018, 01:23:59 UTC, committed by Philip Jägenstedt on 10 April 2018, 14:00:49 UTC 
Revert "Enable ConsumeGestureOnNavigation by default"
 
This reverts commit 2ca250d409adfa73a666daabd3ba19b94d6443a7.

Reason for revert: A leak bot complains navigation-consumes-user-activation.tentative.sub.html is leaking.
Sample build:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/17509

Original change's description:
> Enable ConsumeGestureOnNavigation by default
>
> See blink-dev thread:
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kPli8ZCUeok
>
> A browser test is moved to be a tentative WPT due to this change.
>
> Bug: 772515
> Change-Id: Icf99c8c303c5055dcbcdace6ae94e3fcd1a01921
> Reviewed-on: https://chromium-review.googlesource.com/980599
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
> Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549293}

TBR=nasko@chromium.org,mustaq@chromium.org,csharrison@chromium.org,kereliuk@chromium.org

Change-Id: I0c998798d1367be61c633db76429c18ac554e4ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 772515
Reviewed-on: https://chromium-review.googlesource.com/1003437
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549363}
1 parent 1a57aef
Raw File
PositionOptions.https.html 
<!DOCTYPE HTML>
<meta charset="utf-8">
<title>Geolocation Test: PositionOptions tests</title>
<link rel="help" href="http://www.w3.org/TR/geolocation-API/#position_options_interface">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src='support.js'></script>

<p>Clear all Geolocation permissions before running this test. If prompted for permission, please allow.</p>
<div id="log"></div>

<script>
// Rewrite http://dev.w3.org/geo/api/test-suite/t.html?00123
test(function() {
  try {
    geo.getCurrentPosition(dummyFunction, null, {enableHighAccuracy: "boom"});
    geo.getCurrentPosition(dummyFunction, null, {enableHighAccuracy: 321});
    geo.getCurrentPosition(dummyFunction, null, {enableHighAccuracy: -Infinity});
    geo.getCurrentPosition(dummyFunction, null, {enableHighAccuracy: {foo: 5}});
  } catch(e) {
    assert_unreached('An exception was thrown unexpectedly: ' + e.message);
  }
}, 'Call getCurrentPosition with wrong type for enableHighAccuracy. No exception expected.');

// Rewrite http://dev.w3.org/geo/api/test-suite/t.html?00124
test(function() {
  try {
    geo.watchPosition(dummyFunction, null, {enableHighAccuracy: "boom"});
    geo.watchPosition(dummyFunction, null, {enableHighAccuracy: 321});
    geo.watchPosition(dummyFunction, null, {enableHighAccuracy: -Infinity});
    geo.watchPosition(dummyFunction, null, {enableHighAccuracy: {foo: 5}});
  } catch(e) {
    assert_unreached('An exception was thrown unexpectedly: ' + e.message);
  }
}, 'Call watchPosition with wrong type for enableHighAccuracy. No exception expected.');

// Rewrite http://dev.w3.org/geo/api/test-suite/t.html?00086, 00088, 00091 and 00092
test(function() {
  var t86 = async_test('Set timeout and maximumAge to 0, check that timeout error raised (getCurrentPosition)'),
      t88 = async_test('Set timeout and maximumAge to 0, check that timeout error raised (watchPosition)'),
      t91 = async_test('Check that a negative timeout value is equivalent to a 0 timeout value (getCurrentLocation)'),
      t92 = async_test('Check that a negative timeout value is equivalent to a 0 timeout value (watchPosition)');

  try {
    geo.getCurrentPosition(
        t86.unreached_func('A success callback was invoked unexpectedly'),
        t86.step_func_done(function(err) {
          assert_equals(err.code, err.TIMEOUT);
        }),
        {timeout: 0, maximumAge: 0}
    );
  } catch(e) {
    t86.step(function() {
      assert_unreached('An exception was thrown unexpectedly: ' + e.message);
    });
  }

  try {
    geo.watchPosition(
        t88.unreached_func('A success callback was invoked unexpectedly'),
        t88.step_func_done(function(err) {
          assert_equals(err.code, err.TIMEOUT);
        }),
        {timeout: 0, maximumAge: 0}
    );
  } catch(e) {
    t88.step(function() {
      assert_unreached('An exception was thrown unexpectedly: ' + e.message);
    });
  }

  try {
    geo.getCurrentPosition(
        t91.unreached_func('A success callback was invoked unexpectedly'),
        t91.step_func_done(function(err) {
          assert_equals(err.code, err.TIMEOUT);
        }),
        {timeout:-1, maximumAge: 0}
    );
  } catch(e) {
    t91.step(function() {
      assert_unreached('An exception was thrown unexpectedly: ' + e.message);
    });
  }

  try {
    geo.watchPosition(
        t92.unreached_func('A success callback was invoked unexpectedly'),
        t92.step_func_done(function(err) {
          assert_equals(err.code, err.TIMEOUT);
        }),
        {timeout: -1, maximumAge: 0}
    );
  } catch(e) {
    t92.step(function() {
      assert_unreached('An exception was thrown unexpectedly: ' + e.message);
    });
  }
}, 'PositionOptions tests');
</script>
back to top