Skip to main content

Browse the archive

Revision 1e801bf543872315879cefe3d755d83834eff0b1 authored by Makoto Shimazu on 10 April 2018, 01:23:59 UTC, committed by Philip Jägenstedt on 10 April 2018, 14:00:49 UTC 
Revert "Enable ConsumeGestureOnNavigation by default"
 
This reverts commit 2ca250d409adfa73a666daabd3ba19b94d6443a7.

Reason for revert: A leak bot complains navigation-consumes-user-activation.tentative.sub.html is leaking.
Sample build:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/17509

Original change's description:
> Enable ConsumeGestureOnNavigation by default
>
> See blink-dev thread:
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kPli8ZCUeok
>
> A browser test is moved to be a tentative WPT due to this change.
>
> Bug: 772515
> Change-Id: Icf99c8c303c5055dcbcdace6ae94e3fcd1a01921
> Reviewed-on: https://chromium-review.googlesource.com/980599
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
> Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549293}

TBR=nasko@chromium.org,mustaq@chromium.org,csharrison@chromium.org,kereliuk@chromium.org

Change-Id: I0c998798d1367be61c633db76429c18ac554e4ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 772515
Reviewed-on: https://chromium-review.googlesource.com/1003437
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549363}
1 parent 1a57aef
Raw File
watchPosition_TypeError.html 
<!DOCTYPE HTML>
<meta charset='utf-8'>
<title>Geolocation Test: watchPosition TypeError tests</title>
<link rel='help' href='http://www.w3.org/TR/geolocation-API/'>
<script src='/resources/testharness.js'></script>
<script src='/resources/testharnessreport.js'></script>
<script src='support.js'></script>

<div id='log'></div>

<script>
// Rewrite http://dev.w3.org/geo/api/test-suite/t.html?00058
test(function() {
  assert_throws(new TypeError(), function() {
    geo.watchPosition();
  });
}, 'Call watchPosition without arguments, check that exception is thrown');

// Rewrite http://dev.w3.org/geo/api/test-suite/t.html?00015
test(function() {
  assert_throws(new TypeError(), function() {
    geo.watchPosition(null);
  });
}, 'Call watchPosition with null success callback, check that exception is thrown');

// Rewrite http://dev.w3.org/geo/api/test-suite/t.html?00017
test(function() {
  assert_throws(new TypeError(), function() {
    geo.watchPosition(null, null);
  });
}, 'Call watchPosition with null success and error callbacks, check that exception is thrown');

// Rewrite http://dev.w3.org/geo/api/test-suite/t.html?00059
test(function() {
  assert_throws(new TypeError(), function() {
    geo.watchPosition(3);
  });
}, 'Call watchPosition() with wrong type for first argument. Exception expected.');

// Rewrite http://dev.w3.org/geo/api/test-suite/t.html?00060
test(function() {
  assert_throws(new TypeError(), function() {
    geo.watchPosition(dummyFunction, 4);
  });
}, 'Call watchPosition() with wrong type for second argument. Exception expected.');

// Rewrite http://dev.w3.org/geo/api/test-suite/t.html?00061
test(function() {
  assert_throws(new TypeError(), function() {
    geo.watchPosition(dummyFunction, dummyFunction, 4);
  });
}, 'Call watchPosition() with wrong type for third argument. Exception expected.');

done();
</script>
back to top