Revision 1ee4c55fc9620451b2a825d793042a7e0775391b authored by Ben Hutchings on 14 January 2013, 01:29:17 UTC, committed by Greg Kroah-Hartman on 17 January 2013, 21:08:32 UTC
vt6656 has several headers that use the #pragma pack(1) directive to enable structure packing, but never disable it. The layout of structures defined in other headers can then depend on which order the various headers are included in, breaking the One Definition Rule. In practice this resulted in crashes on x86_64 until the order of header inclusion was changed for some files in commit 11d404cb56ecd ('staging: vt6656: fix headers and add cfg80211.'). But we need a proper fix that won't be affected by future changes to the order of inclusion. This removes the #pragma pack(1) directives and adds __packed to the structure definitions for which packing appears to have been intended. Reported-and-tested-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 397c606
File | Mode | Size |
---|---|---|
boot | ||
configs | ||
include | ||
kernel | ||
lib | ||
mm | ||
oprofile | ||
proc-mn103e010 | ||
proc-mn2ws0050 | ||
unit-asb2303 | ||
unit-asb2305 | ||
unit-asb2364 | ||
Kconfig | -rw-r--r-- | 11.3 KB |
Kconfig.debug | -rw-r--r-- | 4.4 KB |
Makefile | -rw-r--r-- | 2.8 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...