https://github.com/shader-slang/slang
Revision 1f4b49596f710e8009d1cc996574049c4afc3627 authored by Tim Foley on 19 November 2018, 17:08:26 UTC, committed by GitHub on 19 November 2018, 17:08:26 UTC
The `Texture2D.Load()` operation takes a `uint3` of coordinates, with the `.xy` part holding the texel coordinates and the `.z` part holding a mip level. In contrast, the `RWTexture2D.Load()` operation only takes a `uint2`. This isn't clearly specified on MSDN, so Slang failed to get the declaration right. This change fixes it so that we only add the extra coordinate for the mip level on non-multisample, read-only texture types (the previous code only checked for multisample-ness). I also changed the logic that outputs swizzles to extract the coordinates and mip level so that it only applies when there is a mip level being passed through (this code should never actually be applied, though, because we shouldn't be generating `texelFetch` for RW texures anyway...). One final change that sneask in here is making the `offset` parameter for one of the load-with-offset cases correctly use the base coordinate count for the texture type (e.g., 2D even for `Texture2DArray`). That is an unrelated fix, but I thought I'd sneak it in here rather than do a separate PR.
1 parent 7e0c5ad
Tip revision: 1f4b49596f710e8009d1cc996574049c4afc3627 authored by Tim Foley on 19 November 2018, 17:08:26 UTC
Fix declaration of RWTexture*.Load() operations (#722)
Fix declaration of RWTexture*.Load() operations (#722)
Tip revision: 1f4b495
| File | Mode | Size |
|---|---|---|
| docs | ||
| examples | ||
| external | ||
| source | ||
| tests | ||
| tools | ||
| .editorconfig | -rw-r--r-- | 937 bytes |
| .gitattributes | -rw-r--r-- | 95 bytes |
| .gitignore | -rw-r--r-- | 407 bytes |
| .gitmodules | -rw-r--r-- | 406 bytes |
| .travis.yml | -rw-r--r-- | 1.7 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 3.1 KB |
| LICENSE | -rw-r--r-- | 1.1 KB |
| Makefile | -rw-r--r-- | 6.4 KB |
| README.md | -rw-r--r-- | 6.7 KB |
| appveyor.yml | -rw-r--r-- | 3.7 KB |
| premake5.lua | -rw-r--r-- | 25.3 KB |
| slang-com-helper.h | -rw-r--r-- | 4.8 KB |
| slang-com-ptr.h | -rw-r--r-- | 4.8 KB |
| slang.h | -rw-r--r-- | 72.4 KB |
| slang.sln | -rw-r--r-- | 10.5 KB |
| test.bat | -rw-r--r-- | 1.4 KB |
Computing file changes ...
