https://github.com/torvalds/linux
Revision 1f810d2b6b2fbdc5279644d8b2c140b1f7c9d43d authored by Pierre-Louis Bossart on 16 February 2023, 16:23:40 UTC, committed by Mark Brown on 16 February 2023, 16:31:15 UTC
The HDaudio stream allocation is done first, and in a second step the
LOSIDV parameter is programmed for the multi-link used by a codec.
This leads to a possible stream_tag leak, e.g. if a DisplayAudio link
is not used. This would happen when a non-Intel graphics card is used
and userspace unconditionally uses the Intel Display Audio PCMs without
checking if they are connected to a receiver with jack controls.
We should first check that there is a valid multi-link entry to
configure before allocating a stream_tag. This change aligns the
dma_assign and dma_cleanup phases.
Complements: b0cd60f3e9f5 ("ALSA/ASoC: hda: clarify bus_get_link() and bus_link_get() helpers")
Link: https://github.com/thesofproject/linux/issues/4151
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230216162340.19480-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 5afc7ee
Tip revision: 1f810d2b6b2fbdc5279644d8b2c140b1f7c9d43d authored by Pierre-Louis Bossart on 16 February 2023, 16:23:40 UTC
ASoC: SOF: Intel: hda-dai: fix possible stream_tag leak
ASoC: SOF: Intel: hda-dai: fix possible stream_tag leak
Tip revision: 1f810d2
| File | Mode | Size |
|---|---|---|
| partitions | ||
| Kconfig | -rw-r--r-- | 6.9 KB |
| Kconfig.iosched | -rw-r--r-- | 1.3 KB |
| Makefile | -rw-r--r-- | 1.8 KB |
| badblocks.c | -rw-r--r-- | 14.1 KB |
| bdev.c | -rw-r--r-- | 28.1 KB |
| bfq-cgroup.c | -rw-r--r-- | 39.9 KB |
| bfq-iosched.c | -rw-r--r-- | 257.3 KB |
| bfq-iosched.h | -rw-r--r-- | 37.5 KB |
| bfq-wf2q.c | -rw-r--r-- | 52.4 KB |
| bio-integrity.c | -rw-r--r-- | 12.3 KB |
| bio.c | -rw-r--r-- | 48.6 KB |
| blk-cgroup-fc-appid.c | -rw-r--r-- | 1.4 KB |
| blk-cgroup-rwstat.c | -rw-r--r-- | 3.4 KB |
| blk-cgroup-rwstat.h | -rw-r--r-- | 3.9 KB |
| blk-cgroup.c | -rw-r--r-- | 53.3 KB |
| blk-cgroup.h | -rw-r--r-- | 15.5 KB |
| blk-core.c | -rw-r--r-- | 32.7 KB |
| blk-crypto-fallback.c | -rw-r--r-- | 18.7 KB |
| blk-crypto-internal.h | -rw-r--r-- | 6.1 KB |
| blk-crypto-profile.c | -rw-r--r-- | 16.4 KB |
| blk-crypto-sysfs.c | -rw-r--r-- | 4.5 KB |
| blk-crypto.c | -rw-r--r-- | 12.3 KB |
| blk-flush.c | -rw-r--r-- | 15.5 KB |
| blk-ia-ranges.c | -rw-r--r-- | 8.4 KB |
| blk-integrity.c | -rw-r--r-- | 11.9 KB |
| blk-ioc.c | -rw-r--r-- | 10.5 KB |
| blk-iocost.c | -rw-r--r-- | 97.1 KB |
| blk-iolatency.c | -rw-r--r-- | 29.1 KB |
| blk-ioprio.c | -rw-r--r-- | 5.5 KB |
| blk-ioprio.h | -rw-r--r-- | 540 bytes |
| blk-lib.c | -rw-r--r-- | 9.0 KB |
| blk-map.c | -rw-r--r-- | 18.0 KB |
| blk-merge.c | -rw-r--r-- | 30.6 KB |
| blk-mq-cpumap.c | -rw-r--r-- | 2.2 KB |
| blk-mq-debugfs-zoned.c | -rw-r--r-- | 453 bytes |
| blk-mq-debugfs.c | -rw-r--r-- | 21.6 KB |
| blk-mq-debugfs.h | -rw-r--r-- | 2.4 KB |
| blk-mq-pci.c | -rw-r--r-- | 1.3 KB |
| blk-mq-rdma.c | -rw-r--r-- | 1.3 KB |
| blk-mq-sched.c | -rw-r--r-- | 17.6 KB |
| blk-mq-sched.h | -rw-r--r-- | 2.5 KB |
| blk-mq-sysfs.c | -rw-r--r-- | 7.1 KB |
| blk-mq-tag.c | -rw-r--r-- | 18.3 KB |
| blk-mq-tag.h | -rw-r--r-- | 2.2 KB |
| blk-mq-virtio.c | -rw-r--r-- | 1.3 KB |
| blk-mq.c | -rw-r--r-- | 123.1 KB |
| blk-mq.h | -rw-r--r-- | 11.2 KB |
| blk-pm.c | -rw-r--r-- | 6.6 KB |
| blk-pm.h | -rw-r--r-- | 763 bytes |
| blk-rq-qos.c | -rw-r--r-- | 6.9 KB |
| blk-rq-qos.h | -rw-r--r-- | 5.7 KB |
| blk-settings.c | -rw-r--r-- | 30.2 KB |
| blk-stat.c | -rw-r--r-- | 5.4 KB |
| blk-stat.h | -rw-r--r-- | 4.8 KB |
| blk-sysfs.c | -rw-r--r-- | 23.0 KB |
| blk-throttle.c | -rw-r--r-- | 66.8 KB |
| blk-throttle.h | -rw-r--r-- | 6.4 KB |
| blk-timeout.c | -rw-r--r-- | 4.1 KB |
| blk-wbt.c | -rw-r--r-- | 20.4 KB |
| blk-wbt.h | -rw-r--r-- | 3.0 KB |
| blk-zoned.c | -rw-r--r-- | 16.6 KB |
| blk.h | -rw-r--r-- | 14.5 KB |
| bounce.c | -rw-r--r-- | 6.8 KB |
| bsg-lib.c | -rw-r--r-- | 9.8 KB |
| bsg.c | -rw-r--r-- | 6.2 KB |
| disk-events.c | -rw-r--r-- | 12.9 KB |
| elevator.c | -rw-r--r-- | 18.4 KB |
| elevator.h | -rw-r--r-- | 5.5 KB |
| fops.c | -rw-r--r-- | 16.4 KB |
| genhd.c | -rw-r--r-- | 37.3 KB |
| holder.c | -rw-r--r-- | 3.8 KB |
| ioctl.c | -rw-r--r-- | 16.5 KB |
| ioprio.c | -rw-r--r-- | 5.8 KB |
| kyber-iosched.c | -rw-r--r-- | 27.9 KB |
| mq-deadline.c | -rw-r--r-- | 33.6 KB |
| opal_proto.h | -rw-r--r-- | 9.5 KB |
| sed-opal.c | -rw-r--r-- | 65.9 KB |
| t10-pi.c | -rw-r--r-- | 12.5 KB |
Computing file changes ...
