https://github.com/torvalds/linux
Revision 1f810d2b6b2fbdc5279644d8b2c140b1f7c9d43d authored by Pierre-Louis Bossart on 16 February 2023, 16:23:40 UTC, committed by Mark Brown on 16 February 2023, 16:31:15 UTC
The HDaudio stream allocation is done first, and in a second step the
LOSIDV parameter is programmed for the multi-link used by a codec.
This leads to a possible stream_tag leak, e.g. if a DisplayAudio link
is not used. This would happen when a non-Intel graphics card is used
and userspace unconditionally uses the Intel Display Audio PCMs without
checking if they are connected to a receiver with jack controls.
We should first check that there is a valid multi-link entry to
configure before allocating a stream_tag. This change aligns the
dma_assign and dma_cleanup phases.
Complements: b0cd60f3e9f5 ("ALSA/ASoC: hda: clarify bus_get_link() and bus_link_get() helpers")
Link: https://github.com/thesofproject/linux/issues/4151
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230216162340.19480-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 5afc7ee
Tip revision: 1f810d2b6b2fbdc5279644d8b2c140b1f7c9d43d authored by Pierre-Louis Bossart on 16 February 2023, 16:23:40 UTC
ASoC: SOF: Intel: hda-dai: fix possible stream_tag leak
ASoC: SOF: Intel: hda-dai: fix possible stream_tag leak
Tip revision: 1f810d2
| File | Mode | Size |
|---|---|---|
| altera-stapl | ||
| bcm-vk | ||
| c2port | ||
| cardreader | ||
| cb710 | ||
| cxl | ||
| echo | ||
| eeprom | ||
| genwqe | ||
| habanalabs | ||
| ibmasm | ||
| lis3lv02d | ||
| lkdtm | ||
| mchp_pci1xxxx | ||
| mei | ||
| ocxl | ||
| pvpanic | ||
| sgi-gru | ||
| sgi-xp | ||
| ti-st | ||
| uacce | ||
| vmw_vmci | ||
| Kconfig | -rw-r--r-- | 17.8 KB |
| Makefile | -rw-r--r-- | 2.4 KB |
| ad525x_dpot-i2c.c | -rw-r--r-- | 2.6 KB |
| ad525x_dpot-spi.c | -rw-r--r-- | 2.8 KB |
| ad525x_dpot.c | -rw-r--r-- | 20.2 KB |
| ad525x_dpot.h | -rw-r--r-- | 7.9 KB |
| apds9802als.c | -rw-r--r-- | 7.0 KB |
| apds990x.c | -rw-r--r-- | 33.2 KB |
| atmel-ssc.c | -rw-r--r-- | 5.9 KB |
| bh1770glc.c | -rw-r--r-- | 36.7 KB |
| cs5535-mfgpt.c | -rw-r--r-- | 10.0 KB |
| ds1682.c | -rw-r--r-- | 6.9 KB |
| dummy-irq.c | -rw-r--r-- | 1.4 KB |
| dw-xdata-pcie.c | -rw-r--r-- | 9.7 KB |
| enclosure.c | -rw-r--r-- | 18.3 KB |
| fastrpc.c | -rw-r--r-- | 57.6 KB |
| gehc-achc.c | -rw-r--r-- | 12.6 KB |
| hi6421v600-irq.c | -rw-r--r-- | 7.5 KB |
| hisi_hikey_usb.c | -rw-r--r-- | 7.3 KB |
| hmc6352.c | -rw-r--r-- | 3.4 KB |
| hpilo.c | -rw-r--r-- | 22.0 KB |
| hpilo.h | -rw-r--r-- | 5.5 KB |
| ibmvmc.c | -rw-r--r-- | 60.8 KB |
| ibmvmc.h | -rw-r--r-- | 5.2 KB |
| ics932s401.c | -rw-r--r-- | 12.5 KB |
| isl29003.c | -rw-r--r-- | 10.9 KB |
| isl29020.c | -rw-r--r-- | 4.9 KB |
| kgdbts.c | -rw-r--r-- | 30.6 KB |
| lattice-ecp3-config.c | -rw-r--r-- | 5.6 KB |
| open-dice.c | -rw-r--r-- | 5.4 KB |
| pch_phub.c | -rw-r--r-- | 27.0 KB |
| pci_endpoint_test.c | -rw-r--r-- | 24.8 KB |
| phantom.c | -rw-r--r-- | 13.0 KB |
| qcom-coincell.c | -rw-r--r-- | 3.6 KB |
| smpro-errmon.c | -rw-r--r-- | 13.8 KB |
| smpro-misc.c | -rw-r--r-- | 3.2 KB |
| sram-exec.c | -rw-r--r-- | 3.3 KB |
| sram.c | -rw-r--r-- | 11.4 KB |
| sram.h | -rw-r--r-- | 1.2 KB |
| tifm_7xx1.c | -rw-r--r-- | 10.7 KB |
| tifm_core.c | -rw-r--r-- | 8.1 KB |
| tsl2550.c | -rw-r--r-- | 9.9 KB |
| vcpu_stall_detector.c | -rw-r--r-- | 6.0 KB |
| vmw_balloon.c | -rw-r--r-- | 53.4 KB |
| xilinx_sdfec.c | -rw-r--r-- | 38.0 KB |
Computing file changes ...
